[lm-sensors] [CALL FOR TESTERS] i2c-nforce2 support for MCP04 and

[lm-sensors] [CALL FOR TESTERS] i2c-nforce2 support for MCP04 and

[Hans-Frieder Vogt]

*Hi list,

is there anybody on the list who has an nForce4 SLI intel edition or a prototype of the
mainboard with the upcoming nVidia CK8-04u/MCP51 chipset? *
*Unfortunately I haven't got a motherboard with such chipsets available, but I would like
to support these chipsets early on.
**Can you please apply the attached patch and check whether i2c-nforce2 finds the 2 SMBusses.
The output of i2cdetect would be appreciated as an indication that the module not only
finds the busses, but also has the minimum functionality.
The patch is against 2.6.13-rc3-mm1 with the cleanup patch included that I have sent to
the list today. It also applies to vanilla 2.6.13-rc3-mm1, but with some offset.

Thanks for your testing!

--- linux-2.6.13-rc3-mm1.orig/drivers/i2c/busses/i2c-nforce2.c	2005-07-23 14:37:35.160679000 +0200*
*+++ linux-2.6.13-rc3-mm1/drivers/i2c/busses/i2c-nforce2.c	2005-07-23 15:38:57.275289043 +0200*
@@ -30,6 +30,8 @@
     nForce3 Pro150 MCP		00D4
     nForce3 250Gb MCP		00E4
     nForce4 MCP			0052
+    nForce4 I.E. MCP		0034
+    MCP51			0264
 
     This driver supports the 2 SMBuses that are included in the MCP of the
     nForce2/3/4 chipsets.
@@ -52,6 +54,13 @@
 MODULE_AUTHOR ("Hans-Frieder Vogt <hfvogt@arcor.de>");
 MODULE_DESCRIPTION("nForce2 SMBus driver");
 
+/* temporarily needed! */
+#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS
+#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS 0x0034
+#endif
+#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS
+#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS 0x0264
+#endif
 
 struct nforce2_smbus {
 	struct pci_dev *dev;
@@ -271,6 +280,8 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE3_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE3S_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE4_SMBUS) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS) },
 	{ 0 }
 };
 

-- 
--
Hans-Frieder Vogt		e-mail:	hfvogt <at> arcor .dot. de
					hfvogt <at> gmx .dot. net

[lm-sensors] [CALL FOR TESTERS] i2c-nforce2 support for MCP04

[Jean Delvare]

Hi Hans,

> is there anybody on the list who has an nForce4 SLI intel edition or a
> prototype of the mainboard with the upcoming nVidia CK8-04u/MCP51
> chipset?

I do not, sorry.

> Can you please apply the attached patch and check whether
> i2c-nforce2 finds the 2 SMBusses. The output of i2cdetect would be
> appreciated as an indication that the module not only finds the
> busses, but also has the minimum functionality. The patch is against
> 2.6.13-rc3-mm1 with the cleanup patch included that I have sent to the
> list today. It also applies to vanilla 2.6.13-rc3-mm1, but with some
> offset.

But I'd have a comment about the patch:

> +/* temporarily needed! */
> +#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS
> +#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS 0x0034
> +#endif
> +#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS
> +#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS 0x0264
> +#endif

Such constructs are dangerous and should be avoided. These definitions
belong to include/linux/pci_ids.h, please add them there.

Thanks,
-- 
Jean Delvare

[lm-sensors] [CALL FOR TESTERS] i2c-nforce2 support for MCP04 and

[Hans-Frieder Vogt]

Hi Jean,

thank you very much for your comments.
> Hi Hans,
>
> > is there anybody on the list who has an nForce4 SLI intel edition or a
> > prototype of the mainboard with the upcoming nVidia CK8-04u/MCP51
> > chipset?
>
> I do not, sorry.

nForce4 Professional users are also welcome!

>
> > Can you please apply the attached patch and check whether
> > i2c-nforce2 finds the 2 SMBusses. The output of i2cdetect would be
> > appreciated as an indication that the module not only finds the
> > busses, but also has the minimum functionality. The patch is against
> > 2.6.13-rc3-mm1 with the cleanup patch included that I have sent to the
> > list today. It also applies to vanilla 2.6.13-rc3-mm1, but with some
> > offset.
>
> But I'd have a comment about the patch:
> > +/* temporarily needed! */
> > +#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS
> > +#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SMBUS 0x0034
> > +#endif
> > +#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS
> > +#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS 0x0264
> > +#endif
>
> Such constructs are dangerous and should be avoided. These definitions
> belong to include/linux/pci_ids.h, please add them there.
>
Agreed. But before I prepare a patch for pci_ids.h, I want to be sure that
a) the PCI-IDs are really correct (the PCI-IDs are from 
pciids.sourceforge.net, which should be OK)
b) those variants of the nForce? chipsets support smbusses that are compatible 
with the already supported nForce2/3/4 smbusses.

> Thanks,
Thanks as well.

-- 
--
Hans-Frieder Vogt                 e-mail: hfvogt <at> arcor .dot. de
                                          hfvogt <at> gmx .dot. net