From: Pablo Neira <pablo@eurodev.net>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>
Subject: [PATCH 1/7] Fix expectation leak
Date: Mon, 01 Aug 2005 19:04:51 +0200 [thread overview]
Message-ID: <42EE5633.9030307@eurodev.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
expectation refcount is set to 1 in ip_conntrack_expect_alloc, and
incremented again in ip_conntrack_expect_related. So once the
ip_conntrack_expect_free is called, the expectation is never released.
[-- Attachment #2: 00fix-leak-expect.patch --]
[-- Type: text/x-patch, Size: 532 bytes --]
Index: netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_core.c
===================================================================
--- netfilter-2.6.14.orig/net/ipv4/netfilter/ip_conntrack_core.c 2005-08-01 16:20:26.000000000 +0200
+++ netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_core.c 2005-08-01 16:24:47.000000000 +0200
@@ -970,7 +970,6 @@
static void ip_conntrack_expect_insert(struct ip_conntrack_expect *exp)
{
- atomic_inc(&exp->use);
exp->master->expecting++;
list_add(&exp->list, &ip_conntrack_expect_list);
next reply other threads:[~2005-08-01 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 17:04 Pablo Neira [this message]
2005-08-01 17:12 ` [PATCH 1/7] Fix expectation leak Patrick McHardy
[not found] ` <42EE5EC4.5090303@eurodev.net>
2005-08-01 19:52 ` Patrick McHardy
2005-08-02 12:39 ` Pablo Neira
2005-08-02 21:45 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EE5633.9030307@eurodev.net \
--to=pablo@eurodev.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.