Re: [PATCH 1/7] Fix expectation leak

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:
> expectation refcount is set to 1 in ip_conntrack_expect_alloc, and
> incremented again in ip_conntrack_expect_related. So once the
> ip_conntrack_expect_free is called, the expectation is never released.

This looks wrong. expect_alloc sets it to 1, expect_insert increases it
too 2, the helper then sets puts it when done with it, so it is 1 while
inserted.

> ------------------------------------------------------------------------
> 
> Index: netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_core.c
> ===================================================================
> --- netfilter-2.6.14.orig/net/ipv4/netfilter/ip_conntrack_core.c	2005-08-01 16:20:26.000000000 +0200
> +++ netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_core.c	2005-08-01 16:24:47.000000000 +0200
> @@ -970,7 +970,6 @@
>  
>  static void ip_conntrack_expect_insert(struct ip_conntrack_expect *exp)
>  {
> -	atomic_inc(&exp->use);
>  	exp->master->expecting++;
>  	list_add(&exp->list, &ip_conntrack_expect_list);
>