[PATCH 3/7] Fix warnings when debug mode is on

[PATCH 3/7] Fix warnings when debug mode is on

[Pablo Neira]

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

Fix some warnings when DEBUGP is set.

[-- Attachment #2: 02debug-warning.patch --]
[-- Type: text/x-patch, Size: 1085 bytes --]

Index: netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
--- netfilter-2.6.14.orig/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-08-01 16:25:00.000000000 +0200
+++ netfilter-2.6.14/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-08-01 16:25:04.000000000 +0200
@@ -436,7 +436,7 @@
 	struct list_head *i;
 	u_int32_t *id = (u_int32_t *) &cb->args[1];
 
-	DEBUGP("entered %s, last bucket=%u id=%u\n", __FUNCTION__, 
+	DEBUGP("entered %s, last bucket=%lu id=%u\n", __FUNCTION__, 
 			cb->args[0], *id);
 
 	write_lock_bh(&ip_conntrack_lock);
@@ -1207,7 +1207,7 @@
 	struct list_head *i;
 	u_int32_t *id = (u_int32_t *) &cb->args[0];
 
-	DEBUGP("entered %s, last id=%llu\n", __FUNCTION__, *id);
+	DEBUGP("entered %s, last id=%u\n", __FUNCTION__, *id);
 
 	read_lock_bh(&ip_conntrack_lock);
 	list_for_each(i, &ip_conntrack_expect_list) {
@@ -1224,7 +1224,7 @@
 out:	
 	read_unlock_bh(&ip_conntrack_lock);
 
-	DEBUGP("leaving, last id=%llu\n", *id);
+	DEBUGP("leaving, last id=%u\n", *id);
 
 	return skb->len;
 }

Re: [PATCH 3/7] Fix warnings when debug mode is on

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On Mon, Aug 01, 2005 at 07:05:03PM +0200, Pablo Neira wrote:
> Fix some warnings when DEBUGP is set.

Thanks, looks sane to me, I'll apply it

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH 3/7] Fix warnings when debug mode is on

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

On Mon, Aug 01, 2005 at 07:05:03PM +0200, Pablo Neira wrote:
> Fix some warnings when DEBUGP is set.

no, this actually is not sane.  There are some pointer/... specific
format strings.  You compile for i386, therefore you get warnings.  I
compile with x86_64 by default, and I don't get warnings.

Please read some C99 reference and submit patches with the correct
format string modifier (I don't remember them off my head) and submit an
upated patch.
-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]