Re: [Xen-changelog] Fixes.

Re: [Xen-changelog] Fixes.

[Hollis Blanchard]

On Tuesday 02 August 2005 10:42, Xen patchbot -unstable wrote:
> # HG changeset patch
> # User smh22@firebug.cl.cam.ac.uk
> # Node ID 59e76450e286240decceda23eca343ec4604124f
> # Parent  48dea637aac96bcbabe788d036b52570520cc82e
> Fixes.

Sorry, but could we not make checkin comments like "Fixes."? It would just 
take a few more seconds to describe it in a complete sentence...

Thanks.

> diff -r 48dea637aac9 -r 59e76450e286 tools/consoled/Makefile
> --- a/tools/consoled/Makefile	Tue Aug  2 14:51:06 2005
> +++ b/tools/consoled/Makefile	Tue Aug  2 15:42:06 2005
> @@ -24,14 +24,14 @@
>
>  HDRS     = $(wildcard *.h)
>  OBJS     = $(patsubst %.c,%.o,$(SRCS))
> -BIN      = consoled
> +BIN      = consoled xc_console
>
> -all: $(BIN) xc_console
> +all: $(BIN)
>
>  clean:
> -	$(RM) *.a *.so *.o *.rpm $(BIN) xc_console
> +	$(RM) *.a *.so *.o *.rpm $(BIN)
>
> -$(BIN): $(OBJS)
> +consoled: $(OBJS)
>  	$(CC) $(CFLAGS) $^ -o $@ -L$(XEN_LIBXC) -L$(XEN_XENSTORE) \
>                -lxc -lxenstore
>
> @@ -41,8 +41,8 @@
>
>  $(OBJS): $(HDRS)
>
> -install: $(BIN) xc_console
> +install: $(BIN)
>  	$(INSTALL_DIR) -p $(DESTDIR)/$(CONSOLED_INSTALL_DIR)
> -	$(INSTALL_PROG) $(BIN) $(DESTDIR)/$(CONSOLED_INSTALL_DIR)
> +	$(INSTALL_PROG) consoled $(DESTDIR)/$(CONSOLED_INSTALL_DIR)
>  	$(INSTALL_DIR) -p $(DESTDIR)/$(XC_CONSOLE_INSTALL_DIR)
>  	$(INSTALL_PROG) xc_console $(DESTDIR)/$(XC_CONSOLE_INSTALL_DIR)
>
> _______________________________________________
> Xen-changelog mailing list
> Xen-changelog@lists.xensource.com
> http://lists.xensource.com/xen-changelog

-- 
Hollis Blanchard
IBM Linux Technology Center

Re: Re: [Xen-changelog] Fixes.

[Steven Hand]

> On Tuesday 02 August 2005 10:42, Xen patchbot -unstable wrote:
> > # HG changeset patch
> > # User smh22@firebug.cl.cam.ac.uk
> > # Node ID 59e76450e286240decceda23eca343ec4604124f
> > # Parent  48dea637aac96bcbabe788d036b52570520cc82e
> > Fixes.
> 
> Sorry, but could we not make checkin comments like "Fixes."? It would just 
> take a few more seconds to describe it in a complete sentence...

Sorry - I thought the fix was so trivial it didn't need a long winded
comment. Myself I use the 'diff' interface on xenbits to discover what
a given check in does. 

S. 

Re: Re: [Xen-changelog] Fixes.

[Nivedita Singhvi]

Steven Hand wrote:
>>On Tuesday 02 August 2005 10:42, Xen patchbot -unstable wrote:
>>
>>># HG changeset patch
>>># User smh22@firebug.cl.cam.ac.uk
>>># Node ID 59e76450e286240decceda23eca343ec4604124f
>>># Parent  48dea637aac96bcbabe788d036b52570520cc82e
>>>Fixes.
>>
>>Sorry, but could we not make checkin comments like "Fixes."? It would just 
>>take a few more seconds to describe it in a complete sentence...

Request seconded.

> Sorry - I thought the fix was so trivial it didn't need a long winded
> comment. Myself I use the 'diff' interface on xenbits to discover what
> a given check in does. 

Wait till you're wading through 3000 of these things to find a
particular one, or looking for something that might address
your bug - you'd really appreciate a few words then, rather
than opening a few thousand diff files..also, helps automated
scripts grep for things and triggers, etc..

thanks,
Nivedita

Re: Re: [Xen-changelog] Fixes.

[Hollis Blanchard]

On Tuesday 02 August 2005 11:28, Steven Hand wrote:
> > On Tuesday 02 August 2005 10:42, Xen patchbot -unstable wrote:
> > > # HG changeset patch
> > > # User smh22@firebug.cl.cam.ac.uk
> > > # Node ID 59e76450e286240decceda23eca343ec4604124f
> > > # Parent  48dea637aac96bcbabe788d036b52570520cc82e
> > > Fixes.
> >
> > Sorry, but could we not make checkin comments like "Fixes."? It would
> > just take a few more seconds to describe it in a complete sentence...
>
> Sorry - I thought the fix was so trivial it didn't need a long winded
> comment. Myself I use the 'diff' interface on xenbits to discover what
> a given check in does.

I should add that I didn't really mean to single out this one particular 
patch... just in general, it would be nice to have at least a one-sentence 
checkin comment. :)

-- 
Hollis Blanchard
IBM Linux Technology Center

Re: Re: [Xen-changelog] Fixes.

[Rusty Russell]

On Tue, 2005-08-02 at 11:23 -0500, Hollis Blanchard wrote:
> On Tuesday 02 August 2005 10:42, Xen patchbot -unstable wrote:
> > # HG changeset patch
> > # User smh22@firebug.cl.cam.ac.uk
> > # Node ID 59e76450e286240decceda23eca343ec4604124f
> > # Parent  48dea637aac96bcbabe788d036b52570520cc82e
> > Fixes.
> 
> Sorry, but could we not make checkin comments like "Fixes."? It would just 
> take a few more seconds to describe it in a complete sentence...

Particularly useful is a cut & paste of the symptoms which the patch
solves, even if trivial. eg (made up example):

	Integrate xc_console properly into makefile.
	Fixes: "install: xc_console: no such file or directory"

This makes great google fodder.
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman