[PATCH 3/3] Make xend start launch XenStore

[PATCH 3/3] Make xend start launch XenStore

[Anthony Liguori]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

The following patch makes tools/misc/xend start up the XenStore.  It 
would be nicer to use init.d scripts to do this sort of stuff but this 
works for now.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

[-- Attachment #2: xenstored_xend.diff --]
[-- Type: text/x-patch, Size: 1234 bytes --]

diff -r 1d240086de52 tools/misc/xend
--- a/tools/misc/xend	Thu Aug  4 15:02:09 2005
+++ b/tools/misc/xend	Thu Aug  4 10:59:48 2005
@@ -114,6 +114,14 @@
         xcs_pidfile.close()
     except:
 	return    
+
+def start_xenstored():
+    if os.fork() == 0:
+        os.execvp('/usr/sbin/xenstored', ['/usr/sbin/xenstored']);
+
+def start_consoled():
+    if os.fork() == 0:
+        os.execvp('/usr/sbin/consoled', ['/usr/sbin/consoled']);
             
 def main():
     try:
@@ -130,11 +138,13 @@
         return status >> 8
     elif sys.argv[1] == 'start':
         start_xcs()
-        if os.fork() == 0:
-            os.execvp('/usr/sbin/consoled', ['/usr/sbin/consoled']);
+        start_xenstored()
+        start_consoled()
         return daemon.start()
     elif sys.argv[1] == 'trace_start':
         start_xcs()
+        start_xenstored()
+        start_consoled()
         return daemon.start(trace=1)
     elif sys.argv[1] == 'stop':
         stop_xcs()
@@ -142,6 +152,8 @@
     elif sys.argv[1] == 'restart':
         stop_xcs()
         start_xcs()
+        start_xenstored()
+        start_consoled()
         return daemon.stop() or daemon.start()
     elif sys.argv[1] == 'status':
         return daemon.status()

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 3/3] Make xend start launch XenStore

[Rusty Russell]

On Thu, 2005-08-04 at 11:05 -0500, Anthony Liguori wrote:
> The following patch makes tools/misc/xend start up the XenStore.  It 
> would be nicer to use init.d scripts to do this sort of stuff but this 
> works for now.

Perhaps a xend debugging switch we can turn on now and turn off closer
to release?

It'd be nice to have xenstored run with --trace-file=...

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

Re: [PATCH 3/3] Make xend start launch XenStore

[Nivedita Singhvi]

Rusty Russell wrote:
> On Thu, 2005-08-04 at 11:05 -0500, Anthony Liguori wrote:
> 
>>The following patch makes tools/misc/xend start up the XenStore.  It 
>>would be nicer to use init.d scripts to do this sort of stuff but this 
>>works for now.
> 
> 
> Perhaps a xend debugging switch we can turn on now and turn off closer
> to release?
> 
> It'd be nice to have xenstored run with --trace-file=...

I think this is a good idea.

And I'd even recommend turning xen debug on by default for the next
month or so (I seriously doubt anyone is running current xen-unstable
in a production environment - ??).

Here are the current defaults, as seen in xen/Rules.mk:


verbose     ?= n
debug       ?= n
perfc       ?= n
perfc_arrays?= n
trace       ?= n
optimize    ?= y
domu_debug  ?= n
crash_debug ?= n

Would anyone else agree to:

verbose     ?= n
debug       ?= y
perfc       ?= n
perfc_arrays?= n
trace       ?= y
optimize    ?= y
domu_debug  ?= y
crash_debug ?= y

thanks,
Nivedita