All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org, linux-ia64@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64
Date: Thu, 11 Aug 2005 23:49:12 +0000	[thread overview]
Message-ID: <42FBE3F8.1090006@pobox.com> (raw)
In-Reply-To: <200508111707.30861.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> You deduce this by the absence of SecO and PriO?  I wonder if lspci
> should be enhanced to notice this, too.  I assume that the IRQ 169
> doesn't correspond to anything in /proc/interrupts.

Correct.


> So the scenario in question (correct me if I'm wrong) is that we
> have a PCI IDE device that is handed off in compatibility mode (and
> may only work in that mode).  In that case, the PCI *device* still
> exists, so shouldn't the IDE PCI code claim that device, notice that
> it's in compatibility mode, and use the legacy ports and IRQs if
> necessary?
> 
> It seems like that all should work even if we don't have IDE_GENERIC.

Yes, you're right.  Thinking more, the PCI IDE code should pick that up, 
not the IDE_GENERIC code.

	Jeff



WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org, linux-ia64@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64
Date: Thu, 11 Aug 2005 19:49:12 -0400	[thread overview]
Message-ID: <42FBE3F8.1090006@pobox.com> (raw)
In-Reply-To: <200508111707.30861.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> You deduce this by the absence of SecO and PriO?  I wonder if lspci
> should be enhanced to notice this, too.  I assume that the IRQ 169
> doesn't correspond to anything in /proc/interrupts.

Correct.


> So the scenario in question (correct me if I'm wrong) is that we
> have a PCI IDE device that is handed off in compatibility mode (and
> may only work in that mode).  In that case, the PCI *device* still
> exists, so shouldn't the IDE PCI code claim that device, notice that
> it's in compatibility mode, and use the legacy ports and IRQs if
> necessary?
> 
> It seems like that all should work even if we don't have IDE_GENERIC.

Yes, you're right.  Thinking more, the PCI IDE code should pick that up, 
not the IDE_GENERIC code.

	Jeff



  reply	other threads:[~2005-08-11 23:49 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-11 20:24 [PATCH] IDE: don't offer IDE_GENERIC on ia64 Bjorn Helgaas
2005-08-11 20:24 ` Bjorn Helgaas
2005-08-11 20:34 ` Christoph Hellwig
2005-08-11 20:34   ` Christoph Hellwig
2005-08-11 20:37   ` Bjorn Helgaas
2005-08-11 20:37     ` Bjorn Helgaas
2005-08-12 19:41   ` Jan Engelhardt
2005-08-12 19:41     ` Jan Engelhardt
2005-08-16 10:02   ` Bartlomiej Zolnierkiewicz
2005-08-16 10:02     ` Bartlomiej Zolnierkiewicz
2005-08-16 13:42     ` Alan Cox
2005-08-16 14:05       ` Alan Cox
2005-08-11 20:36 ` Jeff Garzik
2005-08-11 20:36   ` Jeff Garzik
2005-08-11 20:45   ` Bjorn Helgaas
2005-08-11 20:45     ` Bjorn Helgaas
2005-08-11 20:56     ` Jeff Garzik
2005-08-11 20:56       ` Jeff Garzik
2005-08-11 21:42       ` Bjorn Helgaas
2005-08-11 21:42         ` Bjorn Helgaas
2005-08-11 21:48         ` Jeff Garzik
2005-08-11 21:48           ` Jeff Garzik
2005-08-11 21:56           ` Jeff Garzik
2005-08-11 21:56             ` Jeff Garzik
2005-08-11 23:07             ` Bjorn Helgaas
2005-08-11 23:07               ` Bjorn Helgaas
2005-08-11 23:49               ` Jeff Garzik [this message]
2005-08-11 23:49                 ` Jeff Garzik
2005-08-12  8:35               ` Alan Cox
2005-08-12  8:35                 ` Alan Cox
2005-08-12 10:33               ` Maciej W. Rozycki
2005-08-12 10:33                 ` Maciej W. Rozycki
2005-08-11 23:01         ` Jack Steiner
2005-08-11 23:01           ` Jack Steiner
2005-08-11 21:58 ` Luck, Tony
2005-08-11 21:58   ` Luck, Tony
2005-08-11 21:58   ` Luck, Tony
2005-08-11 22:03   ` Jeff Garzik
2005-08-11 22:03     ` Jeff Garzik
2005-08-11 23:08 ` Jack Steiner
2005-08-11 23:08   ` Jack Steiner
2005-08-12  8:40 ` Alan Cox
2005-08-12  8:40   ` Alan Cox
2005-08-15 21:07   ` Bjorn Helgaas
2005-08-15 21:07     ` Bjorn Helgaas
2005-08-16  9:38     ` Bartlomiej Zolnierkiewicz
2005-08-16  9:38       ` Bartlomiej Zolnierkiewicz
2005-08-16  9:54       ` Bartlomiej Zolnierkiewicz
2005-08-16  9:54         ` Bartlomiej Zolnierkiewicz
2005-08-16 12:55       ` Alan Cox
2005-08-16 12:55         ` Alan Cox
2005-08-16 12:59         ` Bartlomiej Zolnierkiewicz
2005-08-16 12:59           ` Bartlomiej Zolnierkiewicz
2005-08-16 13:40         ` Matthew Wilcox
2005-08-16 13:40           ` Matthew Wilcox
2005-08-16 13:49           ` Bartlomiej Zolnierkiewicz
2005-08-16 13:49             ` Bartlomiej Zolnierkiewicz
2005-08-16 19:16       ` Bjorn Helgaas
2005-08-16 19:16         ` Bjorn Helgaas
2005-08-16 19:59         ` Alan Cox
2005-08-16 20:25           ` Alan Cox
2005-08-16 20:42           ` Bartlomiej Zolnierkiewicz
2005-08-16 20:42             ` Bartlomiej Zolnierkiewicz
2005-08-16 21:48             ` Alan Cox
2005-08-16 21:48               ` Alan Cox
2005-08-16 20:16         ` Bartlomiej Zolnierkiewicz
2005-08-16 20:16           ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42FBE3F8.1090006@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.