[KJ] argument type of generic_fls()

[KJ] argument type of generic_fls()

[walter harms]

hi list,
after the log2 discussion i was looking for log2 in kernel. i found 
long_log2() in page_alloc.c. What the author actualy wanted was fls().
To my confusion the generic_fls() searches only 32 bit but has an 
argument of type int (i would expect uint32).
Will it create confusion with 64bit int systems ? if anyone considers 
these a problem i would add a flsl() function and replace the int with 
uint32.

re
	walter
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] argument type of generic_fls()

[Adrian Bunk]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Sat, Aug 13, 2005 at 03:42:59PM +0200, walter harms wrote:

> hi list,

Hi Walter,

> after the log2 discussion i was looking for log2 in kernel. i found 
> long_log2() in page_alloc.c. What the author actualy wanted was fls().
> To my confusion the generic_fls() searches only 32 bit but has an 
> argument of type int (i would expect uint32).
> Will it create confusion with 64bit int systems ? if anyone considers 
> these a problem i would add a flsl() function and replace the int with 
> uint32.

ints stay 32bit on 64bit systems.

> re
> 	walter

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors