All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: "James Prestwood" <prestwoj@gmail.com>,
	"Jonas Große Sundrup" <cherti-iwd@letopolis.de>,
	iwd@lists.linux.dev
Subject: Re: Force use of 5GHz band
Date: Fri, 15 Sep 2023 09:47:13 -0500	[thread overview]
Message-ID: <42efcf9a-6aca-c728-ba9d-fe95a6066900@gmail.com> (raw)
In-Reply-To: <8629e294-0550-436d-91b3-e0cf1c84f8e7@gmail.com>

Hi James,

>> Careful about using high factors like this.  Right now the rank is computed 
>> using a double, but truncated to a uint32_t and clamped to USHRT_MAX / 
>> uint16_t.  This works fine, but the FT roaming calculation is a bit more 
>> careless.  Could lead to very funny results.
> 
> I don't think FT uses that ranking factor, but either way yes some huge factor 
> like that shouldn't be needed.
> 

Right, but it uses another factor and truncates to a uint16_t.  So if you have 
USHRT_MAX as rank, multiply then truncate -> fun things happen.

>>
>> We may be better off introducing 2.4GHz factor and suggesting using a 0.0 
>> multiplier to turn bands off.  Or add an explicit setting.
> 
> I actually was thinking this would be nice. We actually don't even run a 2.4ghz 
> network at all so that would reduce extra scanning cycles, even if just a couple 
> seconds. I'll go ahead and add support for 0.0 factors disabling the band, and 
> add a 2.4 factor setting.

Excellent.

Regards,
-Denis

  reply	other threads:[~2023-09-15 14:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 17:44 Force use of 5GHz band Jonas Große Sundrup
2023-09-14 18:06 ` James Prestwood
2023-09-14 18:13   ` Jonas Große Sundrup
2023-09-14 18:16     ` James Prestwood
2023-09-14 18:22       ` Jonas Große Sundrup
2023-09-14 18:33         ` James Prestwood
2023-09-14 18:46           ` Jonas Große Sundrup
2023-09-15 14:35             ` Denis Kenzior
2023-09-15 14:44               ` James Prestwood
2023-09-15 14:55                 ` Denis Kenzior
2023-09-15 14:30           ` Denis Kenzior
2023-09-15 14:42             ` James Prestwood
2023-09-15 14:47               ` Denis Kenzior [this message]
2023-09-15 17:36                 ` James Prestwood
2023-09-16 15:18                   ` Denis Kenzior
2023-09-19 17:29                     ` James Prestwood
2023-09-21 14:21   ` Alvin Šipraga
2023-09-21 14:50     ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42efcf9a-6aca-c728-ba9d-fe95a6066900@gmail.com \
    --to=denkenz@gmail.com \
    --cc=cherti-iwd@letopolis.de \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.