All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: Force use of 5GHz band
Date: Sat, 16 Sep 2023 10:18:01 -0500	[thread overview]
Message-ID: <a61e3a1d-9e97-89c1-d543-6b6ba9860146@gmail.com> (raw)
In-Reply-To: <e144f8a4-82b2-4882-bf25-5fac6165b9af@gmail.com>

Hi James,

> 
> How would you prefer I do this? We've got quite a few modules using scan APIs so 
> I question if we want to filter the frequencies before calling scan_*

We should be doing that already, no?  Any code that specifies scan frequencies 
in some way should be aware of wiphy band capability and regdom.

> 
> If we filter in scan.c and call back as if the scan returned no results we 
> shouldn't need to touch anything except scan.c. The downside is its a bit of 

I really rather not generate dummy/bogus callbacks.  That just pollutes debug 
logs and makes the code hard to follow.  Station would be most affected here 
since it breaks up the 2.4Ghz band scan quite a bit.

If 2.4 is turned off, it should just skip those requests entirely.

> wasted work doing this since we have to create requests and work items for 
> nothing, but the alternative of adding this specific logic to each module using 
> scan calls seems worse IMO, what do you think?
> 

One thing to keep in mind is that some devices operate only on 2.4G.  For 
example WSC/WPS might only perform push button operations on 2.4 GHz band and 
not 5G.  Might be similar with DPP?  So for compatibility reasons maybe this 
should be a station-only feature?

Regards,
-Denis


  reply	other threads:[~2023-09-16 15:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 17:44 Force use of 5GHz band Jonas Große Sundrup
2023-09-14 18:06 ` James Prestwood
2023-09-14 18:13   ` Jonas Große Sundrup
2023-09-14 18:16     ` James Prestwood
2023-09-14 18:22       ` Jonas Große Sundrup
2023-09-14 18:33         ` James Prestwood
2023-09-14 18:46           ` Jonas Große Sundrup
2023-09-15 14:35             ` Denis Kenzior
2023-09-15 14:44               ` James Prestwood
2023-09-15 14:55                 ` Denis Kenzior
2023-09-15 14:30           ` Denis Kenzior
2023-09-15 14:42             ` James Prestwood
2023-09-15 14:47               ` Denis Kenzior
2023-09-15 17:36                 ` James Prestwood
2023-09-16 15:18                   ` Denis Kenzior [this message]
2023-09-19 17:29                     ` James Prestwood
2023-09-21 14:21   ` Alvin Šipraga
2023-09-21 14:50     ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a61e3a1d-9e97-89c1-d543-6b6ba9860146@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.