From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support
Date: Mon, 20 Oct 2014 21:37:14 +0200 [thread overview]
Message-ID: <4301925.4pMHXMXqA4@wuerfel> (raw)
In-Reply-To: <1413374436-14410-1-git-send-email-sthokal@xilinx.com>
On Wednesday 15 October 2014 17:30:36 Srikanth Thokala wrote:
> @@ -15,6 +15,9 @@
> #include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
>
> +/* Number of AXI DMA APP Words */
> +#define XILINX_DMA_NUM_APP_WORDS 5
> +
> /**
> * struct xilinx_vdma_config - VDMA Configuration structure
> * @frm_dly: Frame delay
> @@ -41,7 +44,21 @@ struct xilinx_vdma_config {
> int ext_fsync;
> };
>
> +/**
> + * struct xilinx_dma_config - DMA Configuration structure
> + * @coalesc: Interrupt coalescing threshold
> + * @delay: Delay counter
> + * @reset: Reset Channel
> + */
> +struct xilinx_dma_config {
> + int coalesc;
> + int delay;
> + int reset;
> +};
> +
> int xilinx_vdma_channel_set_config(struct dma_chan *dchan,
> struct xilinx_vdma_config *cfg);
> +int xilinx_dma_channel_set_config(struct dma_chan *dchan,
> + struct xilinx_dma_config *cfg);
>
You add this to a global header file, but I don't see any uses outside
of the driver itself. Please move all of this into the driver itself
and remove the header file.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Srikanth Thokala <sthokal@xilinx.com>,
vinod.koul@intel.com, dan.j.williams@intel.com,
michals@xilinx.com, grant.likely@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, svemula@xilinx.com,
linux-kernel@vger.kernel.org, anirudh@xilinx.com,
dmaengine@vger.kernel.org, appanad@xilinx.com
Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support
Date: Mon, 20 Oct 2014 21:37:14 +0200 [thread overview]
Message-ID: <4301925.4pMHXMXqA4@wuerfel> (raw)
In-Reply-To: <1413374436-14410-1-git-send-email-sthokal@xilinx.com>
On Wednesday 15 October 2014 17:30:36 Srikanth Thokala wrote:
> @@ -15,6 +15,9 @@
> #include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
>
> +/* Number of AXI DMA APP Words */
> +#define XILINX_DMA_NUM_APP_WORDS 5
> +
> /**
> * struct xilinx_vdma_config - VDMA Configuration structure
> * @frm_dly: Frame delay
> @@ -41,7 +44,21 @@ struct xilinx_vdma_config {
> int ext_fsync;
> };
>
> +/**
> + * struct xilinx_dma_config - DMA Configuration structure
> + * @coalesc: Interrupt coalescing threshold
> + * @delay: Delay counter
> + * @reset: Reset Channel
> + */
> +struct xilinx_dma_config {
> + int coalesc;
> + int delay;
> + int reset;
> +};
> +
> int xilinx_vdma_channel_set_config(struct dma_chan *dchan,
> struct xilinx_vdma_config *cfg);
> +int xilinx_dma_channel_set_config(struct dma_chan *dchan,
> + struct xilinx_dma_config *cfg);
>
You add this to a global header file, but I don't see any uses outside
of the driver itself. Please move all of this into the driver itself
and remove the header file.
Arnd
next prev parent reply other threads:[~2014-10-20 19:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 12:00 [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support Srikanth Thokala
2014-10-15 12:00 ` Srikanth Thokala
2014-10-15 12:45 ` Mark Rutland
2014-10-15 12:45 ` Mark Rutland
2014-10-15 13:32 ` Vinod Koul
2014-10-15 13:32 ` Vinod Koul
2014-10-15 15:00 ` Mark Rutland
2014-10-15 15:00 ` Mark Rutland
2014-10-15 15:00 ` Mark Rutland
2014-10-15 14:34 ` Srikanth Thokala
2014-10-15 14:34 ` Srikanth Thokala
2014-10-20 19:37 ` Arnd Bergmann [this message]
2014-10-20 19:37 ` Arnd Bergmann
2014-10-21 9:06 ` Appana Durga Kedareswara Rao
2014-10-21 9:06 ` Appana Durga Kedareswara Rao
2014-10-21 9:06 ` Appana Durga Kedareswara Rao
2014-10-21 9:14 ` Arnd Bergmann
2014-10-21 9:14 ` Arnd Bergmann
2014-10-24 12:08 ` Appana Durga Kedareswara Rao
2014-10-24 12:08 ` Appana Durga Kedareswara Rao
2014-10-24 12:08 ` Appana Durga Kedareswara Rao
2014-10-24 13:58 ` Arnd Bergmann
2014-10-24 13:58 ` Arnd Bergmann
2015-01-19 14:08 ` Appana Durga Kedareswara Rao
2015-01-19 14:08 ` Appana Durga Kedareswara Rao
2015-01-19 14:08 ` Appana Durga Kedareswara Rao
2015-01-29 11:24 ` Appana Durga Kedareswara Rao
2015-01-29 11:24 ` Appana Durga Kedareswara Rao
2015-01-29 11:24 ` Appana Durga Kedareswara Rao
2015-02-12 9:34 ` Vinod Koul
2015-02-12 9:34 ` Vinod Koul
2015-02-14 14:21 ` Appana Durga Kedareswara Rao
2015-02-14 14:21 ` Appana Durga Kedareswara Rao
2015-02-20 6:29 ` Vinod Koul
2015-02-20 6:29 ` Vinod Koul
2015-02-20 6:29 ` Vinod Koul
2015-02-20 10:42 ` Michal Simek
2015-02-20 10:42 ` Michal Simek
2015-03-02 16:38 ` Vinod Koul
2015-03-02 16:38 ` Vinod Koul
2015-03-02 16:38 ` Vinod Koul
[not found] ` <54E70F97.30908@xilinx.com>
2015-03-02 9:04 ` Appana Durga Kedareswara Rao
2015-03-02 9:04 ` Appana Durga Kedareswara Rao
2015-02-05 13:31 ` Appana Durga Kedareswara Rao
2015-02-05 13:31 ` Appana Durga Kedareswara Rao
2015-02-05 13:31 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4301925.4pMHXMXqA4@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.