From: Sinan Kaya <okaya@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
agross@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org,
dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe
Date: Tue, 28 Apr 2020 16:29:49 -0400 [thread overview]
Message-ID: <430381bf-4fa5-80f7-4dcb-9e30d24e57ce@kernel.org> (raw)
In-Reply-To: <20200428172116.GG2014@kadam>
On 4/28/2020 1:21 PM, Dan Carpenter wrote:
> What I meant to say here was:
>
> if (msi) {
> rc = hidma_request_msi(dmadev, pdev);
> if (rc)
> msi = false;
>
> Otherwise we end up checking freeing the msi in the error handling
> code when we did not take it.
>
> Hopefully, that clears things up?
Yes, that works. However, I'd rather use a different flag for this
in order not to mix the meaning of msi capability vs. msi allocation
failure.
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
agross@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org,
dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe
Date: Tue, 28 Apr 2020 20:29:49 +0000 [thread overview]
Message-ID: <430381bf-4fa5-80f7-4dcb-9e30d24e57ce@kernel.org> (raw)
In-Reply-To: <20200428172116.GG2014@kadam>
On 4/28/2020 1:21 PM, Dan Carpenter wrote:
> What I meant to say here was:
>
> if (msi) {
> rc = hidma_request_msi(dmadev, pdev);
> if (rc)
> msi = false;
>
> Otherwise we end up checking freeing the msi in the error handling
> code when we did not take it.
>
> Hopefully, that clears things up?
Yes, that works. However, I'd rather use a different flag for this
in order not to mix the meaning of msi capability vs. msi allocation
failure.
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
vkoul@kernel.org, agross@kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe
Date: Tue, 28 Apr 2020 16:29:49 -0400 [thread overview]
Message-ID: <430381bf-4fa5-80f7-4dcb-9e30d24e57ce@kernel.org> (raw)
In-Reply-To: <20200428172116.GG2014@kadam>
On 4/28/2020 1:21 PM, Dan Carpenter wrote:
> What I meant to say here was:
>
> if (msi) {
> rc = hidma_request_msi(dmadev, pdev);
> if (rc)
> msi = false;
>
> Otherwise we end up checking freeing the msi in the error handling
> code when we did not take it.
>
> Hopefully, that clears things up?
Yes, that works. However, I'd rather use a different flag for this
in order not to mix the meaning of msi capability vs. msi allocation
failure.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 20:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 11:10 [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe Christophe JAILLET
2020-04-27 11:10 ` Christophe JAILLET
2020-04-27 11:10 ` Christophe JAILLET
2020-04-27 16:08 ` Vinod Koul
2020-04-27 16:20 ` Vinod Koul
2020-04-27 16:08 ` Vinod Koul
2020-04-28 12:54 ` Dan Carpenter
2020-04-28 12:54 ` Dan Carpenter
2020-04-28 12:54 ` Dan Carpenter
2020-04-28 16:01 ` Sinan Kaya
2020-04-28 16:01 ` Sinan Kaya
2020-04-28 16:01 ` Sinan Kaya
2020-04-28 17:21 ` Dan Carpenter
2020-04-28 17:21 ` Dan Carpenter
2020-04-28 17:21 ` Dan Carpenter
2020-04-28 20:29 ` Sinan Kaya [this message]
2020-04-28 20:29 ` Sinan Kaya
2020-04-28 20:29 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430381bf-4fa5-80f7-4dcb-9e30d24e57ce@kernel.org \
--to=okaya@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.