From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
To: xen-devel@lists.xensource.com
Subject: Re: [Patch] by default don't give all memory to dom0
Date: Thu, 18 Aug 2005 20:50:57 +0100 [thread overview]
Message-ID: <4304E6A1.7090800@blueyonder.co.uk> (raw)
In-Reply-To: <20050818122413.C17270@unix-os.sc.intel.com>
Siddha, Suresh B wrote:
[...]
> +static void parse_reserve_dmamem(char *s)
> +{
> + unsigned long long bytes = parse_size_and_unit(s);
> + /* If no unit is specified we default to kB units, not bytes. */
> + if ( isdigit(s[strlen(s)-1]) )
> + reserve_dmapages = (unsigned int)bytes >> (PAGE_SHIFT - 10);
> + else
> + reserve_dmapages = (unsigned int)(bytes >> PAGE_SHIFT);
> +}
Shouldn't the default unit be consistent for all Xen memory parameters?
--
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
next prev parent reply other threads:[~2005-08-18 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-18 19:24 [Patch] by default don't give all memory to dom0 Siddha, Suresh B
2005-08-18 19:50 ` David Hopwood [this message]
2005-08-18 20:28 ` Siddha, Suresh B
2005-08-18 21:55 ` David Hopwood
2005-08-19 0:13 ` Siddha, Suresh B
2005-08-19 8:31 ` Keir Fraser
2005-08-19 23:32 ` Default memory unit David Hopwood
2005-08-20 0:58 ` [Patch] by default don't give all memory to dom0 Siddha, Suresh B
2005-08-19 8:44 ` Keir Fraser
2005-08-19 13:45 ` Mark Williamson
2005-08-20 1:20 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4304E6A1.7090800@blueyonder.co.uk \
--to=david.nospam.hopwood@blueyonder.co.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.