From: Dave Jiang <djiang@mvista.com>
To: linux-scsi@vger.kernel.org
Subject: Adaptec DPT call schedule_timeout with irq off
Date: Fri, 26 Aug 2005 17:45:28 -0700 [thread overview]
Message-ID: <430FB7A8.8020105@mvista.com> (raw)
I noticed that in the Adaptec DPT driver, drivers/scsi/dpt_i2o.c in
funciton adapt_i2o_post_wait() around line 1161ish. spin_lock_irqsave()
is called. However then spin_unlock() is called 2 lines later and
leaving IRQ disabled. Then a little bit later, schedule_timeout() is
called with IRQ off. Isn't that bad? Why was irq left off earlier
instead of doing spin_unlock_irqrestore()? Am I missing something.....
Please cc me on replies. Thank you!
--
Dave
reply other threads:[~2005-08-27 0:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430FB7A8.8020105@mvista.com \
--to=djiang@mvista.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.