* Adaptec DPT call schedule_timeout with irq off
@ 2005-08-27 0:45 Dave Jiang
0 siblings, 0 replies; only message in thread
From: Dave Jiang @ 2005-08-27 0:45 UTC (permalink / raw)
To: linux-scsi
I noticed that in the Adaptec DPT driver, drivers/scsi/dpt_i2o.c in
funciton adapt_i2o_post_wait() around line 1161ish. spin_lock_irqsave()
is called. However then spin_unlock() is called 2 lines later and
leaving IRQ disabled. Then a little bit later, schedule_timeout() is
called with IRQ off. Isn't that bad? Why was irq left off earlier
instead of doing spin_unlock_irqrestore()? Am I missing something.....
Please cc me on replies. Thank you!
--
Dave
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-08-27 0:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-27 0:45 Adaptec DPT call schedule_timeout with irq off Dave Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.