All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] New ipt_TTL target
@ 2005-08-26 18:31 Harald Welte
  2005-08-26 19:30 ` David S. Miller
  0 siblings, 1 reply; 8+ messages in thread
From: Harald Welte @ 2005-08-26 18:31 UTC (permalink / raw)
  To: David Miller; +Cc: Netfilter Development Mailinglist


[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]

Hi Dave, 

please apply to net-2.6.14

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #1.2: 49-ttl_target.patch --]
[-- Type: text/plain, Size: 6553 bytes --]

[NETFILTER] Add new iptables TTL target

This new iptables target allows manipulation of the TTL of an IPv4 packet.

Signed-off-by: Harald Welte <laforge@netfilter.org>

---
commit cc7aa6d99761490f788fa3c61135e477172f1133
tree 4037f3264dbe6371d4cf68249804a4ca095eaa08
parent 2a4bde3e92bd6856a8b8ad479e90d7b0a41cda22
author Harald Welte <laforge@netfilter.org> Fr, 26 Aug 2005 20:17:31 +0200
committer Harald Welte <laforge@netfilter.org> Fr, 26 Aug 2005 20:17:31 +0200

 include/linux/netfilter_ipv4/ipt_TTL.h |   21 +++++
 net/ipv4/netfilter/Kconfig             |   20 +++++
 net/ipv4/netfilter/Makefile            |    1 
 net/ipv4/netfilter/ipt_TTL.c           |  135 ++++++++++++++++++++++++++++++++
 4 files changed, 177 insertions(+), 0 deletions(-)

diff --git a/include/linux/netfilter_ipv4/ipt_TTL.h b/include/linux/netfilter_ipv4/ipt_TTL.h
new file mode 100644
--- /dev/null
+++ b/include/linux/netfilter_ipv4/ipt_TTL.h
@@ -0,0 +1,21 @@
+/* TTL modification module for IP tables
+ * (C) 2000 by Harald Welte <laforge@netfilter.org> */
+
+#ifndef _IPT_TTL_H
+#define _IPT_TTL_H
+
+enum {
+	IPT_TTL_SET = 0,
+	IPT_TTL_INC,
+	IPT_TTL_DEC
+};
+
+#define IPT_TTL_MAXMODE	IPT_TTL_DEC
+
+struct ipt_TTL_info {
+	u_int8_t	mode;
+	u_int8_t	ttl;
+};
+
+
+#endif
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -664,6 +664,26 @@ config IP_NF_TARGET_CLASSIFY
 
 	  To compile it as a module, choose M here.  If unsure, say N.
 
+config IP_NF_TARGET_TTL
+	tristate  'TTL target support'
+	depends on IP_NF_MANGLE
+	help
+	  This option adds a `TTL' target, which enables the user to decrement
+	  the TTL value of the IP header or set it to a given (lower) value.
+	
+	  If you want to compile it as a module, say M here and read
+	  Documentation/modules.txt.  If unsure, say `N'.
+
+config IP_NF_TARGET_TTL_INC
+	bool  'TTL incrementing support (DANGEROUS)'
+	depends on IP_NF_TARGET_TTL
+	help
+	  This option enables functionality to increment and set the TTL
+	  value of the IP header to arbitrary values.  This is EXTREMELY
+	  DANGEROUS since you can easily create immortal packets that loop
+	  forever on the network.  Please only enable if you really know
+	  that you will need it.
+
 config IP_NF_TARGET_CONNMARK
 	tristate  'CONNMARK target support'
 	depends on IP_NF_CONNTRACK_MARK && IP_NF_MANGLE
diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -85,6 +85,7 @@ obj-$(CONFIG_IP_NF_TARGET_ULOG) += ipt_U
 obj-$(CONFIG_IP_NF_TARGET_TCPMSS) += ipt_TCPMSS.o
 obj-$(CONFIG_IP_NF_TARGET_NOTRACK) += ipt_NOTRACK.o
 obj-$(CONFIG_IP_NF_TARGET_CLUSTERIP) += ipt_CLUSTERIP.o
+obj-$(CONFIG_IP_NF_TARGET_TTL) += ipt_TTL.o
 
 # generic ARP tables
 obj-$(CONFIG_IP_NF_ARPTABLES) += arp_tables.o
diff --git a/net/ipv4/netfilter/ipt_TTL.c b/net/ipv4/netfilter/ipt_TTL.c
new file mode 100644
--- /dev/null
+++ b/net/ipv4/netfilter/ipt_TTL.c
@@ -0,0 +1,135 @@
+/* TTL modification target for IP tables
+ * (C) 2000,2005 by Harald Welte <laforge@netfilter.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/skbuff.h>
+#include <linux/ip.h>
+#include <net/checksum.h>
+
+#include <linux/netfilter_ipv4/ip_tables.h>
+#include <linux/netfilter_ipv4/ipt_TTL.h>
+
+MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>");
+MODULE_DESCRIPTION("IP tables TTL modification module");
+MODULE_LICENSE("GPL");
+
+static unsigned int 
+ipt_ttl_target(struct sk_buff **pskb, const struct net_device *in, 
+		const struct net_device *out, unsigned int hooknum, 
+		const void *targinfo, void *userinfo)
+{
+	struct iphdr *iph;
+	const struct ipt_TTL_info *info = targinfo;
+	u_int16_t diffs[2];
+	int new_ttl;
+
+	if (!skb_make_writable(pskb, (*pskb)->len))
+		return NF_DROP;
+
+	iph = (*pskb)->nh.iph;
+
+	switch (info->mode) {
+		case IPT_TTL_SET:
+			new_ttl = info->ttl;
+			break;
+		case IPT_TTL_INC:
+			new_ttl = iph->ttl + info->ttl;
+			if (new_ttl > 255)
+				new_ttl = 255;
+			break;
+		case IPT_TTL_DEC:
+			new_ttl = iph->ttl - info->ttl;
+			if (new_ttl < 0)
+				new_ttl = 0;
+			break;
+		default:
+			new_ttl = iph->ttl;
+			break;
+	}
+
+	if (new_ttl != iph->ttl) {
+#ifndef CONFIG_IP_NF_TARGET_TTL_INC
+		if (new_ttl > iph->ttl)
+			return IPT_CONTINUE;
+#endif
+		diffs[0] = htons(((unsigned)iph->ttl) << 8) ^ 0xFFFF;
+		iph->ttl = new_ttl;
+		diffs[1] = htons(((unsigned)iph->ttl) << 8);
+		iph->check = csum_fold(csum_partial((char *)diffs,
+						    sizeof(diffs),
+						    iph->check^0xFFFF));
+	}
+
+	return IPT_CONTINUE;
+}
+
+static int ipt_ttl_checkentry(const char *tablename,
+		const struct ipt_entry *e,
+		void *targinfo,
+		unsigned int targinfosize,
+		unsigned int hook_mask)
+{
+	struct ipt_TTL_info *info = targinfo;
+
+	if (targinfosize != IPT_ALIGN(sizeof(struct ipt_TTL_info))) {
+		printk(KERN_WARNING "ipt_TTL: targinfosize %u != %Zu\n",
+				targinfosize,
+				IPT_ALIGN(sizeof(struct ipt_TTL_info)));
+		return 0;
+	}
+
+	if (strcmp(tablename, "mangle")) {
+		printk(KERN_WARNING "ipt_TTL: can only be called from "
+			"\"mangle\" table, not \"%s\"\n", tablename);
+		return 0;
+	}
+
+	if (info->mode > IPT_TTL_MAXMODE) {
+		printk(KERN_WARNING "ipt_TTL: invalid or unknown Mode %u\n", 
+			info->mode);
+		return 0;
+	}
+
+#ifndef CONFIG_IP_NF_TARGET_TTL_INC
+	if (info->mode == IPT_TTL_INC) {
+		printk(KERN_WARNING "ipt_TTL: increment of TTL not supported\n");
+		return 0;
+	} else if (info->mode == IPT_TTL_SET) {
+		printk(KERN_INFO "ipt_TTL: will only set TTL to values "
+			"lower than current value of packet\n");
+		return 0;
+	}
+#endif
+
+	if ((info->mode != IPT_TTL_SET) && (info->ttl == 0))
+		return 0;
+
+	return 1;
+}
+
+static struct ipt_target ipt_TTL = { 
+	.name 		= "TTL",
+	.target 	= ipt_ttl_target, 
+	.checkentry 	= ipt_ttl_checkentry, 
+	.me 		= THIS_MODULE,
+};
+
+static int __init init(void)
+{
+	return ipt_register_target(&ipt_TTL);
+}
+
+static void __exit fini(void)
+{
+	ipt_unregister_target(&ipt_TTL);
+}
+
+module_init(init);
+module_exit(fini);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] New ipt_TTL target
  2005-08-26 18:31 [PATCH 1/2] New ipt_TTL target Harald Welte
@ 2005-08-26 19:30 ` David S. Miller
  2005-08-27  3:31   ` Patrick McHardy
                     ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: David S. Miller @ 2005-08-26 19:30 UTC (permalink / raw)
  To: laforge; +Cc: netfilter-devel

From: Harald Welte <laforge@netfilter.org>
Date: Fri, 26 Aug 2005 20:31:51 +0200

> +config IP_NF_TARGET_TTL_INC
> +	bool  'TTL incrementing support (DANGEROUS)'
> +	depends on IP_NF_TARGET_TTL
> +	help
> +	  This option enables functionality to increment and set the TTL
> +	  value of the IP header to arbitrary values.  This is EXTREMELY
> +	  DANGEROUS since you can easily create immortal packets that loop
> +	  forever on the network.  Please only enable if you really know
> +	  that you will need it.
> +

I think it's best to kill this option.  Just put the "this is
DANGEROUS" comment into the help text for IP_NF_TARGET_TTL, ok?

Similarly for the ipv6 hoplimit target too.

Thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] New ipt_TTL target
  2005-08-26 19:30 ` David S. Miller
@ 2005-08-27  3:31   ` Patrick McHardy
  2005-08-27  3:53     ` David S. Miller
  2005-08-27 11:07   ` Harald Welte
                     ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Patrick McHardy @ 2005-08-27  3:31 UTC (permalink / raw)
  To: David S. Miller; +Cc: laforge, netfilter-devel

David S. Miller wrote:
> From: Harald Welte <laforge@netfilter.org>
> Date: Fri, 26 Aug 2005 20:31:51 +0200
> 
> 
>>+config IP_NF_TARGET_TTL_INC
>>+	bool  'TTL incrementing support (DANGEROUS)'
>>+	depends on IP_NF_TARGET_TTL
>>+	help
>>+	  This option enables functionality to increment and set the TTL
>>+	  value of the IP header to arbitrary values.  This is EXTREMELY
>>+	  DANGEROUS since you can easily create immortal packets that loop
>>+	  forever on the network.  Please only enable if you really know
>>+	  that you will need it.
>>+
> 
> 
> I think it's best to kill this option.  Just put the "this is
> DANGEROUS" comment into the help text for IP_NF_TARGET_TTL, ok?
> 
> Similarly for the ipv6 hoplimit target too.

If we want to make sure, we simply print a message in the iptables
userspace command when someone uses this option. If this is too
extreme, a comment in the man-page will probably help to reach more
people than in the kernel-help text.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] New ipt_TTL target
  2005-08-27  3:31   ` Patrick McHardy
@ 2005-08-27  3:53     ` David S. Miller
  0 siblings, 0 replies; 8+ messages in thread
From: David S. Miller @ 2005-08-27  3:53 UTC (permalink / raw)
  To: kaber; +Cc: laforge, netfilter-devel

From: Patrick McHardy <kaber@trash.net>
Date: Sat, 27 Aug 2005 05:31:00 +0200

> If we want to make sure, we simply print a message in the iptables
> userspace command when someone uses this option. If this is too
> extreme, a comment in the man-page will probably help to reach more
> people than in the kernel-help text.

Whatever you guys think works best.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] New ipt_TTL target
  2005-08-26 19:30 ` David S. Miller
  2005-08-27  3:31   ` Patrick McHardy
@ 2005-08-27 11:07   ` Harald Welte
  2005-08-27 13:21   ` Harald Welte
  2005-08-27 13:22   ` [PATCH 2/2] New ip6t_HL target Harald Welte
  3 siblings, 0 replies; 8+ messages in thread
From: Harald Welte @ 2005-08-27 11:07 UTC (permalink / raw)
  To: David S. Miller; +Cc: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On Fri, Aug 26, 2005 at 12:30:18PM -0700, David S. Miller wrote:
> From: Harald Welte <laforge@netfilter.org>
> Date: Fri, 26 Aug 2005 20:31:51 +0200
> 
> > +config IP_NF_TARGET_TTL_INC
> > +	bool  'TTL incrementing support (DANGEROUS)'
> > +	depends on IP_NF_TARGET_TTL
> > +	help
> > +	  This option enables functionality to increment and set the TTL
> > +	  value of the IP header to arbitrary values.  This is EXTREMELY
> > +	  DANGEROUS since you can easily create immortal packets that loop
> > +	  forever on the network.  Please only enable if you really know
> > +	  that you will need it.
> > +
> 
> I think it's best to kill this option.  Just put the "this is
> DANGEROUS" comment into the help text for IP_NF_TARGET_TTL, ok?

ok, I thought you would consider this as a "quality of implementation
issue" ;)

I'll re-send without the #ifdef and config option later today.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] New ipt_TTL target
  2005-08-26 19:30 ` David S. Miller
  2005-08-27  3:31   ` Patrick McHardy
  2005-08-27 11:07   ` Harald Welte
@ 2005-08-27 13:21   ` Harald Welte
  2005-08-27 13:22   ` [PATCH 2/2] New ip6t_HL target Harald Welte
  3 siblings, 0 replies; 8+ messages in thread
From: Harald Welte @ 2005-08-27 13:21 UTC (permalink / raw)
  To: David S. Miller; +Cc: netfilter-devel


[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

Hi Dave,

here's the revised version with no extra-dangerous config option.

Please apply,

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #1.2: 49-ttl_target.patch --]
[-- Type: text/plain, Size: 5861 bytes --]

[NETFILTER] Add new iptables TTL target

This new iptables target allows manipulation of the TTL of an IPv4 packet.

Signed-off-by: Harald Welte <laforge@netfilter.org>

---
commit 14d9d70998a369cb3806e570d653fc7b0a13a195
tree f240795aa48b1467b58c88432cdff6f1a5d0bb96
parent 2a4bde3e92bd6856a8b8ad479e90d7b0a41cda22
author Harald Welte <laforge@netfilter.org> Sa, 27 Aug 2005 15:17:27 +0200
committer Harald Welte <laforge@netfilter.org> Sa, 27 Aug 2005 15:17:27 +0200

 include/linux/netfilter_ipv4/ipt_TTL.h |   21 ++++++
 net/ipv4/netfilter/Kconfig             |   14 ++++
 net/ipv4/netfilter/Makefile            |    1 
 net/ipv4/netfilter/ipt_TTL.c           |  119 ++++++++++++++++++++++++++++++++
 4 files changed, 155 insertions(+), 0 deletions(-)

diff --git a/include/linux/netfilter_ipv4/ipt_TTL.h b/include/linux/netfilter_ipv4/ipt_TTL.h
new file mode 100644
--- /dev/null
+++ b/include/linux/netfilter_ipv4/ipt_TTL.h
@@ -0,0 +1,21 @@
+/* TTL modification module for IP tables
+ * (C) 2000 by Harald Welte <laforge@netfilter.org> */
+
+#ifndef _IPT_TTL_H
+#define _IPT_TTL_H
+
+enum {
+	IPT_TTL_SET = 0,
+	IPT_TTL_INC,
+	IPT_TTL_DEC
+};
+
+#define IPT_TTL_MAXMODE	IPT_TTL_DEC
+
+struct ipt_TTL_info {
+	u_int8_t	mode;
+	u_int8_t	ttl;
+};
+
+
+#endif
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -664,6 +664,20 @@ config IP_NF_TARGET_CLASSIFY
 
 	  To compile it as a module, choose M here.  If unsure, say N.
 
+config IP_NF_TARGET_TTL
+	tristate  'TTL target support'
+	depends on IP_NF_MANGLE
+	help
+	  This option adds a `TTL' target, which enables the user to modify
+	  the TTL value of the IP header.
+
+	  While it is safe to decrement/lower the TTL, this target also enables
+	  functionality to increment and set the TTL value of the IP header to
+	  arbitrary values.  This is EXTREMELY DANGEROUS since you can easily
+	  create immortal packets that loop forever on the network.
+
+	  To compile it as a module, choose M here.  If unsure, say N.
+
 config IP_NF_TARGET_CONNMARK
 	tristate  'CONNMARK target support'
 	depends on IP_NF_CONNTRACK_MARK && IP_NF_MANGLE
diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -85,6 +85,7 @@ obj-$(CONFIG_IP_NF_TARGET_ULOG) += ipt_U
 obj-$(CONFIG_IP_NF_TARGET_TCPMSS) += ipt_TCPMSS.o
 obj-$(CONFIG_IP_NF_TARGET_NOTRACK) += ipt_NOTRACK.o
 obj-$(CONFIG_IP_NF_TARGET_CLUSTERIP) += ipt_CLUSTERIP.o
+obj-$(CONFIG_IP_NF_TARGET_TTL) += ipt_TTL.o
 
 # generic ARP tables
 obj-$(CONFIG_IP_NF_ARPTABLES) += arp_tables.o
diff --git a/net/ipv4/netfilter/ipt_TTL.c b/net/ipv4/netfilter/ipt_TTL.c
new file mode 100644
--- /dev/null
+++ b/net/ipv4/netfilter/ipt_TTL.c
@@ -0,0 +1,119 @@
+/* TTL modification target for IP tables
+ * (C) 2000,2005 by Harald Welte <laforge@netfilter.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/skbuff.h>
+#include <linux/ip.h>
+#include <net/checksum.h>
+
+#include <linux/netfilter_ipv4/ip_tables.h>
+#include <linux/netfilter_ipv4/ipt_TTL.h>
+
+MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>");
+MODULE_DESCRIPTION("IP tables TTL modification module");
+MODULE_LICENSE("GPL");
+
+static unsigned int 
+ipt_ttl_target(struct sk_buff **pskb, const struct net_device *in, 
+		const struct net_device *out, unsigned int hooknum, 
+		const void *targinfo, void *userinfo)
+{
+	struct iphdr *iph;
+	const struct ipt_TTL_info *info = targinfo;
+	u_int16_t diffs[2];
+	int new_ttl;
+
+	if (!skb_make_writable(pskb, (*pskb)->len))
+		return NF_DROP;
+
+	iph = (*pskb)->nh.iph;
+
+	switch (info->mode) {
+		case IPT_TTL_SET:
+			new_ttl = info->ttl;
+			break;
+		case IPT_TTL_INC:
+			new_ttl = iph->ttl + info->ttl;
+			if (new_ttl > 255)
+				new_ttl = 255;
+			break;
+		case IPT_TTL_DEC:
+			new_ttl = iph->ttl - info->ttl;
+			if (new_ttl < 0)
+				new_ttl = 0;
+			break;
+		default:
+			new_ttl = iph->ttl;
+			break;
+	}
+
+	if (new_ttl != iph->ttl) {
+		diffs[0] = htons(((unsigned)iph->ttl) << 8) ^ 0xFFFF;
+		iph->ttl = new_ttl;
+		diffs[1] = htons(((unsigned)iph->ttl) << 8);
+		iph->check = csum_fold(csum_partial((char *)diffs,
+						    sizeof(diffs),
+						    iph->check^0xFFFF));
+	}
+
+	return IPT_CONTINUE;
+}
+
+static int ipt_ttl_checkentry(const char *tablename,
+		const struct ipt_entry *e,
+		void *targinfo,
+		unsigned int targinfosize,
+		unsigned int hook_mask)
+{
+	struct ipt_TTL_info *info = targinfo;
+
+	if (targinfosize != IPT_ALIGN(sizeof(struct ipt_TTL_info))) {
+		printk(KERN_WARNING "ipt_TTL: targinfosize %u != %Zu\n",
+				targinfosize,
+				IPT_ALIGN(sizeof(struct ipt_TTL_info)));
+		return 0;
+	}
+
+	if (strcmp(tablename, "mangle")) {
+		printk(KERN_WARNING "ipt_TTL: can only be called from "
+			"\"mangle\" table, not \"%s\"\n", tablename);
+		return 0;
+	}
+
+	if (info->mode > IPT_TTL_MAXMODE) {
+		printk(KERN_WARNING "ipt_TTL: invalid or unknown Mode %u\n", 
+			info->mode);
+		return 0;
+	}
+
+	if ((info->mode != IPT_TTL_SET) && (info->ttl == 0))
+		return 0;
+
+	return 1;
+}
+
+static struct ipt_target ipt_TTL = { 
+	.name 		= "TTL",
+	.target 	= ipt_ttl_target, 
+	.checkentry 	= ipt_ttl_checkentry, 
+	.me 		= THIS_MODULE,
+};
+
+static int __init init(void)
+{
+	return ipt_register_target(&ipt_TTL);
+}
+
+static void __exit fini(void)
+{
+	ipt_unregister_target(&ipt_TTL);
+}
+
+module_init(init);
+module_exit(fini);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/2] New ip6t_HL target
  2005-08-26 19:30 ` David S. Miller
                     ` (2 preceding siblings ...)
  2005-08-27 13:21   ` Harald Welte
@ 2005-08-27 13:22   ` Harald Welte
  2005-08-28  5:38     ` David S. Miller
  3 siblings, 1 reply; 8+ messages in thread
From: Harald Welte @ 2005-08-27 13:22 UTC (permalink / raw)
  To: David S. Miller; +Cc: netfilter-devel


[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

Hi Dave,

here's the revised version with no extra-dangerous config option.

Please apply,

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #1.2: 50-hoplimit_target.patch --]
[-- Type: text/plain, Size: 6046 bytes --]

[NETFILTER6] Add new ip6tables HOPLIMIT target

This target allows users to modify the hoplimit header field of the IPv6
header.

Signed-off-by: Harald Welte <laforge@netfilter.org>

---
commit 733e40cdff92274036b6131c50196cc3d3741555
tree f18cd65100f97e9632d10837f531ef86c7f6aee9
parent 14d9d70998a369cb3806e570d653fc7b0a13a195
author Harald Welte <laforge@netfilter.org> Sa, 27 Aug 2005 15:19:59 +0200
committer Harald Welte <laforge@netfilter.org> Sa, 27 Aug 2005 15:19:59 +0200

 include/linux/netfilter_ipv6/ip6t_HL.h |   22 ++++++
 net/ipv6/netfilter/Kconfig             |   16 ++++
 net/ipv6/netfilter/Makefile            |    1 
 net/ipv6/netfilter/ip6t_HL.c           |  118 ++++++++++++++++++++++++++++++++
 4 files changed, 157 insertions(+), 0 deletions(-)

diff --git a/include/linux/netfilter_ipv6/ip6t_HL.h b/include/linux/netfilter_ipv6/ip6t_HL.h
new file mode 100644
--- /dev/null
+++ b/include/linux/netfilter_ipv6/ip6t_HL.h
@@ -0,0 +1,22 @@
+/* Hop Limit modification module for ip6tables
+ * Maciej Soltysiak <solt@dns.toxicfilms.tv>
+ * Based on HW's TTL module */
+
+#ifndef _IP6T_HL_H
+#define _IP6T_HL_H
+
+enum {
+	IP6T_HL_SET = 0,
+	IP6T_HL_INC,
+	IP6T_HL_DEC
+};
+
+#define IP6T_HL_MAXMODE	IP6T_HL_DEC
+
+struct ip6t_HL_info {
+	u_int8_t	mode;
+	u_int8_t	hop_limit;
+};
+
+
+#endif
diff --git a/net/ipv6/netfilter/Kconfig b/net/ipv6/netfilter/Kconfig
--- a/net/ipv6/netfilter/Kconfig
+++ b/net/ipv6/netfilter/Kconfig
@@ -239,6 +239,22 @@ config IP6_NF_TARGET_MARK
 
 	  To compile it as a module, choose M here.  If unsure, say N.
 
+config IP6_NF_TARGET_HL
+	tristate  'HL (hoplimit) target support'
+	depends on IP6_NF_MANGLE
+	help
+	  This option adds a `HL' target, which enables the user to decrement
+	  the hoplimit value of the IPv6 header or set it to a given (lower)
+	  value.
+	
+	  While it is safe to decrement the hoplimit value, this option also
+	  enables functionality to increment and set the hoplimit value of the
+	  IPv6 header to arbitrary values.  This is EXTREMELY DANGEROUS since
+	  you can easily create immortal packets that loop forever on the
+	  network.  
+
+	  To compile it as a module, choose M here.  If unsure, say N.
+
 #dep_tristate '  LOG target support' CONFIG_IP6_NF_TARGET_LOG $CONFIG_IP6_NF_IPTABLES
 config IP6_NF_RAW
 	tristate  'raw table support (required for TRACE)'
diff --git a/net/ipv6/netfilter/Makefile b/net/ipv6/netfilter/Makefile
--- a/net/ipv6/netfilter/Makefile
+++ b/net/ipv6/netfilter/Makefile
@@ -20,6 +20,7 @@ obj-$(CONFIG_IP6_NF_MATCH_PHYSDEV) += ip
 obj-$(CONFIG_IP6_NF_FILTER) += ip6table_filter.o
 obj-$(CONFIG_IP6_NF_MANGLE) += ip6table_mangle.o
 obj-$(CONFIG_IP6_NF_TARGET_MARK) += ip6t_MARK.o
+obj-$(CONFIG_IP6_NF_TARGET_HL) += ip6t_HL.o
 obj-$(CONFIG_IP6_NF_QUEUE) += ip6_queue.o
 obj-$(CONFIG_IP6_NF_TARGET_LOG) += ip6t_LOG.o
 obj-$(CONFIG_IP6_NF_RAW) += ip6table_raw.o
diff --git a/net/ipv6/netfilter/ip6t_HL.c b/net/ipv6/netfilter/ip6t_HL.c
new file mode 100644
--- /dev/null
+++ b/net/ipv6/netfilter/ip6t_HL.c
@@ -0,0 +1,118 @@
+/* 
+ * Hop Limit modification target for ip6tables
+ * Maciej Soltysiak <solt@dns.toxicfilms.tv>
+ * Based on HW's TTL module
+ *
+ * This software is distributed under the terms of GNU GPL
+ */
+
+#include <linux/module.h>
+#include <linux/skbuff.h>
+#include <linux/ip.h>
+
+#include <linux/netfilter_ipv6/ip6_tables.h>
+#include <linux/netfilter_ipv6/ip6t_HL.h>
+
+MODULE_AUTHOR("Maciej Soltysiak <solt@dns.toxicfilms.tv>");
+MODULE_DESCRIPTION("IP tables Hop Limit modification module");
+MODULE_LICENSE("GPL");
+
+static unsigned int ip6t_hl_target(struct sk_buff **pskb, 
+				   const struct net_device *in,
+				   const struct net_device *out,
+				   unsigned int hooknum,
+				   const void *targinfo, void *userinfo)
+{
+	struct ipv6hdr *ip6h;
+	const struct ip6t_HL_info *info = targinfo;
+	u_int16_t diffs[2];
+	int new_hl;
+
+	if (!skb_make_writable(pskb, (*pskb)->len))
+		return NF_DROP;
+
+	ip6h = (*pskb)->nh.ipv6h;
+
+	switch (info->mode) {
+		case IP6T_HL_SET:
+			new_hl = info->hop_limit;
+			break;
+		case IP6T_HL_INC:
+			new_hl = ip6h->hop_limit + info->hop_limit;
+			if (new_hl > 255)
+				new_hl = 255;
+			break;
+		case IP6T_HL_DEC:
+			new_hl = ip6h->hop_limit - info->hop_limit;
+			if (new_hl < 0)
+				new_hl = 0;
+			break;
+		default:
+			new_hl = ip6h->hop_limit;
+			break;
+	}
+
+	if (new_hl != ip6h->hop_limit) {
+		diffs[0] = htons(((unsigned)ip6h->hop_limit) << 8) ^ 0xFFFF;
+		ip6h->hop_limit = new_hl;
+		diffs[1] = htons(((unsigned)ip6h->hop_limit) << 8);
+	}
+
+	return IP6T_CONTINUE;
+}
+
+static int ip6t_hl_checkentry(const char *tablename,
+		const struct ip6t_entry *e,
+		void *targinfo,
+		unsigned int targinfosize,
+		unsigned int hook_mask)
+{
+	struct ip6t_HL_info *info = targinfo;
+
+	if (targinfosize != IP6T_ALIGN(sizeof(struct ip6t_HL_info))) {
+		printk(KERN_WARNING "ip6t_HL: targinfosize %u != %Zu\n",
+				targinfosize,
+				IP6T_ALIGN(sizeof(struct ip6t_HL_info)));
+		return 0;	
+	}	
+
+	if (strcmp(tablename, "mangle")) {
+		printk(KERN_WARNING "ip6t_HL: can only be called from "
+			"\"mangle\" table, not \"%s\"\n", tablename);
+		return 0;
+	}
+
+	if (info->mode > IP6T_HL_MAXMODE) {
+		printk(KERN_WARNING "ip6t_HL: invalid or unknown Mode %u\n", 
+			info->mode);
+		return 0;
+	}
+
+	if ((info->mode != IP6T_HL_SET) && (info->hop_limit == 0)) {
+		printk(KERN_WARNING "ip6t_HL: increment/decrement doesn't "
+			"make sense with value 0\n");
+		return 0;
+	}
+	
+	return 1;
+}
+
+static struct ip6t_target ip6t_HL = { 
+	.name 		= "HL", 
+	.target		= ip6t_hl_target, 
+	.checkentry	= ip6t_hl_checkentry, 
+	.me		= THIS_MODULE
+};
+
+static int __init init(void)
+{
+	return ip6t_register_target(&ip6t_HL);
+}
+
+static void __exit fini(void)
+{
+	ip6t_unregister_target(&ip6t_HL);
+}
+
+module_init(init);
+module_exit(fini);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] New ip6t_HL target
  2005-08-27 13:22   ` [PATCH 2/2] New ip6t_HL target Harald Welte
@ 2005-08-28  5:38     ` David S. Miller
  0 siblings, 0 replies; 8+ messages in thread
From: David S. Miller @ 2005-08-28  5:38 UTC (permalink / raw)
  To: laforge; +Cc: netfilter-devel


Both ipv4 and ipv6 patches applied, thanks for following up
on this Harald.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2005-08-28  5:38 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-26 18:31 [PATCH 1/2] New ipt_TTL target Harald Welte
2005-08-26 19:30 ` David S. Miller
2005-08-27  3:31   ` Patrick McHardy
2005-08-27  3:53     ` David S. Miller
2005-08-27 11:07   ` Harald Welte
2005-08-27 13:21   ` Harald Welte
2005-08-27 13:22   ` [PATCH 2/2] New ip6t_HL target Harald Welte
2005-08-28  5:38     ` David S. Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.