Re: [PATCH NF_CONNTRACK] compatible ipt_conntrack

[Patrick McHardy <kaber@trash.net>]

Harald Welte wrote:
> However, I think we make our lives much more easy when we make
> ip_conntrack / nf_conntrack a compile-time decision.  This way we avoid
> compromising any run-time efficiency at the cost of some configurations
> where the user doesn't know at compile time which of the two systems he
> should use.
> 
> I also dislike the "CONNTRACK_IPV4_DEFAULT" config option that you use
> in your patches.  I think it was introduced because we cannot have two
> modules that supply the same symbol.  
> 
> I think we either make the ip_conntrack/nf_conntrack decision at
> compile-time (like stated above), _or_ we find a run-time solution that
> will work transparently with both ip_conntrack and nf_conntrack.
> Whatever we use for the actual implementation (macros, glue functions,
> ...) is a different question.

I feel reluctant to add complexity just so users can switch between
them at runtime. It may be useful for debugging, but it doesn't look
like a realistic usage scenario. So I would also prefer having a
compile-time choice.