All of lore.kernel.org
 help / color / mirror / Atom feed
From: Knut Petersen <Knut_Petersen@t-online.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Andrew Morton <akpm@osdl.org>,
	"Antonino A. Daplas" <adaplas@gmail.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Jochen Hein <jochen@jochen.org>
Subject: Re: [PATCH 1/1 2.6.13] framebuffer: bit_putcs() optimization for 8x* fonts
Date: Wed, 31 Aug 2005 00:26:54 +0200	[thread overview]
Message-ID: <4314DD2E.7060901@t-online.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0508302039160.3743@scrub.home>

Hi Roman,

>Could you try the patch below, for a few extra cycles you might want to 
>make it an inline function.
>  
>
No, it does not help. If there is any difference, it is too small to be 
measured on
my system ... and my system does run at 1000 Hz.

After 2.6.12 fb_pad_aligned_buffer() was changed to use memcpy() instead 
of a
bytewise copy. That slowed things down a lot, some weeks ago that was 
reverted.
fb_pad_aligned _buffer() isn´t that slow, it´s just an external function 
to be called
and that means a lot of unnecessary code.

How could I make it an inline function? It is used in console/bitblit.c, 
nvidia/nvidia.c,
riva/fbdev.c and softcursor.c.

cu,
 Knut


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

WARNING: multiple messages have this Message-ID (diff)
From: Knut Petersen <Knut_Petersen@t-online.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Andrew Morton <akpm@osdl.org>,
	"Antonino A. Daplas" <adaplas@gmail.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Jochen Hein <jochen@jochen.org>
Subject: Re: [Linux-fbdev-devel] [PATCH 1/1 2.6.13] framebuffer: bit_putcs() optimization for 8x* fonts
Date: Wed, 31 Aug 2005 00:26:54 +0200	[thread overview]
Message-ID: <4314DD2E.7060901@t-online.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0508302039160.3743@scrub.home>

Hi Roman,

>Could you try the patch below, for a few extra cycles you might want to 
>make it an inline function.
>  
>
No, it does not help. If there is any difference, it is too small to be 
measured on
my system ... and my system does run at 1000 Hz.

After 2.6.12 fb_pad_aligned_buffer() was changed to use memcpy() instead 
of a
bytewise copy. That slowed things down a lot, some weeks ago that was 
reverted.
fb_pad_aligned _buffer() isn´t that slow, it´s just an external function 
to be called
and that means a lot of unnecessary code.

How could I make it an inline function? It is used in console/bitblit.c, 
nvidia/nvidia.c,
riva/fbdev.c and softcursor.c.

cu,
 Knut

  reply	other threads:[~2005-08-30 22:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 16:15 [PATCH 1/1 2.6.13] framebuffer: bit_putcs() optimization for 8x* fonts Knut Petersen
2005-08-30 16:18 ` Geert Uytterhoeven
2005-08-30 16:18   ` [Linux-fbdev-devel] " Geert Uytterhoeven
2005-08-30 17:58   ` Knut Petersen
2005-08-30 17:58     ` [Linux-fbdev-devel] " Knut Petersen
2005-08-30 19:13     ` Roman Zippel
2005-08-30 19:13       ` [Linux-fbdev-devel] " Roman Zippel
2005-08-30 22:26       ` Knut Petersen [this message]
2005-08-30 22:26         ` Knut Petersen
2005-08-31  0:51         ` Roman Zippel
2005-08-31  6:42           ` Antonino A. Daplas
2005-08-31 15:49             ` Roman Zippel
2005-08-31 15:49               ` [Linux-fbdev-devel] " Roman Zippel
2005-08-31 12:46           ` Knut Petersen
2005-08-31 12:46             ` [Linux-fbdev-devel] " Knut Petersen
2005-08-31 17:15             ` Roman Zippel
2005-08-31 19:19               ` Knut Petersen
2005-08-31 19:19                 ` Knut Petersen
2005-08-31 19:34                 ` Roman Zippel
2005-08-31 19:52                   ` Knut Petersen
2005-08-30 19:59     ` Geert Uytterhoeven
2005-08-30 19:59       ` Geert Uytterhoeven
2005-08-31  1:14     ` Antonino A. Daplas
2005-08-31  1:14 ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4314DD2E.7060901@t-online.de \
    --to=knut_petersen@t-online.de \
    --cc=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jochen@jochen.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.