* 2.6.13-rc7-git2 crashes on iBook
@ 2005-08-28 11:20 ` Andreas Schwab
0 siblings, 0 replies; 14+ messages in thread
From: Andreas Schwab @ 2005-08-28 11:20 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Linus Torvalds, linux-kernel
The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
probably a dormant bug that was just uncovered by the change.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 14+ messages in thread
* 2.6.13-rc7-git2 crashes on iBook
@ 2005-08-28 11:20 ` Andreas Schwab
0 siblings, 0 replies; 14+ messages in thread
From: Andreas Schwab @ 2005-08-28 11:20 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-kernel, Linus Torvalds
The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
probably a dormant bug that was just uncovered by the change.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: 2.6.13-rc7-git2 crashes on iBook
2005-08-28 11:20 ` Andreas Schwab
(?)
@ 2005-08-28 18:17 ` Jean Delvare
-1 siblings, 0 replies; 14+ messages in thread
From: Jean Delvare @ 2005-08-28 18:17 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev, linux-kernel, Linus Torvalds
Hi Andreas, all,
> The last change to drivers/pci/setup-res.c (Ignore disabled ROM
> resources at setup) is breaking radeonfb on iBook G3 (with Radeon
> Mobility M6 LY). It crashes in pci_map_rom when called from
> radeonfb_map_ROM. This is probably a dormant bug that was just
> uncovered by the change.
FWIW, it didn't seem to break my Sony Vaio PCG-GR214EP (x86 with Radeon
Mobility M6 LY as well.) So it must be machine-specific, not
chip-specific.
--
Jean Delvare
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: 2.6.13-rc7-git2 crashes on iBook
2005-08-28 11:20 ` Andreas Schwab
(?)
(?)
@ 2005-08-29 4:02 ` Alex Williamson
2005-08-29 10:39 ` Stelian Pop
-1 siblings, 1 reply; 14+ messages in thread
From: Alex Williamson @ 2005-08-29 4:02 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev, linux-kernel, Linus Torvalds
On Sun, 2005-08-28 at 13:20 +0200, Andreas Schwab wrote:
> The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> probably a dormant bug that was just uncovered by the change.
Same thing on Mac Mini. 2.6.13 doesn't boot. Revert the
drivers/pci/setup-res.c change from rc7-git2 and it seems ok.
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: 2.6.13-rc7-git2 crashes on iBook
2005-08-29 4:02 ` Alex Williamson
@ 2005-08-29 10:39 ` Stelian Pop
0 siblings, 0 replies; 14+ messages in thread
From: Stelian Pop @ 2005-08-29 10:39 UTC (permalink / raw)
To: Alex Williamson; +Cc: Linus Torvalds, linux-kernel, linuxppc-dev
Le dimanche 28 août 2005 à 22:02 -0600, Alex Williamson a écrit :
> On Sun, 2005-08-28 at 13:20 +0200, Andreas Schwab wrote:
> > The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> > at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> > It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> > probably a dormant bug that was just uncovered by the change.
>
> Same thing on Mac Mini. 2.6.13 doesn't boot. Revert the
> drivers/pci/setup-res.c change from rc7-git2 and it seems ok.
Confirmed on an Apple Powerbook too.
For reference, the (already reverted) patch which needs to be applied is
below.
Signed-off-by: Stelian Pop <stelian@popies.net>
Index: linux-2.6.git/drivers/pci/setup-res.c
===================================================================
--- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
+++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
@@ -53,9 +53,7 @@
if (resno < 6) {
reg = PCI_BASE_ADDRESS_0 + 4 * resno;
} else if (resno == PCI_ROM_RESOURCE) {
- if (!(res->flags & IORESOURCE_ROM_ENABLE))
- return;
- new |= PCI_ROM_ADDRESS_ENABLE;
+ new |= res->flags & IORESOURCE_ROM_ENABLE;
reg = dev->rom_base_reg;
} else {
/* Hmm, non-standard resource. */
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13-rc7-git2 crashes on iBook
@ 2005-08-29 10:39 ` Stelian Pop
0 siblings, 0 replies; 14+ messages in thread
From: Stelian Pop @ 2005-08-29 10:39 UTC (permalink / raw)
To: Alex Williamson
Cc: Andreas Schwab, linuxppc-dev, linux-kernel, Linus Torvalds
Le dimanche 28 août 2005 à 22:02 -0600, Alex Williamson a écrit :
> On Sun, 2005-08-28 at 13:20 +0200, Andreas Schwab wrote:
> > The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> > at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> > It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> > probably a dormant bug that was just uncovered by the change.
>
> Same thing on Mac Mini. 2.6.13 doesn't boot. Revert the
> drivers/pci/setup-res.c change from rc7-git2 and it seems ok.
Confirmed on an Apple Powerbook too.
For reference, the (already reverted) patch which needs to be applied is
below.
Signed-off-by: Stelian Pop <stelian@popies.net>
Index: linux-2.6.git/drivers/pci/setup-res.c
===================================================================
--- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
+++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
@@ -53,9 +53,7 @@
if (resno < 6) {
reg = PCI_BASE_ADDRESS_0 + 4 * resno;
} else if (resno == PCI_ROM_RESOURCE) {
- if (!(res->flags & IORESOURCE_ROM_ENABLE))
- return;
- new |= PCI_ROM_ADDRESS_ENABLE;
+ new |= res->flags & IORESOURCE_ROM_ENABLE;
reg = dev->rom_base_reg;
} else {
/* Hmm, non-standard resource. */
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13-rc7-git2 crashes on iBook
2005-08-29 10:39 ` Stelian Pop
@ 2005-09-01 19:26 ` Daniel Drake
-1 siblings, 0 replies; 14+ messages in thread
From: Daniel Drake @ 2005-09-01 19:26 UTC (permalink / raw)
To: Stelian Pop; +Cc: Linus Torvalds, linux-kernel, Alex Williamson, linuxppc-dev
Hi,
Stelian Pop wrote:
> Confirmed on an Apple Powerbook too.
>
> For reference, the (already reverted) patch which needs to be applied is
> below.
>
> Signed-off-by: Stelian Pop <stelian@popies.net>
>
> Index: linux-2.6.git/drivers/pci/setup-res.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
> +++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
> @@ -53,9 +53,7 @@
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - if (!(res->flags & IORESOURCE_ROM_ENABLE))
> - return;
> - new |= PCI_ROM_ADDRESS_ENABLE;
> + new |= res->flags & IORESOURCE_ROM_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
>
Sorry for my ignorance. Which tree was this reverted in? You are probably
aware that this bug made it into 2.6.13 (patch was not reverted there).
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13-rc7-git2 crashes on iBook
@ 2005-09-01 19:26 ` Daniel Drake
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Drake @ 2005-09-01 19:26 UTC (permalink / raw)
To: Stelian Pop
Cc: Alex Williamson, Andreas Schwab, linuxppc-dev, linux-kernel,
Linus Torvalds
Hi,
Stelian Pop wrote:
> Confirmed on an Apple Powerbook too.
>
> For reference, the (already reverted) patch which needs to be applied is
> below.
>
> Signed-off-by: Stelian Pop <stelian@popies.net>
>
> Index: linux-2.6.git/drivers/pci/setup-res.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
> +++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
> @@ -53,9 +53,7 @@
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - if (!(res->flags & IORESOURCE_ROM_ENABLE))
> - return;
> - new |= PCI_ROM_ADDRESS_ENABLE;
> + new |= res->flags & IORESOURCE_ROM_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
>
Sorry for my ignorance. Which tree was this reverted in? You are probably
aware that this bug made it into 2.6.13 (patch was not reverted there).
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13-rc7-git2 crashes on iBook
2005-09-01 19:26 ` Daniel Drake
@ 2005-09-01 19:54 ` Stelian Pop
-1 siblings, 0 replies; 14+ messages in thread
From: Stelian Pop @ 2005-09-01 19:54 UTC (permalink / raw)
To: Daniel Drake; +Cc: Linus Torvalds, linux-kernel, Alex Williamson, linuxppc-dev
Le jeudi 01 septembre 2005 à 20:26 +0100, Daniel Drake a écrit :
> Hi,
>
> Stelian Pop wrote:
> > Confirmed on an Apple Powerbook too.
> >
> > For reference, the (already reverted) patch which needs to be applied is
> > below.
> >
> > Signed-off-by: Stelian Pop <stelian@popies.net>
> >
> > Index: linux-2.6.git/drivers/pci/setup-res.c
[...]
> Sorry for my ignorance. Which tree was this reverted in? You are probably
> aware that this bug made it into 2.6.13 (patch was not reverted there).
It must be my bad english but I wasn't implying that the patch was
reverted in 2.6.13 but that one should apply it (just apply, without -R,
because I didn't attach the original patch but a reversed version of it)
on a clean 2.6.13 tree in order to make it work. :)
However, a different fix (a real fix, not the workaround proposed above)
was discussed on lkml this week and BenH proposed a patch I haven't had
the chance to test yet (see http://lkml.org/lkml/2005/8/31/1 ).
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: 2.6.13-rc7-git2 crashes on iBook
@ 2005-09-01 19:54 ` Stelian Pop
0 siblings, 0 replies; 14+ messages in thread
From: Stelian Pop @ 2005-09-01 19:54 UTC (permalink / raw)
To: Daniel Drake
Cc: Alex Williamson, Andreas Schwab, linuxppc-dev, linux-kernel,
Linus Torvalds
Le jeudi 01 septembre 2005 à 20:26 +0100, Daniel Drake a écrit :
> Hi,
>
> Stelian Pop wrote:
> > Confirmed on an Apple Powerbook too.
> >
> > For reference, the (already reverted) patch which needs to be applied is
> > below.
> >
> > Signed-off-by: Stelian Pop <stelian@popies.net>
> >
> > Index: linux-2.6.git/drivers/pci/setup-res.c
[...]
> Sorry for my ignorance. Which tree was this reverted in? You are probably
> aware that this bug made it into 2.6.13 (patch was not reverted there).
It must be my bad english but I wasn't implying that the patch was
reverted in 2.6.13 but that one should apply it (just apply, without -R,
because I didn't attach the original patch but a reversed version of it)
on a clean 2.6.13 tree in order to make it work. :)
However, a different fix (a real fix, not the workaround proposed above)
was discussed on lkml this week and BenH proposed a patch I haven't had
the chance to test yet (see http://lkml.org/lkml/2005/8/31/1 ).
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook)
2005-08-28 11:20 ` Andreas Schwab
@ 2005-08-29 10:56 ` Sean Neakums
-1 siblings, 0 replies; 14+ messages in thread
From: Sean Neakums @ 2005-08-29 10:56 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev, linux-kernel, Linus Torvalds
Andreas Schwab <schwab@suse.de> writes:
> The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> probably a dormant bug that was just uncovered by the change.
2.6.13 hangs on boot on my PowerBook 5.4, reverting the disabled ROM
patch (appended for confirmation) fixes it. 2.6.13-rc7 was fine.
diff-tree 755528c860b05fcecda1c88a2bdaffcb50760a7f (from 26aad69e3dd854abe9028ca873fb40b410a39dd7)
Author: Linus Torvalds <torvalds@g5.osdl.org>
Date: Fri Aug 26 10:49:22 2005 -0700
Ignore disabled ROM resources at setup
Writing even a disabled value seems to mess up some matrox graphics
cards. It may be a card-related issue, but we may also be writing
reserved low bits in the result.
This was a fall-out of switching x86 over to the generic PCI resource
allocation code, and needs more debugging. In particular, the old x86
code defaulted to not doing any resource allocations at all for ROM
resources.
In the meantime, this has been reported to make X happier by Helge
Hafting <helgehaf@aitel.hist.no>.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -53,7 +53,9 @@ pci_update_resource(struct pci_dev *dev,
if (resno < 6) {
reg = PCI_BASE_ADDRESS_0 + 4 * resno;
} else if (resno == PCI_ROM_RESOURCE) {
- new |= res->flags & IORESOURCE_ROM_ENABLE;
+ if (!(res->flags & IORESOURCE_ROM_ENABLE))
+ return;
+ new |= PCI_ROM_ADDRESS_ENABLE;
reg = dev->rom_base_reg;
} else {
/* Hmm, non-standard resource. */
^ permalink raw reply [flat|nested] 14+ messages in thread* 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook)
@ 2005-08-29 10:56 ` Sean Neakums
0 siblings, 0 replies; 14+ messages in thread
From: Sean Neakums @ 2005-08-29 10:56 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev, Linus Torvalds, linux-kernel
Andreas Schwab <schwab@suse.de> writes:
> The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> probably a dormant bug that was just uncovered by the change.
2.6.13 hangs on boot on my PowerBook 5.4, reverting the disabled ROM
patch (appended for confirmation) fixes it. 2.6.13-rc7 was fine.
diff-tree 755528c860b05fcecda1c88a2bdaffcb50760a7f (from 26aad69e3dd854abe9028ca873fb40b410a39dd7)
Author: Linus Torvalds <torvalds@g5.osdl.org>
Date: Fri Aug 26 10:49:22 2005 -0700
Ignore disabled ROM resources at setup
Writing even a disabled value seems to mess up some matrox graphics
cards. It may be a card-related issue, but we may also be writing
reserved low bits in the result.
This was a fall-out of switching x86 over to the generic PCI resource
allocation code, and needs more debugging. In particular, the old x86
code defaulted to not doing any resource allocations at all for ROM
resources.
In the meantime, this has been reported to make X happier by Helge
Hafting <helgehaf@aitel.hist.no>.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -53,7 +53,9 @@ pci_update_resource(struct pci_dev *dev,
if (resno < 6) {
reg = PCI_BASE_ADDRESS_0 + 4 * resno;
} else if (resno == PCI_ROM_RESOURCE) {
- new |= res->flags & IORESOURCE_ROM_ENABLE;
+ if (!(res->flags & IORESOURCE_ROM_ENABLE))
+ return;
+ new |= PCI_ROM_ADDRESS_ENABLE;
reg = dev->rom_base_reg;
} else {
/* Hmm, non-standard resource. */
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook)
2005-08-29 10:56 ` Sean Neakums
@ 2005-08-29 18:17 ` Mikael Pettersson
-1 siblings, 0 replies; 14+ messages in thread
From: Mikael Pettersson @ 2005-08-29 18:17 UTC (permalink / raw)
To: Sean Neakums; +Cc: Linus Torvalds, linux-kernel, linuxppc-dev
Sean Neakums writes:
> Andreas Schwab <schwab@suse.de> writes:
>
> > The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> > at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> > It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> > probably a dormant bug that was just uncovered by the change.
>
> 2.6.13 hangs on boot on my PowerBook 5.4, reverting the disabled ROM
> patch (appended for confirmation) fixes it. 2.6.13-rc7 was fine.
Same here, on an Apple eMac with Radeon graphics. 2.6.13-rc7 worked fine,
2.6.13 vanilla hangs early in the boot when radeonfb is about to take over
from OF. Reverting the patch below eliminates the hang.
/Mikael
> diff-tree 755528c860b05fcecda1c88a2bdaffcb50760a7f (from 26aad69e3dd854abe9028ca873fb40b410a39dd7)
> Author: Linus Torvalds <torvalds@g5.osdl.org>
> Date: Fri Aug 26 10:49:22 2005 -0700
>
> Ignore disabled ROM resources at setup
>
> Writing even a disabled value seems to mess up some matrox graphics
> cards. It may be a card-related issue, but we may also be writing
> reserved low bits in the result.
>
> This was a fall-out of switching x86 over to the generic PCI resource
> allocation code, and needs more debugging. In particular, the old x86
> code defaulted to not doing any resource allocations at all for ROM
> resources.
>
> In the meantime, this has been reported to make X happier by Helge
> Hafting <helgehaf@aitel.hist.no>.
>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> --- a/drivers/pci/setup-res.c
> +++ b/drivers/pci/setup-res.c
> @@ -53,7 +53,9 @@ pci_update_resource(struct pci_dev *dev,
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - new |= res->flags & IORESOURCE_ROM_ENABLE;
> + if (!(res->flags & IORESOURCE_ROM_ENABLE))
> + return;
> + new |= PCI_ROM_ADDRESS_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook)
@ 2005-08-29 18:17 ` Mikael Pettersson
0 siblings, 0 replies; 14+ messages in thread
From: Mikael Pettersson @ 2005-08-29 18:17 UTC (permalink / raw)
To: Sean Neakums; +Cc: Andreas Schwab, linuxppc-dev, Linus Torvalds, linux-kernel
Sean Neakums writes:
> Andreas Schwab <schwab@suse.de> writes:
>
> > The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
> > at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
> > It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
> > probably a dormant bug that was just uncovered by the change.
>
> 2.6.13 hangs on boot on my PowerBook 5.4, reverting the disabled ROM
> patch (appended for confirmation) fixes it. 2.6.13-rc7 was fine.
Same here, on an Apple eMac with Radeon graphics. 2.6.13-rc7 worked fine,
2.6.13 vanilla hangs early in the boot when radeonfb is about to take over
from OF. Reverting the patch below eliminates the hang.
/Mikael
> diff-tree 755528c860b05fcecda1c88a2bdaffcb50760a7f (from 26aad69e3dd854abe9028ca873fb40b410a39dd7)
> Author: Linus Torvalds <torvalds@g5.osdl.org>
> Date: Fri Aug 26 10:49:22 2005 -0700
>
> Ignore disabled ROM resources at setup
>
> Writing even a disabled value seems to mess up some matrox graphics
> cards. It may be a card-related issue, but we may also be writing
> reserved low bits in the result.
>
> This was a fall-out of switching x86 over to the generic PCI resource
> allocation code, and needs more debugging. In particular, the old x86
> code defaulted to not doing any resource allocations at all for ROM
> resources.
>
> In the meantime, this has been reported to make X happier by Helge
> Hafting <helgehaf@aitel.hist.no>.
>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> --- a/drivers/pci/setup-res.c
> +++ b/drivers/pci/setup-res.c
> @@ -53,7 +53,9 @@ pci_update_resource(struct pci_dev *dev,
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - new |= res->flags & IORESOURCE_ROM_ENABLE;
> + if (!(res->flags & IORESOURCE_ROM_ENABLE))
> + return;
> + new |= PCI_ROM_ADDRESS_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2005-09-01 22:12 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-28 11:20 2.6.13-rc7-git2 crashes on iBook Andreas Schwab
2005-08-28 11:20 ` Andreas Schwab
2005-08-28 18:17 ` Jean Delvare
2005-08-29 4:02 ` Alex Williamson
2005-08-29 10:39 ` Stelian Pop
2005-08-29 10:39 ` Stelian Pop
2005-09-01 19:26 ` Daniel Drake
2005-09-01 19:26 ` Daniel Drake
2005-09-01 19:54 ` Stelian Pop
2005-09-01 19:54 ` Stelian Pop
2005-08-29 10:56 ` 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook) Sean Neakums
2005-08-29 10:56 ` Sean Neakums
2005-08-29 18:17 ` Mikael Pettersson
2005-08-29 18:17 ` Mikael Pettersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.