From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Brett Russ <russb@emc.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)
Date: Thu, 01 Sep 2005 15:48:51 -0400 [thread overview]
Message-ID: <43175B23.8040803@pobox.com> (raw)
In-Reply-To: <20050901144038.GA25830@infradead.org>
Christoph Hellwig wrote:
>>+#include <linux/kernel.h>
>>+#include <linux/module.h>
>>+#include <linux/pci.h>
>>+#include <linux/init.h>
>>+#include <linux/blkdev.h>
>>+#include <linux/delay.h>
>>+#include <linux/interrupt.h>
>>+#include <linux/sched.h>
>>+#include <linux/dma-mapping.h>
>>+#include "scsi.h"
>
>
> pleaese don't include "scsi.h" in new drivers. It will go away soon.
> Use the <scsi/*.h> headers and get rid of usage of obsolete constucts
> in your driver.
It stays until the rest of the libata drivers lose the include.
After ATAPI support is done, I can stop 2.4.x support, and this and
several other compat-isms will go away.
Jeff
next prev parent reply other threads:[~2005-09-01 19:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 18:36 [RFC][PATCH 2.6.13] Marvell SATA support (PIO mode) Brett Russ
2005-08-30 20:48 ` Jeff Garzik
2005-09-01 14:27 ` [PATCH 2.6.13] libata: " Brett Russ
2005-09-01 14:40 ` Christoph Hellwig
2005-09-01 19:48 ` Jeff Garzik [this message]
2005-09-01 19:58 ` Christoph Hellwig
2005-09-01 20:03 ` Jeff Garzik
2005-09-01 20:04 ` Jeff Garzik
2005-09-01 20:05 ` Christoph Hellwig
2005-09-01 20:28 ` Jeff Garzik
2005-09-01 22:26 ` Brett Russ
2005-09-02 1:32 ` Brett Russ
2005-09-02 17:16 ` Bogdan Costescu
2005-09-02 17:16 ` Bogdan Costescu
2005-09-02 17:55 ` Ray Lee
2005-09-07 5:56 ` Jeff Garzik
2005-09-07 14:40 ` Brett Russ
2005-09-07 16:31 ` Bogdan Costescu
2005-09-07 16:31 ` Bogdan Costescu
2005-09-03 14:08 ` Tyler
2005-09-03 17:29 ` Jeff Garzik
2005-09-27 5:36 ` Tyler
2005-09-27 5:36 ` Tyler
2005-08-31 10:35 ` [RFC][PATCH 2.6.13] " Jiri Slaby
2005-08-31 11:37 ` Brett Russ
-- strict thread matches above, loose matches on Subject: below --
2005-09-01 20:19 [PATCH 2.6.13] libata: " linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43175B23.8040803@pobox.com \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=russb@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.