From: Jeff Garzik <jgarzik@pobox.com>
To: akpm@osdl.org
Cc: pavel@ucw.cz, ipw2100-admin@linux.intel.com, pavel@suse.cz,
Linux Kernel <linux-kernel@vger.kernel.org>,
Netdev List <netdev@vger.kernel.org>
Subject: Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging
Date: Tue, 06 Sep 2005 21:51:21 -0400 [thread overview]
Message-ID: <431E4799.7000502@pobox.com> (raw)
In-Reply-To: <200509062056.j86KuHcL031448@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Pavel Machek <pavel@ucw.cz>
>
> This removes debug prints from entry/exit of functions. Such level of
> debugging should probably be done by gdb or similar.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> Cc: Jeff Garzik <jgarzik@pobox.com>
> Cc: "James P. Ketrenos" <ipw2100-admin@linux.intel.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
NAK. Rationale: maintainer's choice. Pavel doesn't get to choose the
debugger of choice for the driver maintainer.
I do this entry/exit stuff in my net and SATA drivers; printk is my
primary method of debugging.
Jeff
next parent reply other threads:[~2005-09-07 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509062056.j86KuHcL031448@shell0.pdx.osdl.net>
2005-09-07 1:51 ` Jeff Garzik [this message]
2005-09-07 2:41 ` [patch 1/1] ipw2100: remove by-hand function entry/exit debugging David S. Miller
2005-09-07 2:48 ` Jeff Garzik
2005-09-07 13:39 ` Ingo Oeser
2005-09-07 20:01 ` David S. Miller
2005-09-08 0:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431E4799.7000502@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=ipw2100-admin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.