From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: akpm@osdl.org, pavel@ucw.cz, ipw2100-admin@linux.intel.com,
pavel@suse.cz, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging
Date: Tue, 06 Sep 2005 22:48:52 -0400 [thread overview]
Message-ID: <431E5514.2070003@pobox.com> (raw)
In-Reply-To: <20050906.194111.130652562.davem@davemloft.net>
David S. Miller wrote:
> From: Jeff Garzik <jgarzik@pobox.com>
> Date: Tue, 06 Sep 2005 21:51:21 -0400
>
>
>>NAK. Rationale: maintainer's choice. Pavel doesn't get to choose
>>the debugger of choice for the driver maintainer.
>
>
> If it makes the driver unreadable and thus harder to maintain,
> I think such changes should seriously be considered.
>
> Most of the DEBUG_INFO macro usage is fine, but those "enter"
> and "exit" ones are just pure noise and should be removed.
I find them useful in my own drivers; they are definitely not pure noise.
Jeff
next prev parent reply other threads:[~2005-09-07 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509062056.j86KuHcL031448@shell0.pdx.osdl.net>
2005-09-07 1:51 ` [patch 1/1] ipw2100: remove by-hand function entry/exit debugging Jeff Garzik
2005-09-07 2:41 ` David S. Miller
2005-09-07 2:48 ` Jeff Garzik [this message]
2005-09-07 13:39 ` Ingo Oeser
2005-09-07 20:01 ` David S. Miller
2005-09-08 0:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431E5514.2070003@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=ipw2100-admin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.