From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: netfilter-devel@lists.netfilter.org, sbellabes@mandriva.com
Subject: Re: [NETFILTER 2/8]: Add NetBIOS name service helper
Date: Wed, 07 Sep 2005 05:01:20 +0200 [thread overview]
Message-ID: <431E5800.9080406@trash.net> (raw)
In-Reply-To: <20050906.195649.54560179.davem@davemloft.net>
David S. Miller wrote:
> From: Samir Bellabes <sbellabes@mandriva.com>
> Subject: Re: [NETFILTER 2/8]: Add NetBIOS name service helper
> Date: Wed, 07 Sep 2005 04:50:16 +0200
>
>
>>[NETFILTER] Return NF_DROP if expectation failed for Netbios conntrack
>>
>>Fix the returned value when it's not possible to allocate expectation
>>or if ip_conntrack_expect_related() failed.
>>
>>Signed-off-by: Samir Bellabes <sbellabes@mandriva.com>
>
>
> Patrick, I've applied this, I hope you don't mind :)
Actually it was deliberate, I don't see a reason why the packet
should be dropped, its best effort. Besides that the patch
creates a reference leak, we always need to call
ip_conntrack_expect_put. Please revert the patch. Thanks.
next prev parent reply other threads:[~2005-09-07 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 17:55 [NETFILTER 2/8]: Add NetBIOS name service helper Patrick McHardy
2005-09-06 18:10 ` Patrick McHardy
2005-09-07 2:50 ` Samir Bellabes
2005-09-07 2:56 ` David S. Miller
2005-09-07 3:01 ` Patrick McHardy [this message]
2005-09-07 3:02 ` David S. Miller
2005-09-07 9:57 ` Samir Bellabes
2005-09-07 10:13 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431E5800.9080406@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=sbellabes@mandriva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.