All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: problems with snd_au8830 module under mandriva 2005
@ 2005-09-02  3:51 Raymond
  2005-09-04 19:34 ` Alien
  0 siblings, 1 reply; 12+ messages in thread
From: Raymond @ 2005-09-02  3:51 UTC (permalink / raw)
  To: Erik; +Cc: Alien, Igor Kovalenko, openvortex-dev, alsa-devel, Manuel Jander

I am not sure Alien's au8810 patch is as same as Igor Kovalenko 's
au8820 patch. They seem to have their own patches.

The EQ part in diff11.diff seem to be not tested since EQ is not present
in au8820.

You should cc your reply to openvortex-dev@nongnu.org and
alsa-devel@lists.sourceforge.net so that the others can keep track of
your problem.

There are 3 bug reports for AMD64 in ALSA BTS.
1047 - au8810
1138 - au8820
1025 - au8830

Need feedback from testers with au8810/au8820/au8830 and 32bits/64bits
machines to debug this patch.

1) EQ, SPDIF of au8810/au8830 are not present in au8820,
2) WT of au8820/au8830 are not present in au8810,
3) SoftModem of au8810 are not present in au8820.
4) 3D of au8830 is not present in au8810/au8820.

Please correct me if I am wrong, I think au8810 do not have any 3D
effect hardware.

The essential part of the AMD64 patch is

void __iomem *mmio
#define    hwread(x,y) readl((x)+(y))
#define    hwwrite(x,y,z) writel((z),(x)+(y))

read/write 32bits data from/to memory-mapped I/O with 32bits address on
32bits machines and 64bits address on 64bits machines.

There are other 32bits and 64bits incompatibilites in different part of
the driver.

1) DMA, SRC, Hardware Mixer, Equalizer, Capturing
2) MPU401, Gameport, SPDIF
3) 3D, XTALK, WT

Please clearly describe your volume bar problem.

The error is the parameters in functions declared in au88x0_xtalk.c not
matched with those in au88x0_xtalk.h.

It's diffcult to say the change of XTALK part in diff1.diff is right or
wrong.

Any hint on how to debug the XTALK canceller ?

How about implement a kcontrol to change xt_mode by alsamixer ?

WARNING : Select narrow mode seem to produce a VERY HIGH pitch.

static int
snd_vortex_xtalk_info(snd_kcontrol_t * kcontrol, snd_ctl_elem_info_t *
uinfo)
{	
	static char *texts[] = {"Default", "Headphone", "Wide", "Narrow",
"Diamond"};
	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
	uinfo->count = 1;
	uinfo->value.enumerated.items = 5;
	if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
		uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
	strcpy(uinfo->value.enumerated.name, texts[uinfo->value.enumerated.item]);
	return 0;
}

static int
snd_vortex_xtalk_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *
ucontrol)
{
	vortex_t *vortex = snd_kcontrol_chip(kcontrol);
	ucontrol->value.enumerated.item[0]=vortex->xt_mode;
	return 0;
}

static int
snd_vortex_xtalk_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *
ucontrol)
{
	int changed;
	vortex_t *vortex = snd_kcontrol_chip(kcontrol);
	if ( vortex->xt_mode == ucontrol->value.enumerated.item[0] )
		changed=0;
	else
		changed=1;
	Vort3DRend_Initialize(vortex, ucontrol->value.enumerated.item[0] );
	return changed;
}

static snd_kcontrol_new_t snd_vortex_xtalk_kcontrol __devinitdata = {
	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
	.name = "XTALK Playback",
	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE,
	.info = snd_vortex_xtalk_info,
	.get = snd_vortex_xtalk_get,
	.put = snd_vortex_xtalk_put,

};


Please post the output

lspci -vvn

cat /proc/asound/au8830/codec97#0/ac97#0-0+regs

using the patch manager at openvortex

http://savannah.nongnu.org/patch/download.php?item_id=3948



> this is what i get when compiling the kernel
> but maybe i have to delete the kernel source tree
> because i can remember that i had allready patched the alsa part before
> a long time ago
> it was in june i posted the error and not long after that alien from
> nongnu list contacted me and told me about a patch/.diff
> i have a working alsa driver with that diff but the only problem still
> is that the volume bar is acting strange so i think i have allready done
> this patch
> but i was glad i could compile it under 64 bit kernel
>
> do you know if this is the same patch if not i will clean all sources
> and compile the kernel again.
>
> Erik
>
>
>
> CC [M]  sound/pci/au88x0/au8830.o
> In file included from sound/pci/au88x0/au8830.c:17:
> sound/pci/au88x0/au88x0_xtalk.c:645: error: conflicting types for
> 'vortex_XtalkHw_SetSampleRate'
> sound/pci/au88x0/au88x0_xtalk.h:51: error: previous declaration of
> 'vortex_XtalkHw_SetSampleRate' was here
> sound/pci/au88x0/au88x0_xtalk.c:645: error: conflicting types for
> 'vortex_XtalkHw_SetSampleRate'
> sound/pci/au88x0/au88x0_xtalk.h:51: error: previous declaration of
> 'vortex_XtalkHw_SetSampleRate' was here
> sound/pci/au88x0/au88x0_xtalk.h:51: warning:
> 'vortex_XtalkHw_SetSampleRate' declared `static' but never defined
> sound/pci/au88x0/au88x0_xtalk.c:645: warning:
> 'vortex_XtalkHw_SetSampleRate' defined but not used
> make[3]: *** [sound/pci/au88x0/au8830.o] Error 1
> make[2]: *** [sound/pci/au88x0] Error 2
> make[1]: *** [sound/pci] Error 2
> make: *** [sound] Error 2
>
>




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: problems with snd_au8830 module under mandriva 2005
@ 2005-09-02  3:39 Raymond
  0 siblings, 0 replies; 12+ messages in thread
From: Raymond @ 2005-09-02  3:39 UTC (permalink / raw)
  To: Erik; +Cc: Alien, Igor Kovalenko, openvortex-dev, alsa-devel, Manuel Jander


There are 3 bug reports for AMD64 in ALSA BTS.
1047 - au8810
1138 - au8820
1025 - au8830

au8810/au8820/au8830 driver is tightly coupled in ALSA au88x0

1) EQ, SPDIF of au8810/au8830 are not present in au8820,
2) WT of au8820/au8830 are not present in au8810,
3) SoftModem of au8810 are not present in au8820/au8830.

Please correct me if I am wrong, I think au8810 do not have any 3D 
effect hardware.

The essential part of the patch is

void __iomem *mmio
#define    hwread(x,y) readl((x)+(y))
#define    hwwrite(x,y,z) writel((z),(x)+(y))

There are 32bits and 64bits data type difference need to be fixed.

1) DMA, SRC, Mixer, Equalizer, Capturing
2) MPU401, Gameport, SPDIF
3) 3D, XTALK

Please clearly describe your volume bar problem.

The volume issue may be relate to the equalizer, hardware mixer, xtalk 
or codec initialization.

The EQ part in diff11.diff is not tested since EQ is not present in au8820.

Please post the output

lspci -vvn

cat /proc/asound/au8830/codec97#0/ac97#0-0+regs

I am not sure Alien's au8810 patch is as same as Igor Kovalenko 's 
au8820 patch. They seem to have their own patches.


The error is properly forget to change the functions declared in 
au88x0_xtalk.h

If the code in au88x0_xtalk.c is arranged in correct order, it is 
possible to delete all those function declaration in au88x0_xtalk.h

It's diffcult to say the XTALK part in diff1.diff is right or wrong.

Any hint on how to test the xtalk canceller ?

I think any patch to the stable ALSA driver in alsa-kernel is to fix 
bugs instead of introducing more confusion.

Any side effect if keeping the XTALK part unchanged ?

or

Implement a kcontrol to test the XTALK



It's great to have an user with au8830 and AMD64 to test all features in 
au8830, this allow nearly all implemented features in au88x0 to be tested.

http://savannah.nongnu.org/patch/download.php?item_id=3948


You should cc your reply to openvortex-dev@nongnu.org so that the other 
developers know the problem.


 > this is what i get when compiling the kernel
 > but maybe i have to delete the kernel source tree
 > because i can remember that i had allready patched the alsa part before
 > a long time ago
 > it was in june i posted the error and not long after that alien from
 > nongnu list contacted me and told me about a patch/.diff
 > i have a working alsa driver with that diff but the only problem still
 > is that the volume bar is acting strange so i think i have allready done
 > this patch
 > but i was glad i could compile it under 64 bit kernel
 >
 > do you know if this is the same patch if not i will clean all sources
 > and compile the kernel again.
 >
 > Erik
 >
 >
 >
 > CC [M]  sound/pci/au88x0/au8830.o
 > In file included from sound/pci/au88x0/au8830.c:17:
 > sound/pci/au88x0/au88x0_xtalk.c:645: error: conflicting types for
 > 'vortex_XtalkHw_SetSampleRate'
 > sound/pci/au88x0/au88x0_xtalk.h:51: error: previous declaration of
 > 'vortex_XtalkHw_SetSampleRate' was here
 > sound/pci/au88x0/au88x0_xtalk.c:645: error: conflicting types for
 > 'vortex_XtalkHw_SetSampleRate'
 > sound/pci/au88x0/au88x0_xtalk.h:51: error: previous declaration of
 > 'vortex_XtalkHw_SetSampleRate' was here
 > sound/pci/au88x0/au88x0_xtalk.h:51: warning:
 > 'vortex_XtalkHw_SetSampleRate' declared `static' but never defined
 > sound/pci/au88x0/au88x0_xtalk.c:645: warning:
 > 'vortex_XtalkHw_SetSampleRate' defined but not used
 > make[3]: *** [sound/pci/au88x0/au8830.o] Error 1
 > make[2]: *** [sound/pci/au88x0] Error 2
 > make[1]: *** [sound/pci] Error 2
 > make: *** [sound] Error 2
 >
 >


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

^ permalink raw reply	[flat|nested] 12+ messages in thread
[parent not found: <1118256592.28940.0.camel@localhost>]
end of thread, other threads:[~2005-10-12  0:30 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-02  3:51 problems with snd_au8830 module under mandriva 2005 Raymond
2005-09-04 19:34 ` Alien
2005-09-07 22:15   ` Erik
2005-09-08  7:07     ` Alien
2005-09-10  0:40       ` Raymond
2005-09-10  7:03         ` Alien
2005-09-14  3:32       ` Erik
2005-09-14  4:42         ` Raymond
2005-09-16 14:16         ` Raymond
2005-10-12  0:30           ` Erik
  -- strict thread matches above, loose matches on Subject: below --
2005-09-02  3:39 Raymond
     [not found] <1118256592.28940.0.camel@localhost>
2005-08-28  3:32 ` Raymond

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.