From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: Jiri Slaby <jirislaby@gmail.com>, Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-ide@vger.kernel.org,
B.Zolnierkiewicz@elka.pw.edu.pl
Subject: Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)
Date: Sat, 10 Sep 2005 17:39:52 -0400 [thread overview]
Message-ID: <432352A8.3010605@pobox.com> (raw)
In-Reply-To: <20050910211932.GA13679@kroah.com>
Greg KH wrote:
> On Sat, Sep 10, 2005 at 04:55:10PM -0400, Jeff Garzik wrote:
>
>>Jiri Slaby wrote:
>>
>>>diff --git a/include/asm-i386/ide.h b/include/asm-i386/ide.h
>>>--- a/include/asm-i386/ide.h
>>>+++ b/include/asm-i386/ide.h
>>>@@ -41,7 +41,12 @@ static __inline__ int ide_default_irq(un
>>>
>>>static __inline__ unsigned long ide_default_io_base(int index)
>>>{
>>>- if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
>>>+ struct pci_dev *pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
>>>+ unsigned int a = !pdev;
>>>+
>>>+ pci_dev_put(pdev);
>>
>>
>>Looks like we need to resurrect pci_present() from the ancient past.
>
>
> Heh, ick, no :)
>
> Jiri, any other way to do this instead?
Look at what the IDE code is trying to do. All it cares about is
whether -any PCI device at all- is present, a boolean value.
Jeff
next prev parent reply other threads:[~2005-09-10 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 20:32 [PATCH] include: pci_find_device remove (include/asm-i386/ide.h) Jiri Slaby
2005-09-10 20:55 ` Jeff Garzik
2005-09-10 21:19 ` Greg KH
2005-09-10 21:24 ` Jiri Slaby
2005-09-10 21:39 ` Jeff Garzik [this message]
2005-09-10 22:33 ` Matthew Wilcox
2005-09-10 23:35 ` Jeff Garzik
2005-09-11 0:34 ` Grant Grundler
2005-09-11 0:47 ` Jeff Garzik
2005-09-11 1:06 ` Alan Cox
2005-09-11 1:24 ` Grant Grundler
2005-09-11 1:30 ` Matthew Wilcox
2005-09-12 10:17 ` Alan Cox
2005-09-12 11:21 ` Matthew Wilcox
2005-09-12 12:35 ` Alan Cox
2005-09-11 0:06 ` Alan Cox
2005-10-06 22:24 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432352A8.3010605@pobox.com \
--to=jgarzik@pobox.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.