From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Greg KH <greg@kroah.com>, Jiri Slaby <jirislaby@gmail.com>,
Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-ide@vger.kernel.org,
B.Zolnierkiewicz@elka.pw.edu.pl
Subject: Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)
Date: Sat, 10 Sep 2005 19:35:10 -0400 [thread overview]
Message-ID: <43236DAE.8000802@pobox.com> (raw)
In-Reply-To: <20050910223333.GF4770@parisc-linux.org>
Matthew Wilcox wrote:
> On Sat, Sep 10, 2005 at 05:39:52PM -0400, Jeff Garzik wrote:
>
>>Look at what the IDE code is trying to do. All it cares about is
>>whether -any PCI device at all- is present, a boolean value.
>
>
> Why not change it to query whether any IDE device is present, perhaps
> using pci_get_class()?
Because that's not what the code is attempting to discover.
Jeff
next prev parent reply other threads:[~2005-09-10 23:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 20:32 [PATCH] include: pci_find_device remove (include/asm-i386/ide.h) Jiri Slaby
2005-09-10 20:55 ` Jeff Garzik
2005-09-10 21:19 ` Greg KH
2005-09-10 21:24 ` Jiri Slaby
2005-09-10 21:39 ` Jeff Garzik
2005-09-10 22:33 ` Matthew Wilcox
2005-09-10 23:35 ` Jeff Garzik [this message]
2005-09-11 0:34 ` Grant Grundler
2005-09-11 0:47 ` Jeff Garzik
2005-09-11 1:06 ` Alan Cox
2005-09-11 1:24 ` Grant Grundler
2005-09-11 1:30 ` Matthew Wilcox
2005-09-12 10:17 ` Alan Cox
2005-09-12 11:21 ` Matthew Wilcox
2005-09-12 12:35 ` Alan Cox
2005-09-11 0:06 ` Alan Cox
2005-10-06 22:24 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43236DAE.8000802@pobox.com \
--to=jgarzik@pobox.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.