All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Linux kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: -git10 undefined reference to `i2c_bit_add_bus'
Date: Sun, 11 Sep 2005 08:54:34 +0800	[thread overview]
Message-ID: <4323804A.3090509@gmail.com> (raw)
In-Reply-To: <432313E3.9030208@ppp0.net>

Jan Dittmer wrote:
> I didn't look into details, but attached config does not
> compile anymore after selecting the new (compared to
> 2.6.13-rc6-git5) option CONFIG_FB_I810_I2C.
> 
> 
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `i810_setup_i2c_bus':
> i810-i2c.c:(.text+0x657d2): undefined reference to `i2c_bit_add_bus'
> drivers/built-in.o: In function `i810_delete_i2c_busses':
> : undefined reference to `i2c_bit_del_bus'
> drivers/built-in.o: In function `i810_delete_i2c_busses':
> : undefined reference to `i2c_bit_del_bus'
> drivers/built-in.o: In function `i810_do_probe_i2c_edid':
> i810-i2c.c:(.text+0x6599b): undefined reference to `i2c_transfer'
> make: *** [.tmp_vmlinux1] Error 1
> 

Try the attached patch.  Run your make *config again, then recompile.

Fix compile error if CONFIG_FB_I810_I2C is 'y' and CONFIG_I2C = 'm'.

Signed-off-by: Antonino Daplas <adaplas@pol.net>

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -708,7 +708,8 @@ config FB_I810_GTF
 
 config FB_I810_I2C
 	bool "Enable DDC Support"
-	depends on FB_I810 && I2C && FB_I810_GTF
+	depends on FB_I810 && FB_I810_GTF
+	select I2C
 	select I2C_ALGOBIT
 	help
 


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

WARNING: multiple messages have this Message-ID (diff)
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Linux kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: -git10 undefined reference to `i2c_bit_add_bus'
Date: Sun, 11 Sep 2005 08:54:34 +0800	[thread overview]
Message-ID: <4323804A.3090509@gmail.com> (raw)
In-Reply-To: <432313E3.9030208@ppp0.net>

Jan Dittmer wrote:
> I didn't look into details, but attached config does not
> compile anymore after selecting the new (compared to
> 2.6.13-rc6-git5) option CONFIG_FB_I810_I2C.
> 
> 
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `i810_setup_i2c_bus':
> i810-i2c.c:(.text+0x657d2): undefined reference to `i2c_bit_add_bus'
> drivers/built-in.o: In function `i810_delete_i2c_busses':
> : undefined reference to `i2c_bit_del_bus'
> drivers/built-in.o: In function `i810_delete_i2c_busses':
> : undefined reference to `i2c_bit_del_bus'
> drivers/built-in.o: In function `i810_do_probe_i2c_edid':
> i810-i2c.c:(.text+0x6599b): undefined reference to `i2c_transfer'
> make: *** [.tmp_vmlinux1] Error 1
> 

Try the attached patch.  Run your make *config again, then recompile.

Fix compile error if CONFIG_FB_I810_I2C is 'y' and CONFIG_I2C = 'm'.

Signed-off-by: Antonino Daplas <adaplas@pol.net>

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -708,7 +708,8 @@ config FB_I810_GTF
 
 config FB_I810_I2C
 	bool "Enable DDC Support"
-	depends on FB_I810 && I2C && FB_I810_GTF
+	depends on FB_I810 && FB_I810_GTF
+	select I2C
 	select I2C_ALGOBIT
 	help
 

  reply	other threads:[~2005-09-11  0:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-10 17:12 -git10 undefined reference to `i2c_bit_add_bus' Jan Dittmer
2005-09-11  0:54 ` Antonino A. Daplas [this message]
2005-09-11  0:54   ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4323804A.3090509@gmail.com \
    --to=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jdittmer@ppp0.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.