[PATCH - Resend] PNPACPI: only parse device that have CRS method

[PATCH - Resend] PNPACPI: only parse device that have CRS method

[matthieu castet]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Hi,

this patch blacklist device that don't have CRS method as there are
useless for pnp layer as they don't provide any resource.

Please comment and consider for inclusion.

Thanks,

Matthieu


[-- Attachment #2: pnpacpi_nocrs.patch --]
[-- Type: text/x-patch, Size: 581 bytes --]

Index: linux-2.6.13rc/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-2.6.13rc.orig/drivers/pnp/pnpacpi/core.c	2005-08-28 19:24:40.000000000 +0200
+++ linux-2.6.13rc/drivers/pnp/pnpacpi/core.c	2005-08-28 19:26:35.000000000 +0200
@@ -131,7 +131,8 @@
 	struct pnp_id *dev_id;
 	struct pnp_dev *dev;
 
-	if (!ispnpidacpi(acpi_device_hid(device)) ||
+	status = acpi_get_handle(device->handle, "_CRS", &temp);
+	if (ACPI_FAILURE(status) || !ispnpidacpi(acpi_device_hid(device)) ||
 		is_exclusive_device(device))
 		return 0;
 

[PATCH - Resend] PNPACPI: only parse device that have CRS method

[matthieu castet]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Hi,

this patch blacklist device that don't have CRS method as there are
useless for pnp layer as they don't provide any resource.

Please comment and consider for inclusion.

Thanks,

Matthieu


[-- Attachment #2: pnpacpi_nocrs.patch --]
[-- Type: text/x-patch, Size: 581 bytes --]

Index: linux-2.6.13rc/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-2.6.13rc.orig/drivers/pnp/pnpacpi/core.c	2005-08-28 19:24:40.000000000 +0200
+++ linux-2.6.13rc/drivers/pnp/pnpacpi/core.c	2005-08-28 19:26:35.000000000 +0200
@@ -131,7 +131,8 @@
 	struct pnp_id *dev_id;
 	struct pnp_dev *dev;
 
-	if (!ispnpidacpi(acpi_device_hid(device)) ||
+	status = acpi_get_handle(device->handle, "_CRS", &temp);
+	if (ACPI_FAILURE(status) || !ispnpidacpi(acpi_device_hid(device)) ||
 		is_exclusive_device(device))
 		return 0;
 

Re: [PATCH - Resend] PNPACPI: only parse device that have CRS method

[Meelis Roos]

mc> this patch blacklist device that don't have CRS method as there are
mc> useless for pnp layer as they don't provide any resource.

I tried it on my laptop (Toshiba Satellite 1800-314). It removed one
device from PNP bus, 00:0c, id = TOS6200, no options (as shown by 2.6.13).

I hoped it will notice something different about my SMCf010. It's
onboard IRDA that is disabled by BIOS. But the device is still there
with your patch and still does not work.

The background: it's disabled by BIOS. PNPBIOS could activate it
(haven't tried since PNPACPI came). PNPACPI could not activate it -
activate worked, resources showed resources but smsc-ircc2 got still no
configuration (chip itself was not reprogrammed?). The speculation was
that it's because of missing CRS in ACPI tables but this device did not
disappear with your current patch.

Any ideas about getting it to work with PNPACPI - or should I just
declare my ACPI BIOS broken and revert to PNPBIOS on this laptop? Do you
want seome more ACPI debug info than last time?

-- 
Meelis Roos

Re: [PATCH - Resend] PNPACPI: only parse device that have CRS method

[matthieu castet]

Hi Meelis

Meelis Roos wrote:
> mc> this patch blacklist device that don't have CRS method as there are
> mc> useless for pnp layer as they don't provide any resource.
> 
> I tried it on my laptop (Toshiba Satellite 1800-314). It removed one
> device from PNP bus, 00:0c, id = TOS6200, no options (as shown by 2.6.13).
> 
> I hoped it will notice something different about my SMCf010. It's
> onboard IRDA that is disabled by BIOS. But the device is still there
> with your patch and still does not work.
> 
> The background: it's disabled by BIOS. PNPBIOS could activate it
> (haven't tried since PNPACPI came). PNPACPI could not activate it -
> activate worked, resources showed resources but smsc-ircc2 got still no
> configuration (chip itself was not reprogrammed?). The speculation was
> that it's because of missing CRS in ACPI tables but this device did not
> disappear with your current patch.
> 
> Any ideas about getting it to work with PNPACPI - or should I just

You could try
http://marc.theaimsgroup.com/?l=linux-kernel&m=111827568001255&w=2 if 
you haven't yet tried it ?

 > declare my ACPI BIOS broken and revert to PNPBIOS on this laptop? Do you
 > want seome more ACPI debug info than last time?
 >
You could always use pnpacpi=no (or something like that) to disable 
pnpacpi and use pnpbios (IIRC this one worked).

cheers,

Matthieu

Re: [PATCH - Resend] PNPACPI: only parse device that have CRS method

[Meelis Roos]

> You could try
> http://marc.theaimsgroup.com/?l=linux-kernel&m=111827568001255&w=2 if you 
> haven't yet tried it ?

No, tried it now. Had to hand-apply 2 chunks because of kmalloc changes 
but it was trivial and probably correct. It seems to find nothing bad:
pnp: building resource template
pnp: encoding resources
pnp: irq flags are correct
pnp: setting resources
pnp: _SRS worked correctly
pnp: Device 00:0a activated.

-- 
Meelis Roos (mroos@linux.ee)

Re: [PATCH - Resend] PNPACPI: only parse device that have CRS method

[Bjorn Helgaas]

On Sunday 11 September 2005 4:12 am, matthieu castet wrote:
> this patch blacklist device that don't have CRS method as there are
> useless for pnp layer as they don't provide any resource.
> 
> Please comment and consider for inclusion.

Looks reasonable to me.