From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH 1/2] i386: consolidate discontig functions into normal ones
Date: Mon, 12 Sep 2005 22:04:48 +0300 [thread overview]
Message-ID: <4325D150.6040505@kolumbus.fi> (raw)
In-Reply-To: <20050912175319.7C51CF96@kernel.beaverton.ibm.com>
Dave Hansen wrote:
>There are quite a few functions in i386's discontig.c which are
>actually NUMA-specific, not discontigmem. They are also very
>similar to the generic, flat functions found in setup.c.
>
>This patch takes the versions in setup.c and makes them work
>for both NUMA and non-NUMA cases. In the process, quite a
>few nasty #ifdef and externs can be removed.
>
>One of the main mechanisms to do this is that highstart_pfn
>and highend_pfn are now gone, replaced by node_start/end_pfn[].
>However, this has no real impact on storage space, because
>those arrays are declared with a length of MAX_NUMNODES, which
>is 1 when NUMA is off.
>
>
>
>
I think you allocate remap pages for nothing in the flatmem case for
node0...those aren't used for the mem map in !NUMA.
--Mika
WARNING: multiple messages have this Message-ID (diff)
From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH 1/2] i386: consolidate discontig functions into normal ones
Date: Mon, 12 Sep 2005 22:04:48 +0300 [thread overview]
Message-ID: <4325D150.6040505@kolumbus.fi> (raw)
In-Reply-To: <20050912175319.7C51CF96@kernel.beaverton.ibm.com>
Dave Hansen wrote:
>There are quite a few functions in i386's discontig.c which are
>actually NUMA-specific, not discontigmem. They are also very
>similar to the generic, flat functions found in setup.c.
>
>This patch takes the versions in setup.c and makes them work
>for both NUMA and non-NUMA cases. In the process, quite a
>few nasty #ifdef and externs can be removed.
>
>One of the main mechanisms to do this is that highstart_pfn
>and highend_pfn are now gone, replaced by node_start/end_pfn[].
>However, this has no real impact on storage space, because
>those arrays are declared with a length of MAX_NUMNODES, which
>is 1 when NUMA is off.
>
>
>
>
I think you allocate remap pages for nothing in the flatmem case for
node0...those aren't used for the mem map in !NUMA.
--Mika
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-12 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-12 17:53 [RFC][PATCH 1/2] i386: consolidate discontig functions into normal ones Dave Hansen
2005-09-12 17:53 ` Dave Hansen
2005-09-12 17:53 ` [RFC][PATCH 2/2] i386: move NUMA code into numa.c Dave Hansen
2005-09-12 17:53 ` Dave Hansen
2005-09-12 19:04 ` Mika Penttilä [this message]
2005-09-12 19:04 ` [RFC][PATCH 1/2] i386: consolidate discontig functions into normal ones Mika Penttilä
2005-09-12 19:08 ` Dave Hansen
2005-09-12 19:08 ` Dave Hansen
2005-09-12 19:22 ` Mika Penttilä
2005-09-12 19:22 ` Mika Penttilä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4325D150.6040505@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.