All of lore.kernel.org
 help / color / mirror / Atom feed
* [NETFILTER 8/8]: pptp helper: missing expectation flags initialisation
@ 2005-09-15 22:44 Patrick McHardy
  2005-09-17 10:56 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2005-09-15 22:44 UTC (permalink / raw)
  To: Harald Welte; +Cc: Netfilter Development Mailinglist, David S. Miller

[-- Attachment #1: 08.diff --]
[-- Type: text/x-patch, Size: 1035 bytes --]

[NETFILTER]: pptp helper: missing expectation flags initialisation

Support for permanent expectations added a flags field to the expectation
that needs to be initialized to 0.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 0ddb4c0a3fcf3cded1b34ec48b66e8874d13f105
tree 0d855d26740383efac8514fdd890786b86921cd6
parent ac7e4424f98eef582b9923011d27c208252a0096
author Patrick McHardy <kaber@trash.net> Fri, 16 Sep 2005 00:21:34 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 16 Sep 2005 00:21:34 +0200

 net/ipv4/netfilter/ip_conntrack_helper_pptp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
--- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
@@ -250,6 +250,7 @@ exp_gre(struct ip_conntrack *master,
 		
 	exp_orig->master = master;
 	exp_orig->expectfn = pptp_expectfn;
+	exp_orig->flags = 0;
 
 	exp_orig->dir = IP_CT_DIR_ORIGINAL;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [NETFILTER 8/8]: pptp helper: missing expectation flags initialisation
  2005-09-15 22:44 [NETFILTER 8/8]: pptp helper: missing expectation flags initialisation Patrick McHardy
@ 2005-09-17 10:56 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2005-09-17 10:56 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: Netfilter Development Mailinglist

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

On Fri, Sep 16, 2005 at 12:44:59AM +0200, Patrick McHardy wrote:

> [NETFILTER]: pptp helper: missing expectation flags initialisation

thanks, all your patches applied to netfilte-2.6.14 git tree.  I'll do
some testing this afternoon, and then hopefully submit to Davem

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-17 10:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-15 22:44 [NETFILTER 8/8]: pptp helper: missing expectation flags initialisation Patrick McHardy
2005-09-17 10:56 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.