Re: [PATCH 4/5] convert st to use scsi_execte_async

[Mike Christie <michaelc@cs.wisc.edu>]

Kai Makisara wrote:
> 
> This solves the problem. All works properly and if I try some mt command 
> after filemark detection, the residual is correctly zero.

ok thanks for having patience with me and testing so much.

> 
> This change solving problems also explains what I have seen today. Before 
> your message I had found out that all three commands (the one that should 
> have been executed and the two retries) were fetched from the queue in the 
> normal way. Eh did not have anything to do with them. The command was 
> using dio and 10240 bytes needs three pages => two retries.
> 

ahh :)

> Fixing passing the retries did not actually have anything to do with this 
> exact problem. However, I think that the retries parameter should be 
> obeyed if it is in the interface.
> 

Yes, I think we need both fixes for the users of scsi_execte and 
scsi_execute_req that was added to scsi-rc-fixes. I will make a patch 
and send if off.

Thanks again for testing.