All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Kai Makisara <Kai.Makisara@kolumbus.fi>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] convert st to use scsi_execte_async
Date: Thu, 22 Sep 2005 22:20:12 -0500	[thread overview]
Message-ID: <4333746C.2030704@cs.wisc.edu> (raw)
In-Reply-To: <Pine.LNX.4.61.0509222309390.6022@kai.makisara.local>

Kai Makisara wrote:
> On Tue, 20 Sep 2005, Kai Makisara wrote:
> 
> ...
> 
>>If I try 5121 kB, write fails as is expected but not completely nicely. 
>>Here are some test printks:
>>
>>scsi_req_map_sg: q->back_merge failed, i=10
>>st 1:0:5:0: extraneous data discarded.
>>st 1:0:5:0: COMMAND FAILED (87 0 1).
>>sym: cmd: 0x0a 0x00 0x50 0x04 0x00 0x00
>>st: cmd=0x0a result=0x70000 resid=0 sense[0]=0x00 sense[2]=0x00
>>
>>scsi_req_map_sg fails as it should but still a bogus SCSI command is sent. 
>>I think the reason for this is simple but I don't want to delay the good 
>>news by trying to debug this.
>>
> 
> The reason was simple: scsi_req_map_sg did not set err when q->back_merge 
> failed. The patch at the end fixes the problem (I am not sure what would 
> be the correct error code).

yeah :) thanks.

  reply	other threads:[~2005-09-23  3:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-16  4:39 [PATCH 4/5] convert st to use scsi_execte_async Mike Christie
2005-09-17 11:57 ` Kai Makisara
2005-09-17 15:43   ` Mike Christie
2005-09-17 15:55     ` Mike Christie
2005-09-17 16:25       ` Mike Christie
2005-09-18 12:01         ` Kai Makisara
2005-09-18 15:03           ` Mike Christie
2005-09-18 15:17             ` Mike Christie
2005-09-18 17:40               ` Kai Makisara
2005-09-18 15:46                 ` Mike Christie
2005-09-18 16:13                   ` Mike Christie
2005-09-18 16:08                 ` Mike Christie
2005-09-18 16:36                 ` Mike Christie
2005-09-18 16:38                   ` Mike Christie
2005-09-18 19:03                     ` Kai Makisara
2005-09-18 17:01                       ` Mike Christie
2005-09-19 18:39                         ` Kai Makisara
2005-09-19 19:22                           ` Mike Christie
2005-09-20 19:23                             ` Kai Makisara
2005-09-20 19:55                               ` Mike Christie
2005-09-20 20:20                               ` James Bottomley
2005-09-20 21:17                                 ` Kai Makisara
2005-09-20 22:39                                   ` Douglas Gilbert
2005-09-22 20:12                               ` Kai Makisara
2005-09-23  3:20                                 ` Mike Christie [this message]
2005-09-17 15:57   ` Kai Makisara
2005-09-17 16:48     ` Kai Makisara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4333746C.2030704@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.