From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] sa1100fb updates
Date: Mon, 27 Nov 2017 17:30:11 +0000 [thread overview]
Message-ID: <4330027.F5ASplytpk@amdc3058> (raw)
In-Reply-To: <20171127171145.GI31757@n2100.armlinux.org.uk>
On Monday, November 27, 2017 05:11:45 PM Russell King - ARM Linux wrote:
> On Tue, Oct 17, 2017 at 03:32:30PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Friday, September 29, 2017 11:50:04 AM Russell King - ARM Linux wrote:
> > > Hi Bart,
> >
> > Hi Russell,
> >
> > > This series updates the sa1100fb fbdev driver's initialisation paths
> > > to be more robust. In doing these updates, I realised that we omitted
> > > to free some memory which was allocated for the framebuffer if
> > > initialisation fails - something that was hidden due to the complex
> > > cleanup that the driver performs. Switching to managed resources made
> > > this more obvious.
> > >
> > > Tested on H3600 iPAQ and Assabet.
> > >
> > > drivers/video/fbdev/sa1100fb.c | 75 +++++++++++++++---------------------------
> > > drivers/video/fbdev/sa1100fb.h | 2 ++
> > > 2 files changed, 29 insertions(+), 48 deletions(-)
> >
> > I queued all patches for 4.15, thanks!
>
> Now that 4.15-rc1 is out, something tells me that was not actually
> the case. Any ideas what happened?
Could you please explain the issue that you are seeing a bit more?
For me it looks all fine:
$ git log --oneline v4.15-rc1 drivers/video/fbdev/sa1100fb.c
cb6bc3f video: sa1100fb: move pseudo palette into sa1100fb_info structure
0ab7658 video: sa1100fb: fix video memory allocation leak
c244f8e video: sa1100fb: clean up failure path
5634cba video: sa1100fb: use devm_gpio_request_one()
f6fc8c9 video: sa1100fb: use devm_request_irq()
df6b228 video: sa1100fb: use devm_ioremap_resource()
e43064c video: sa1100fb: use devm_clk_get()
ba1d36b video: sa1100fb: use devm_kzalloc()
...
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] sa1100fb updates
Date: Mon, 27 Nov 2017 18:30:11 +0100 [thread overview]
Message-ID: <4330027.F5ASplytpk@amdc3058> (raw)
In-Reply-To: <20171127171145.GI31757@n2100.armlinux.org.uk>
On Monday, November 27, 2017 05:11:45 PM Russell King - ARM Linux wrote:
> On Tue, Oct 17, 2017 at 03:32:30PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Friday, September 29, 2017 11:50:04 AM Russell King - ARM Linux wrote:
> > > Hi Bart,
> >
> > Hi Russell,
> >
> > > This series updates the sa1100fb fbdev driver's initialisation paths
> > > to be more robust. In doing these updates, I realised that we omitted
> > > to free some memory which was allocated for the framebuffer if
> > > initialisation fails - something that was hidden due to the complex
> > > cleanup that the driver performs. Switching to managed resources made
> > > this more obvious.
> > >
> > > Tested on H3600 iPAQ and Assabet.
> > >
> > > drivers/video/fbdev/sa1100fb.c | 75 +++++++++++++++---------------------------
> > > drivers/video/fbdev/sa1100fb.h | 2 ++
> > > 2 files changed, 29 insertions(+), 48 deletions(-)
> >
> > I queued all patches for 4.15, thanks!
>
> Now that 4.15-rc1 is out, something tells me that was not actually
> the case. Any ideas what happened?
Could you please explain the issue that you are seeing a bit more?
For me it looks all fine:
$ git log --oneline v4.15-rc1 drivers/video/fbdev/sa1100fb.c
cb6bc3f video: sa1100fb: move pseudo palette into sa1100fb_info structure
0ab7658 video: sa1100fb: fix video memory allocation leak
c244f8e video: sa1100fb: clean up failure path
5634cba video: sa1100fb: use devm_gpio_request_one()
f6fc8c9 video: sa1100fb: use devm_request_irq()
df6b228 video: sa1100fb: use devm_ioremap_resource()
e43064c video: sa1100fb: use devm_clk_get()
ba1d36b video: sa1100fb: use devm_kzalloc()
...
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-11-27 17:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170929105024epcas5p336177e386c65b530c4cb5fac379cedfa@epcas5p3.samsung.com>
2017-09-29 10:50 ` [PATCH 0/8] sa1100fb updates Russell King - ARM Linux
2017-09-29 10:50 ` Russell King - ARM Linux
2017-09-29 10:50 ` [PATCH 1/8] video: sa1100fb: use devm_kzalloc() Russell King
2017-09-29 10:50 ` Russell King
2017-09-29 10:51 ` [PATCH 2/8] video: sa1100fb: use devm_clk_get() Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 3/8] video: sa1100fb: use devm_ioremap_resource() Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 4/8] video: sa1100fb: use devm_request_irq() Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 5/8] video: sa1100fb: use devm_gpio_request_one() Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 6/8] video: sa1100fb: clean up failure path Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 7/8] video: sa1100fb: fix video memory allocation leak Russell King
2017-09-29 10:51 ` Russell King
2017-09-29 10:51 ` [PATCH 8/8] video: sa1100fb: move pseudo palette into sa1100fb_info structure Russell King
2017-09-29 10:51 ` Russell King
2017-10-17 13:32 ` [PATCH 0/8] sa1100fb updates Bartlomiej Zolnierkiewicz
2017-10-17 13:32 ` Bartlomiej Zolnierkiewicz
2017-11-27 17:11 ` Russell King - ARM Linux
2017-11-27 17:11 ` Russell King - ARM Linux
2017-11-27 17:30 ` Bartlomiej Zolnierkiewicz [this message]
2017-11-27 17:30 ` Bartlomiej Zolnierkiewicz
2017-11-27 17:40 ` Russell King - ARM Linux
2017-11-27 17:40 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4330027.F5ASplytpk@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.