Re: compilation problems with gcc4

["Vladimir V. Saveliev" <vs@namesys.com>]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Hello

Grzegorz Piotr Jaskiewicz wrote:
> Trying to get beast to compile for me, to do review and testing here, I get 
> following problems with gcc 4.0.2:
> 
>   CC [M]  fs/reiser4/debug.o
> In file included from fs/reiser4/jnode.h:12,
>                  from fs/reiser4/lock.h:16,
>                  from fs/reiser4/context.h:15,
>                  from fs/reiser4/debug.c:32:
> fs/reiser4/txnmgr.h: In function 'spin_unlock_atom':
> fs/reiser4/txnmgr.h:559: warning: comparisons like X<=Y<=Z do not have their 
> mathematical meaning
> 

would you pleas try the attached patch to see whether it helps.

> That's reiserfs4 patch from ftp.namesys.com called:
> reiser4-for-2.6.12-3.patch
> gcc (GCC) 4.0.2 20050917 (prerelease)
> 
> I already requested that patch update to possible newest snapshot from 
> namesys'es cvs or whatever they use.
> 

the latest reiser4 code is available at ftp://ftp.namesys.com/pub/reiser4-for-2.6/git-snapshots/

> Thanks.
>  


[-- Attachment #2: reiser4-typo-fix.patch --]
[-- Type: text/plain, Size: 760 bytes --]

 fs/reiser4/spin_macros.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/reiser4/spin_macros.h~reiser4-typo-fix fs/reiser4/spin_macros.h
--- linux-2.6.12/fs/reiser4/spin_macros.h~reiser4-typo-fix	2005-09-22 16:22:20.563302069 +0400
+++ linux-2.6.12-vs/fs/reiser4/spin_macros.h	2005-09-22 16:23:20.924412525 +0400
@@ -173,7 +173,7 @@ static inline int  spin_trylock_ ## NAME
 static inline void spin_unlock_ ## NAME (TYPE *x)				\
 {										\
 	__ODCA("nikita-1375", LOCK_CNT_GTZ(spin_locked_ ## NAME));		\
-	__ODCA("nikita-1376", LOCK_CNT_GTZ(spin_locked > 0));			\
+	__ODCA("nikita-1376", LOCK_CNT_GTZ(spin_locked));			\
 	__ODCA("nikita-2703", spin_ ## NAME ## _is_locked(x));			\
 										\
 	spin_ ## NAME ## _dec();						\

_