From: "Vladimir V. Saveliev" <vs@namesys.com>
To: Grzegorz Piotr Jaskiewicz <gj@kdemail.net>
Cc: reiserfs-list@namesys.com
Subject: Re: compilation problems with gcc4
Date: Thu, 22 Sep 2005 17:00:24 +0400 [thread overview]
Message-ID: <4332AAE8.6050308@namesys.com> (raw)
In-Reply-To: <200509221443.37414@gj-laptop>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hello
Grzegorz Piotr Jaskiewicz wrote:
> still some warnings:
new verison of patch (undo previous one first), please
> CC [M] fs/reiser4/znode.o
> fs/reiser4/znode.c: In function 'znode_set_ld_key':
> fs/reiser4/znode.c:729: warning: comparisons like X<=Y<=Z do not have their
> mathematical meaning
> and the error.
> CC [M] fs/reiser4/znode.o
> fs/reiser4/znode.c: In function 'znode_set_ld_key':
> fs/reiser4/znode.c:729: warning: comparisons like X<=Y<=Z do not have their
> mathematical meaning
>
> It might be thou, because I am compiling against 2.6.13.2 not 2.6.14.X right ?
>
yes, you got quite old code.
[-- Attachment #2: reiser4-typo-fix.patch --]
[-- Type: text/plain, Size: 1456 bytes --]
fs/reiser4/spin_macros.h | 2 +-
fs/reiser4/znode.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/reiser4/spin_macros.h~reiser4-typo-fix fs/reiser4/spin_macros.h
--- linux-2.6.12/fs/reiser4/spin_macros.h~reiser4-typo-fix 2005-09-22 16:22:20.563302069 +0400
+++ linux-2.6.12-vs/fs/reiser4/spin_macros.h 2005-09-22 16:23:20.924412525 +0400
@@ -173,7 +173,7 @@ static inline int spin_trylock_ ## NAME
static inline void spin_unlock_ ## NAME (TYPE *x) \
{ \
__ODCA("nikita-1375", LOCK_CNT_GTZ(spin_locked_ ## NAME)); \
- __ODCA("nikita-1376", LOCK_CNT_GTZ(spin_locked > 0)); \
+ __ODCA("nikita-1376", LOCK_CNT_GTZ(spin_locked)); \
__ODCA("nikita-2703", spin_ ## NAME ## _is_locked(x)); \
\
spin_ ## NAME ## _dec(); \
diff -puN fs/reiser4/znode.c~reiser4-typo-fix fs/reiser4/znode.c
--- linux-2.6.12/fs/reiser4/znode.c~reiser4-typo-fix 2005-09-22 16:56:47.764336017 +0400
+++ linux-2.6.12-vs/fs/reiser4/znode.c 2005-09-22 16:57:00.139793859 +0400
@@ -726,7 +726,7 @@ znode_set_ld_key(znode * node, const rei
assert("nikita-2940", node != NULL);
assert("nikita-2941", key != NULL);
assert("nikita-2942", rw_dk_is_write_locked(znode_get_tree(node)));
- assert("nikita-3070", LOCK_CNT_GTZ(write_locked_dk > 0));
+ assert("nikita-3070", LOCK_CNT_GTZ(write_locked_dk));
assert("nikita-2943",
znode_is_any_locked(node) ||
keyeq(&node->ld_key, min_key()));
_
prev parent reply other threads:[~2005-09-22 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 11:26 compilation problems with gcc4 Grzegorz Piotr Jaskiewicz
2005-09-22 12:26 ` Vladimir V. Saveliev
2005-09-22 12:38 ` Grzegorz Piotr Jaskiewicz
2005-09-22 12:43 ` Grzegorz Piotr Jaskiewicz
2005-09-22 13:00 ` Vladimir V. Saveliev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4332AAE8.6050308@namesys.com \
--to=vs@namesys.com \
--cc=gj@kdemail.net \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.