From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, clameter@engr.sgi.com
Subject: Re: making kmalloc BUG() might not be a good idea
Date: Fri, 23 Sep 2005 16:30:33 +1000 [thread overview]
Message-ID: <4333A109.2000908@yahoo.com.au> (raw)
In-Reply-To: <20050922.231434.07643075.davem@davemloft.net>
David S. Miller wrote:
>I'm sort-of concerned about this change:
>
> [PATCH] __kmalloc: Generate BUG if size requested is too large.
>
>it opens a can of worms, and stuff that used to generate
>-ENOMEM kinds of failures will now BUG() the kernel.
>
>Unless you're going to audit every user triggerable
>path for proper size limiting, I think we should revert
>this change.
>
>Thanks.
>
>
Making it WARN might be a good compromise.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-09-23 6:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 6:14 making kmalloc BUG() might not be a good idea David S. Miller
2005-09-23 6:30 ` Nick Piggin [this message]
2005-09-23 6:54 ` David S. Miller
2005-09-23 7:09 ` Ingo Oeser
2005-09-23 7:58 ` Nick Piggin
2005-09-23 8:09 ` David S. Miller
2005-09-23 9:03 ` Nick Piggin
2005-09-23 9:17 ` Coywolf Qi Hunt
2005-09-23 15:58 ` Make kzalloc a macro Christoph Lameter
2005-09-23 17:50 ` Christoph Lameter
2005-09-23 22:37 ` Andrew Morton
2005-09-26 17:38 ` Christoph Lameter
2005-09-24 10:52 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4333A109.2000908@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=clameter@engr.sgi.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.