From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: ioe-lkml@rameria.de, linux-kernel@vger.kernel.org, clameter@engr.sgi.com
Subject: Re: making kmalloc BUG() might not be a good idea
Date: Fri, 23 Sep 2005 19:03:48 +1000 [thread overview]
Message-ID: <4333C4F4.9030402@yahoo.com.au> (raw)
In-Reply-To: <20050923.010939.11256142.davem@davemloft.net>
David S. Miller wrote:
> From: Nick Piggin <nickpiggin@yahoo.com.au>
> Date: Fri, 23 Sep 2005 17:58:00 +1000
>
> If we know how to make certain classes of bugs non-lethal, we should
> do so because there will always be bugs. :-) This change makes
> previously non-lethal bugs potentially kill the machine.
>
Oh the BUG is bad, sure. I just thought WARN would be a better _compromise_
than BUG in that it will achieve the same result without takeing the machine
down.
I think the CONFIG_DEBUG options are there for some major types of debugging
that require significant infrastructure or can slow down the kernel quite
a lot. With that said, I think there is an option somewhere to turn off all
WARNs and remove strings from all BUGs.
Regarding proliferation of assertions and warnings everywhere - without any
official standard, I think we're mostly being sensible with them (at least
in the core code that I look at). A warn in kmalloc for this wouldn't be
anything radical.
I don't much care for it, but I agree the BUG has to go.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-09-23 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 6:14 making kmalloc BUG() might not be a good idea David S. Miller
2005-09-23 6:30 ` Nick Piggin
2005-09-23 6:54 ` David S. Miller
2005-09-23 7:09 ` Ingo Oeser
2005-09-23 7:58 ` Nick Piggin
2005-09-23 8:09 ` David S. Miller
2005-09-23 9:03 ` Nick Piggin [this message]
2005-09-23 9:17 ` Coywolf Qi Hunt
2005-09-23 15:58 ` Make kzalloc a macro Christoph Lameter
2005-09-23 17:50 ` Christoph Lameter
2005-09-23 22:37 ` Andrew Morton
2005-09-26 17:38 ` Christoph Lameter
2005-09-24 10:52 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4333C4F4.9030402@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=clameter@engr.sgi.com \
--cc=davem@davemloft.net \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.