From: Xiaofeng Ling <xiaofeng.ling@intel.com>
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH][VT] Fix vnc configure problem for vmx guest
Date: Mon, 26 Sep 2005 09:51:17 +0800 [thread overview]
Message-ID: <43375415.1040406@intel.com> (raw)
In-Reply-To: <20050923160027.GL2439@uk.xensource.com>
Ewan Mellor wrote:
> On Fri, Sep 23, 2005 at 11:12:26PM +0800, Ling, Xiaofeng wrote:
>
>
>>see attach mail. That is why configVNC is seperated.
>>I know this fix is not seems so ideal,
>>I'd like to know if you have good idea for the problem.
>
>
> Thanks for that. I've had a look, and I don't see any reason for ImageHandler
> to be created before the domain itself, so I've moved the ImageHandler.create
> call so that it is after the xc.domain_create call. This means that you have
> the domid available inside configVNC, as necessary.
>
> The change will be pushed to the public server in the next few minutes. Let
> me know how you get on.
Yes, moving ImageGandler.create after domain create resolves the
problem. but I guess the original purpose of putting ImageHandler.create
after domain creating maybe if ImageHanler.ceate fails(some
configuration wrong), there'll be no useless domain struct exists.
So I seperates the configVNC and put it after the domain creating.
Maybe better way is have a pre-config and post-config?
next prev parent reply other threads:[~2005-09-26 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 15:12 [PATCH][VT] Fix vnc configure problem for vmx guest Ling, Xiaofeng
2005-09-23 16:00 ` Ewan Mellor
2005-09-26 1:51 ` Xiaofeng Ling [this message]
2005-09-26 8:41 ` Ewan Mellor
-- strict thread matches above, loose matches on Subject: below --
2005-09-26 8:59 Ling, Xiaofeng
2005-09-23 9:29 Li, Xin B
2005-09-23 0:31 Ling, Xiaofeng
2005-09-23 9:23 ` Ewan Mellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43375415.1040406@intel.com \
--to=xiaofeng.ling@intel.com \
--cc=ewan@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.