From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code
Date: Thu, 21 Apr 2016 13:27:39 +0200 [thread overview]
Message-ID: <4337545.DyleYAUzIV@wuerfel> (raw)
In-Reply-To: <1461236675-10176-10-git-send-email-peter.griffin@linaro.org>
On Thursday 21 April 2016 12:04:26 Peter Griffin wrote:
> uniperiph-id, version and mode are ST specific bindings and
> need the 'st,' prefix. Update the examples, as otherwise copying
> them yields a runtime error parsing the DT node.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: arnaud.pouliquen at st.com
> ---
> .../devicetree/bindings/sound/st,sti-asoc-card.txt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> index 028fa1c..ef2e0c6 100644
> --- a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> @@ -67,9 +67,9 @@ Example:
> dmas = <&fdma0 4 0 1>;
> dai-name = "Uni Player #1 (DAC)";
> dma-names = "tx";
> - uniperiph-id = <2>;
> - version = <5>;
> - mode = "PCM";
> + st,uniperiph-id = <2>;
> + st,version = <5>;
> + st,mode = "PCM";
> };
You don't change the binding desciption here, only the example,
so they no longer match.
What is st,uniperiph-id needed for anyway? It's often an indication
that you are doing something wrong if you need this.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: devicetree@vger.kernel.org, vinod.koul@intel.com,
srinivas.kandagatla@gmail.com, arnaud.pouliquen@st.com,
patrice.chotard@st.com, linux-kernel@vger.kernel.org,
broonie@kernel.org, ludovic.barre@st.com,
dmaengine@vger.kernel.org, lee.jones@linaro.org,
linux-arm-kernel@lists.infradead.org, maxime.coquelin@st.com
Subject: Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code
Date: Thu, 21 Apr 2016 13:27:39 +0200 [thread overview]
Message-ID: <4337545.DyleYAUzIV@wuerfel> (raw)
In-Reply-To: <1461236675-10176-10-git-send-email-peter.griffin@linaro.org>
On Thursday 21 April 2016 12:04:26 Peter Griffin wrote:
> uniperiph-id, version and mode are ST specific bindings and
> need the 'st,' prefix. Update the examples, as otherwise copying
> them yields a runtime error parsing the DT node.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: arnaud.pouliquen@st.com
> ---
> .../devicetree/bindings/sound/st,sti-asoc-card.txt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> index 028fa1c..ef2e0c6 100644
> --- a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> @@ -67,9 +67,9 @@ Example:
> dmas = <&fdma0 4 0 1>;
> dai-name = "Uni Player #1 (DAC)";
> dma-names = "tx";
> - uniperiph-id = <2>;
> - version = <5>;
> - mode = "PCM";
> + st,uniperiph-id = <2>;
> + st,version = <5>;
> + st,mode = "PCM";
> };
You don't change the binding desciption here, only the example,
so they no longer match.
What is st,uniperiph-id needed for anyway? It's often an indication
that you are doing something wrong if you need this.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
maxime.coquelin@st.com, patrice.chotard@st.com,
vinod.koul@intel.com, lee.jones@linaro.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
broonie@kernel.org, ludovic.barre@st.com,
arnaud.pouliquen@st.com
Subject: Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code
Date: Thu, 21 Apr 2016 13:27:39 +0200 [thread overview]
Message-ID: <4337545.DyleYAUzIV@wuerfel> (raw)
In-Reply-To: <1461236675-10176-10-git-send-email-peter.griffin@linaro.org>
On Thursday 21 April 2016 12:04:26 Peter Griffin wrote:
> uniperiph-id, version and mode are ST specific bindings and
> need the 'st,' prefix. Update the examples, as otherwise copying
> them yields a runtime error parsing the DT node.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: arnaud.pouliquen@st.com
> ---
> .../devicetree/bindings/sound/st,sti-asoc-card.txt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> index 028fa1c..ef2e0c6 100644
> --- a/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
> @@ -67,9 +67,9 @@ Example:
> dmas = <&fdma0 4 0 1>;
> dai-name = "Uni Player #1 (DAC)";
> dma-names = "tx";
> - uniperiph-id = <2>;
> - version = <5>;
> - mode = "PCM";
> + st,uniperiph-id = <2>;
> + st,version = <5>;
> + st,mode = "PCM";
> };
You don't change the binding desciption here, only the example,
so they no longer match.
What is st,uniperiph-id needed for anyway? It's often an indication
that you are doing something wrong if you need this.
Arnd
next prev parent reply other threads:[~2016-04-21 11:27 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:04 [PATCH 00/18] Add support for FDMA DMA controller found on STi chipsets Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 01/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:25 ` Arnd Bergmann
2016-04-21 11:25 ` Arnd Bergmann
2016-04-21 11:25 ` Arnd Bergmann
2016-04-26 12:00 ` Peter Griffin
2016-04-26 12:00 ` Peter Griffin
2016-04-26 12:00 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 02/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:20 ` Arnd Bergmann
2016-04-21 11:20 ` Arnd Bergmann
2016-04-21 11:20 ` Arnd Bergmann
2016-04-21 11:04 ` [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:24 ` Arnd Bergmann
2016-04-21 11:24 ` Arnd Bergmann
2016-04-21 11:26 ` Appana Durga Kedareswara Rao
2016-04-21 11:26 ` Appana Durga Kedareswara Rao
2016-04-21 14:58 ` Peter Griffin
2016-04-21 14:58 ` Peter Griffin
2016-04-21 14:58 ` Peter Griffin
2016-04-25 9:04 ` Lee Jones
2016-04-25 9:04 ` Lee Jones
2016-04-25 9:04 ` Lee Jones
2016-04-26 16:56 ` Vinod Koul
2016-04-26 16:56 ` Vinod Koul
2016-04-27 12:59 ` Peter Griffin
2016-04-27 12:59 ` Peter Griffin
2016-04-27 12:59 ` Peter Griffin
2016-05-02 9:30 ` Vinod Koul
2016-05-02 9:30 ` Vinod Koul
2016-05-02 9:30 ` Vinod Koul
2016-05-09 17:30 ` Peter Griffin
2016-05-09 17:30 ` Peter Griffin
2016-05-09 17:30 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 04/18] dmaengine: st_fdma: Add xp70 firmware loading mechanism Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-26 17:00 ` Vinod Koul
2016-04-26 17:00 ` Vinod Koul
2016-04-26 17:00 ` Vinod Koul
2016-05-11 7:57 ` Peter Griffin
2016-05-11 7:57 ` Peter Griffin
2016-05-12 5:40 ` Vinod Koul
2016-05-12 5:40 ` Vinod Koul
2016-04-21 11:04 ` [PATCH 05/18] dmaengine: st_fdma: Add fdma suspend and resume callbacks Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 06/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 07/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 08/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:25 ` Arnd Bergmann
2016-04-21 11:25 ` Arnd Bergmann
2016-04-21 11:25 ` Arnd Bergmann
2016-04-26 10:42 ` Peter Griffin
2016-04-26 10:42 ` Peter Griffin
2016-04-26 10:42 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 09/18] ASoC: sti: Update DT example to match the driver code Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:27 ` Arnd Bergmann [this message]
2016-04-21 11:27 ` Arnd Bergmann
2016-04-21 11:27 ` Arnd Bergmann
2016-04-26 10:11 ` Peter Griffin
2016-04-26 10:11 ` Peter Griffin
2016-04-26 10:58 ` Arnd Bergmann
2016-04-26 10:58 ` Arnd Bergmann
2016-04-26 10:58 ` Arnd Bergmann
2016-04-26 11:15 ` Peter Griffin
2016-04-26 11:15 ` Peter Griffin
2016-04-26 11:44 ` Arnd Bergmann
2016-04-26 11:44 ` Arnd Bergmann
2016-04-26 11:44 ` Arnd Bergmann
2016-05-04 7:52 ` Arnaud Pouliquen
2016-05-04 7:52 ` Arnaud Pouliquen
2016-05-04 7:52 ` Arnaud Pouliquen
2016-05-04 9:05 ` Arnd Bergmann
2016-05-04 9:05 ` Arnd Bergmann
2016-04-21 15:57 ` Mark Brown
2016-04-21 15:57 ` Mark Brown
2016-04-21 15:57 ` Mark Brown
2016-04-26 11:02 ` Peter Griffin
2016-04-26 11:02 ` Peter Griffin
2016-04-26 11:02 ` Peter Griffin
2016-05-03 15:46 ` Arnaud Pouliquen
2016-05-03 15:46 ` Arnaud Pouliquen
2016-05-03 15:46 ` Arnaud Pouliquen
2016-04-21 11:04 ` [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 15:49 ` Mark Brown
2016-04-21 15:49 ` Mark Brown
2016-04-21 15:49 ` Mark Brown
2016-04-26 11:52 ` Peter Griffin
2016-04-26 11:52 ` Peter Griffin
2016-04-26 11:52 ` Peter Griffin
2016-04-26 14:23 ` Mark Brown
2016-04-26 14:23 ` Mark Brown
2016-04-26 14:23 ` Mark Brown
2016-04-26 14:51 ` Peter Griffin
2016-04-26 14:51 ` Peter Griffin
2016-04-26 15:03 ` Mark Brown
2016-04-26 15:03 ` Mark Brown
2016-04-26 16:14 ` Peter Griffin
2016-04-26 16:14 ` Peter Griffin
2016-04-26 16:14 ` Peter Griffin
2016-04-26 16:41 ` Mark Brown
2016-04-26 16:41 ` Mark Brown
2016-04-26 17:49 ` Peter Griffin
2016-04-26 17:49 ` Peter Griffin
2016-04-26 17:49 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 11/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 12/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 13/18] ARM: DT: STiH407: Add i2s_in " Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 14/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 17/18] ARM: STi: DT: STiH407: Add uniperif reader " Peter Griffin
2016-04-21 11:04 ` Peter Griffin
2016-04-21 11:04 ` [PATCH 18/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-04-21 11:04 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4337545.DyleYAUzIV@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.