From: Joel Schopp <jschopp@austin.ibm.com>
To: Alex Bligh - linux-kernel <linux-kernel@alex.org.uk>
Cc: lhms <lhms-devel@lists.sourceforge.net>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 4/9] defrag helper functions
Date: Tue, 27 Sep 2005 11:08:35 -0500 [thread overview]
Message-ID: <43396E83.7000803@austin.ibm.com> (raw)
In-Reply-To: <C50046EE58FA62242E92877C@[192.168.100.25]>
>> +void assign_bit(int bit_nr, unsigned long* map, int value)
>
>
> Maybe:
> static inline void assign_bit(int bit_nr, unsigned long* map, int value)
>
> it's short enough
OK. It looks like I'll be sending these again based on the feedback I got,
I'll inline that in the next version. I'd think with it being static that
the compiler would be smart enough to inline it anyway though.
>
>> +static struct page *
>> +fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
>> +{
>> + /* Stub out for seperate review, NULL equates to no fallback*/
>> + return NULL;
>> +
>> +}
>
>
> Maybe "static inline" too.
Except this is only a placeholder for the next patch, where the function
is no longer short. I'm going to keep it not inline.
WARNING: multiple messages have this Message-ID (diff)
From: Joel Schopp <jschopp@austin.ibm.com>
To: Alex Bligh - linux-kernel <linux-kernel@alex.org.uk>
Cc: lhms <lhms-devel@lists.sourceforge.net>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 4/9] defrag helper functions
Date: Tue, 27 Sep 2005 11:08:35 -0500 [thread overview]
Message-ID: <43396E83.7000803@austin.ibm.com> (raw)
In-Reply-To: <C50046EE58FA62242E92877C@[192.168.100.25]>
>> +void assign_bit(int bit_nr, unsigned long* map, int value)
>
>
> Maybe:
> static inline void assign_bit(int bit_nr, unsigned long* map, int value)
>
> it's short enough
OK. It looks like I'll be sending these again based on the feedback I got,
I'll inline that in the next version. I'd think with it being static that
the compiler would be smart enough to inline it anyway though.
>
>> +static struct page *
>> +fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
>> +{
>> + /* Stub out for seperate review, NULL equates to no fallback*/
>> + return NULL;
>> +
>> +}
>
>
> Maybe "static inline" too.
Except this is only a placeholder for the next patch, where the function
is no longer short. I'm going to keep it not inline.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-27 16:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-26 20:01 [PATCH 0/9] fragmentation avoidance Joel Schopp
2005-09-26 20:03 ` [PATCH 1/9] add defrag flags Joel Schopp
2005-09-27 0:16 ` Kyle Moffett
2005-09-27 0:16 ` Kyle Moffett
2005-09-27 0:24 ` Dave Hansen
2005-09-27 0:24 ` Dave Hansen
2005-09-27 0:43 ` Kyle Moffett
2005-09-27 0:43 ` Kyle Moffett
2005-09-27 5:44 ` Paul Jackson
2005-09-27 5:44 ` Paul Jackson
2005-09-27 13:34 ` Mel Gorman
2005-09-27 13:34 ` Mel Gorman
2005-09-27 16:26 ` [Lhms-devel] " Paul Jackson
2005-09-27 16:26 ` Paul Jackson
2005-09-27 18:38 ` Joel Schopp
2005-09-27 19:30 ` Paul Jackson
2005-09-27 19:30 ` Paul Jackson
2005-09-27 21:00 ` [Lhms-devel] " Joel Schopp
2005-09-27 21:00 ` Joel Schopp
2005-09-27 21:23 ` Paul Jackson
2005-09-27 21:23 ` Paul Jackson
2005-09-27 22:03 ` Joel Schopp
2005-09-27 22:45 ` Paul Jackson
2005-09-27 22:45 ` Paul Jackson
2005-09-26 20:05 ` [PATCH 2/9] declare defrag structs Joel Schopp
2005-09-26 20:06 ` [PATCH 3/9] initialize defrag Joel Schopp
2005-09-26 20:09 ` [PATCH 4/9] defrag helper functions Joel Schopp
2005-09-26 22:29 ` Alex Bligh - linux-kernel
2005-09-26 22:29 ` Alex Bligh - linux-kernel
2005-09-27 16:08 ` Joel Schopp [this message]
2005-09-27 16:08 ` Joel Schopp
2005-09-26 20:11 ` [PATCH 5/9] propagate defrag alloc types Joel Schopp
2005-09-26 20:13 ` [PATCH 6/9] fragmentation avoidance core Joel Schopp
2005-09-26 20:14 ` [PATCH 7/9] try harder on large allocations Joel Schopp
2005-09-27 7:21 ` Coywolf Qi Hunt
2005-09-27 7:21 ` Coywolf Qi Hunt
2005-09-27 16:17 ` Joel Schopp
2005-09-27 16:17 ` Joel Schopp
2005-09-26 20:16 ` [PATCH 8/9] defrag fallback Joel Schopp
2005-09-26 20:17 ` [PATCH 9/9] free memory is user reclaimable Joel Schopp
2005-09-26 20:19 ` [PATCH 10/9] percpu splitout Joel Schopp
2005-09-26 21:49 ` [Lhms-devel] [PATCH 0/9] fragmentation avoidance Joel Schopp
2005-09-26 21:49 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43396E83.7000803@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@alex.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.