Re: [PATCH] ov511-2.28 patch for 2.6.12 kernel compat.

[Gregor Jasny <gjasny@web.de>]

Laurent Meunier schrieb:
> This patch basically remove references to the 'id' field from the static 
> struct i2c_client client_template in ovcamchip_core.c, tda7313.c and 
> saa7111-new.c) and update a deprecated function (usb_unlink_urb -> 
> usb_kill_urb).

> diff -rbup ov511-2.28-orig/ovfx2.c ov511-2.28-new/ovfx2.c
> --- ov511-2.28-orig/ovfx2.c	2004-07-16 01:32:08.000000000 +0200
> +++ ov511-2.28-new/ovfx2.c	2005-09-24 14:00:12.000000000 +0200
> @@ -1678,7 +1678,11 @@ ovfx2_unlink_bulk(struct usb_ovfx2 *ov)
>  	/* Unschedule all of the bulk td's */
>  	for (n = OVFX2_NUMSBUF - 1; n >= 0; n--) {
>  		if (ov->sbuf[n].urb) {
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 12)
>  			usb_unlink_urb(ov->sbuf[n].urb);
> +#else
> +			usb_unlink_urb(ov->sbuf[n].urb);
> +#endif

This lines look suspicous to me. Do you meant usb_kill_urb in the >= 
2.6.12 case?

Gregor