From: Laurent Meunier <meunier.laurent@laposte.net>
To: Gregor Jasny <gjasny@web.de>
Cc: mmcclell@bigfoot.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ov511-2.28 patch for 2.6.12 kernel compat.
Date: Tue, 27 Sep 2005 20:19:07 +0200 [thread overview]
Message-ID: <43398D1B.4080103@laposte.net> (raw)
In-Reply-To: <43397FF8.4090902@web.de>
>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 12)
>> usb_unlink_urb(ov->sbuf[n].urb);
>> +#else
>> + usb_unlink_urb(ov->sbuf[n].urb);
>> +#endif
>
>
> This lines look suspicous to me. Do you meant usb_kill_urb in the >=
> 2.6.12 case?
>
> Gregor
>
Yes, it should be usb_kill_urb in the >= 2.6.12 case. I made a mistake,
sorry for that.
diff -rbup ov511-2.28-orig/ovfx2.c ov511-2.28-new/ovfx2.c
--- ov511-2.28-orig/ovfx2.c 2004-07-16 01:32:08.000000000 +0200
+++ ov511-2.28-new/ovfx2.c 2005-09-27 20:12:54.000000000 +0200
@@ -1678,7 +1678,11 @@ ovfx2_unlink_bulk(struct usb_ovfx2 *ov)
/* Unschedule all of the bulk td's */
for (n = OVFX2_NUMSBUF - 1; n >= 0; n--) {
if (ov->sbuf[n].urb) {
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 12)
+ usb_kill_urb(ov->sbuf[n].urb);
+#else
usb_unlink_urb(ov->sbuf[n].urb);
+#endif
Laurent
prev parent reply other threads:[~2005-09-27 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 11:24 [PATCH] ov511-2.28 patch for 2.6.12 kernel compat Laurent Meunier
2005-09-27 17:23 ` Gregor Jasny
2005-09-27 18:19 ` Laurent Meunier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43398D1B.4080103@laposte.net \
--to=meunier.laurent@laposte.net \
--cc=gjasny@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mmcclell@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.