From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Rohit Seth <rohit.seth@intel.com>,
akpm@osdl.org, linux-mm@kvack.org,
Mattia Dongili <malattia@linux.it>,
linux-kernel@vger.kernel.org, steiner@sgi.com
Subject: Re: [patch] Reset the high water marks in CPUs pcp list
Date: Thu, 29 Sep 2005 16:49:26 +1000 [thread overview]
Message-ID: <433B8E76.9080005@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.62.0509281455310.15902@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
>
>I know that Jack and Nick did something with those counts to insure that
>page coloring effects are avoided. Would you comment?
>
>
The 'batch' argument to setup_pageset should be clamped to a power
of 2 minus 1 (ie. 15, 31, etc), which was found to avoid the worst
of the colouring problems.
pcp->high of the hotlist IMO should have been reduced to 4 anyway
after its pcp->low was reduced from 2 to 0.
I don't see that there would be any problems with playing with the
->high and ->low numbers so long as they are a reasonable multiple
of batch, however I would question the merit of setting the high
watermark of the cold queue to ->batch + 1 (should really stay at
2*batch IMO).
Nick
Send instant messages to your online friends http://au.messenger.yahoo.com
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Rohit Seth <rohit.seth@intel.com>,
akpm@osdl.org, linux-mm@kvack.org,
Mattia Dongili <malattia@linux.it>,
linux-kernel@vger.kernel.org, steiner@sgi.com
Subject: Re: [patch] Reset the high water marks in CPUs pcp list
Date: Thu, 29 Sep 2005 16:49:26 +1000 [thread overview]
Message-ID: <433B8E76.9080005@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.62.0509281455310.15902@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
>
>I know that Jack and Nick did something with those counts to insure that
>page coloring effects are avoided. Would you comment?
>
>
The 'batch' argument to setup_pageset should be clamped to a power
of 2 minus 1 (ie. 15, 31, etc), which was found to avoid the worst
of the colouring problems.
pcp->high of the hotlist IMO should have been reduced to 4 anyway
after its pcp->low was reduced from 2 to 0.
I don't see that there would be any problems with playing with the
->high and ->low numbers so long as they are a reasonable multiple
of batch, however I would question the merit of setting the high
watermark of the cold queue to ->batch + 1 (should really stay at
2*batch IMO).
Nick
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-29 6:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 17:50 [patch] Reset the high water marks in CPUs pcp list Seth, Rohit
2005-09-28 17:50 ` Seth, Rohit
2005-09-28 20:01 ` Christoph Lameter
2005-09-28 20:01 ` Christoph Lameter
2005-09-28 20:26 ` Rohit Seth
2005-09-28 20:26 ` Rohit Seth
2005-09-28 21:09 ` Christoph Lameter
2005-09-28 21:09 ` Christoph Lameter
2005-09-28 21:32 ` Rohit Seth
2005-09-28 21:32 ` Rohit Seth
2005-09-28 21:56 ` Christoph Lameter
2005-09-28 21:56 ` Christoph Lameter
2005-09-29 1:12 ` Rohit Seth
2005-09-29 1:12 ` Rohit Seth
2005-09-29 6:49 ` Nick Piggin [this message]
2005-09-29 6:49 ` Nick Piggin
2005-09-29 16:34 ` Rohit Seth
2005-09-29 16:34 ` Rohit Seth
2005-09-28 21:18 ` Martin J. Bligh
2005-09-28 21:18 ` Martin J. Bligh
2005-09-28 21:55 ` Christoph Lameter
2005-09-28 21:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433B8E76.9080005@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malattia@linux.it \
--cc=rohit.seth@intel.com \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.