Re: [PATCH v3] Grow: Split Grow_reshape into helper function

["Kusiak, Mateusz" <mateusz.kusiak@linux.intel.com>]

On 28/06/2022 17:56, Coly Li wrote:
> 
> 
>> 2022年6月21日 01:21，Coly Li <colyli@suse.de> 写道：
>>
>>
>>
>>> 2022年6月9日 15:41，Mateusz Kusiak <mateusz.kusiak@intel.com> 写道：
>>>
>>> Grow_reshape should be split into helper functions given its size.
>>> - Add helper function for preparing reshape on external metadata.
>>> - Close cfd file descriptor.
>>>
>>> Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
>>
>> Hi Mateusz,
>>
>> Overall I am fine with this patch. Currently it dose apply on branch 20220621-testing of the mdadm-CI tree. This branch is based on mdadm upstream commit 756a15f32338 (“imsm: Remove possibility for get_imsm_dev to return NULL”) and stacked with other asked patch from for-jes/20220620.
>>
>> I will response this patch after other queuing patches are handled by Jes. If the change is minor, I will do the patch rebase and inform you.
> 
> Hi Mateusz,
> 
> I just rebased the patch and pushed to mdadm-CI tree into branch 20220621-testing. This is the only patch in this testing branch. It looks fine to me, but can you help to confirm whether the rebase is correctly? The conflict happens in Grow.c:Grow_reshap().
> 
> Thanks.
> 
> Coly Li
> 

Hi Coly,
I checked the conflict myself, and the changes on the branch also look
fine for me.

Thanks,
Mateusz