Re: [PATCH v3] Grow: Split Grow_reshape into helper function

[Jes Sorensen <jes@trained-monkey.org>]

On 8/8/22 06:03, Coly Li wrote:
> 
> 
>> 2022年8月8日 04:41，Jes Sorensen <jes@trained-monkey.org> 写道：
>>
>> On 6/9/22 03:41, Mateusz Kusiak wrote:
>>> Grow_reshape should be split into helper functions given its size.
>>> - Add helper function for preparing reshape on external metadata.
>>> - Close cfd file descriptor.
>>> Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
>>> ---
>>> Changes since v2:
>>> - removed dot from commit message
>>> - formatted commit description as a list
>>> - got rid of returning -1 in prepare_external_reshape()
>>> - changed "return" section in prepare_external_reshape() description
>>
>> Hi Mateusz,
>>
>> Changes look good to me, but it no longer applies. Mind sending an updated version?
> 
> Hi Jes,
> 
> Please check the version I post to you in series “mdadm-CI for-jes/20220728: patches for merge” (Message-Id: <20220728122101.28744-1-colyli@suse.de>), the patch in this series is rebased and confirmed with Mateusz, it could be applied to upstream mdadm.

Hi Coly,

It is really painful for me to pull individual patches out of a large
set like that. It is much easier to deal with acks and updated patches
and being able to pull in smaller sets via patchworks.

Thanks,
Jes