* [U-Boot-Users] Bug in AT91RM9200.h [not found] ` <42FC666D.6060704@imc-berlin.de> @ 2005-10-10 12:23 ` Steven Scholz 2005-10-10 12:33 ` Steven Scholz 0 siblings, 1 reply; 2+ messages in thread From: Steven Scholz @ 2005-10-10 12:23 UTC (permalink / raw) To: u-boot Guys, A while ago I sent the following the the linux arm ML. I am sure this applies to U-Boot as well! > I just noticed the following: > > in incluse/asm-arm/mach-at91rm9200/AT91RM9200.h > > #define AT91C_SMC2_DBW (0x1 << 13) // (SMC2) Data Bus Width > > and drivers/pcmcia/at91_cf.c uses code like > > csr &= ~AT91C_SMC2_DBW; > > BUT: > > According to the User Man the "DBW: Data Bus Width" field is _TWO_ bits. > Thus it should be > > #define AT91C_SMC2_DBW (0x3 << 13) // (SMC2) Data Bus Width So please apply this trivial. * Fix define in AT91RM9200.h Patch by Steven Scholz, 10 Oct 2005 -- Steven -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: at91rm9200.h.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20051010/b3f32431/attachment.txt ^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] Bug in AT91RM9200.h 2005-10-10 12:23 ` [U-Boot-Users] Bug in AT91RM9200.h Steven Scholz @ 2005-10-10 12:33 ` Steven Scholz 0 siblings, 0 replies; 2+ messages in thread From: Steven Scholz @ 2005-10-10 12:33 UTC (permalink / raw) To: u-boot Ladies, there's another wrong define in AT91RM9200. According the (my) User Man the RWHOLD field of SMC_CSR0..SMC_CSR7 starts at bit 28. Thus #define AT91C_SMC2_RWHOLD ((unsigned int) 0x7 << 29) /* (SMC2) Read and Write Signal Hold Time */ is rubbish! So please apply this trivial patch instead if my previous one: * Fix defines AT91C_SMC2_DBW and AT91C_SMC2_RWHOLD in AT91RM9200.h Patch by Steven Scholz, 10 Oct 2005 (Machine generate header file - ha, ha!) -- Steven -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: at91rm9200.h.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20051010/e0933ea8/attachment.txt ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-10 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <42F82884.9090500@billgatliff.com>
[not found] ` <42FC666D.6060704@imc-berlin.de>
2005-10-10 12:23 ` [U-Boot-Users] Bug in AT91RM9200.h Steven Scholz
2005-10-10 12:33 ` Steven Scholz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.