From: Jiri Slaby <jirislaby@gmail.com>
To: Grzegorz Nosek <grzegorz.nosek@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sys_sendfile oops in 2.6.13?
Date: Tue, 11 Oct 2005 16:53:47 +0200 [thread overview]
Message-ID: <434BD1FB.7070608@gmail.com> (raw)
In-Reply-To: <121a28810510110156q1369b9dg@mail.gmail.com>
Grzegorz Nosek napsal(a):
>Hi all
>
>I found an (IMHO) silly bug in do_sendfile in 2.6.13.x kernels (at
>least in 2.6.13.3 and .4, didn't backtrack to find where it
>originated). Without the patch all I apparently get from sys_sendfile
>is an oops due to a call in sys_sendfile with ppos being NULL. With the
>patch it works OK. Noticed in vsftpd.
>
>The patch may apply with some fuzz as my kernel is somehwat patched but
>the gist of the patch is the same anyway
>
>Regards,
> Grzegorz Nosek
>
>--- linux-2.6/fs/read_write.c~ 2005-10-06 21:35:03.000000000 +0200
>+++ linux-2.6/fs/read_write.c 2005-10-05 19:14:04.000000000 +0200
>@@ -719,7 +719,7 @@
> current->syscr++;
> current->syscw++;
>
>- if (*ppos > max)
>+ if (ppos && *ppos > max)
>
>
I don't know the code surrounding this, but shouldn't be this
(!ppos || *ppos > max)?
> retval = -EOVERFLOW;
>
> fput_out:
>
>
--
js
next prev parent reply other threads:[~2005-10-11 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 8:56 sys_sendfile oops in 2.6.13? Grzegorz Nosek
2005-10-11 14:53 ` Jiri Slaby [this message]
2005-10-12 4:00 ` Andy Isaacson
2005-10-12 9:11 ` Grzegorz Nosek
2005-10-12 17:38 ` Chris Wright
2005-10-12 20:06 ` Grzegorz Nosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434BD1FB.7070608@gmail.com \
--to=jirislaby@gmail.com \
--cc=grzegorz.nosek@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.