[Xenomai-core] Fixes for serial driver

[Xenomai-core] Fixes for serial driver

[Jan Kiszka]

[-- Attachment #1.1: Type: text/plain, Size: 176 bytes --]

Hi,

attached are two minor fixes for the serial driver and header: one is
cosmetic, the other addresses out-of-memory detection.

Credits go, as usual, to Sebastian. ;)

Jan


[-- Attachment #1.2: serial.patch --]
[-- Type: text/plain, Size: 906 bytes --]

Index: skins/rtdm/rtserial.h
===================================================================
--- skins/rtdm/rtserial.h	(revision 29)
+++ skins/rtdm/rtserial.h	(working copy)
@@ -113,7 +113,7 @@
 
 /*!
  * @anchor RTSER_xxx_PARITY   @name RTSER_xxx_PARITY
- * Number of parity bits @anchor RTSER_xxx_PARITY
+ * Number of parity bits
  * @{ */
 #define RTSER_NO_PARITY             0x00
 #define RTSER_ODD_PARITY            0x01
Index: drivers/16550A/16550A.c
===================================================================
--- drivers/16550A/16550A.c	(revision 29)
+++ drivers/16550A/16550A.c	(working copy)
@@ -568,6 +568,9 @@
                 } else
                     hist_buf =
                         rtdm_malloc(IN_BUFFER_SIZE * sizeof(__u64));
+
+                if (!hist_buf)
+                    return -ENOMEM;
             }
 
             rt_16550_set_config(ctx, config, &hist_buf);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

Re: [Xenomai-core] Fixes for serial driver

[Philippe Gerum]

Jan Kiszka wrote:
> Hi,
> 
> attached are two minor fixes for the serial driver and header: one is
> cosmetic, the other addresses out-of-memory detection.
> 
> Credits go, as usual, to Sebastian. ;)
> 

Applied, thanks.

> Jan
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: skins/rtdm/rtserial.h
> ===================================================================
> --- skins/rtdm/rtserial.h	(revision 29)
> +++ skins/rtdm/rtserial.h	(working copy)
> @@ -113,7 +113,7 @@
>  
>  /*!
>   * @anchor RTSER_xxx_PARITY   @name RTSER_xxx_PARITY
> - * Number of parity bits @anchor RTSER_xxx_PARITY
> + * Number of parity bits
>   * @{ */
>  #define RTSER_NO_PARITY             0x00
>  #define RTSER_ODD_PARITY            0x01
> Index: drivers/16550A/16550A.c
> ===================================================================
> --- drivers/16550A/16550A.c	(revision 29)
> +++ drivers/16550A/16550A.c	(working copy)
> @@ -568,6 +568,9 @@
>                  } else
>                      hist_buf =
>                          rtdm_malloc(IN_BUFFER_SIZE * sizeof(__u64));
> +
> +                if (!hist_buf)
> +                    return -ENOMEM;
>              }
>  
>              rt_16550_set_config(ctx, config, &hist_buf);
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core


-- 

Philippe.

Re: [Xenomai-core] Fixes for serial driver

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Philippe Gerum wrote:
> Jan Kiszka wrote:
> 
>> Hi,
>>
>> attached are two minor fixes for the serial driver and header: one is
>> cosmetic, the other addresses out-of-memory detection.
>>
>> Credits go, as usual, to Sebastian. ;)
>>
> 
> Applied, thanks.
> 

Except for the highly critical, showstopping rtserial.h patch?! ;)

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

Re: [Xenomai-core] Fixes for serial driver

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Jan Kiszka wrote:
>>
>>
>>>Hi,
>>>
>>>attached are two minor fixes for the serial driver and header: one is
>>>cosmetic, the other addresses out-of-memory detection.
>>>
>>>Credits go, as usual, to Sebastian. ;)
>>>
>>
>>Applied, thanks.
>>
> 
> 
> Except for the highly critical, showstopping rtserial.h patch?! ;)
> 

Likely lost it. Resend please?

-- 

Philippe.

Re: [Xenomai-core] Fixes for serial driver

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Jan Kiszka wrote:
>>
>>
>>>Hi,
>>>
>>>attached are two minor fixes for the serial driver and header: one is
>>>cosmetic, the other addresses out-of-memory detection.
>>>
>>>Credits go, as usual, to Sebastian. ;)
>>>
>>
>>Applied, thanks.
>>
> 
> 
> Except for the highly critical, showstopping rtserial.h patch?! ;)

Mm, ok. The file was just pending commit in my tree. Done now.

-- 

Philippe.