All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Duffy <cduffy@spamcop.net>
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] network-bridge script support for multipleexternal interfaces
Date: Fri, 14 Oct 2005 11:18:33 -0500	[thread overview]
Message-ID: <434FDA59.8000208@spamcop.net> (raw)
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D32E3AE@liverpoolst.ad.cl.cam.ac.uk>

Ian Pratt wrote:
> I'd settle for being able to specify:
> 
> (network-script "network-bridge netdev=eth0 bridge=xenbr0
> virtnum=0","network-bridge netdev=eth1 bridge=xenbr1 virtnum=1")

Thus far I haven't done any messing with xend's code, and am not 
entirely sure I want to. This patch was intended *only* to include an 
updated helper, such that xend could later be extended by someone else 
to actually call that helper multiple times. Personally, to call the 
helper more than once, I've just written some new init scripts.

I'm willing to consider poking at xend, but *only* if someone who 
actually owns it says "okay, I'll merge a patch that does that if you 
implement it *like so*". Even if that means I'm doing more work to do it 
the maintainer's way, having specs from upstream means there's a much 
better chance of what I'm doing actually getting merged.

> [not totally convinced about the naming of virtnum. vifnum?]

I agree that vifnum is better.

> [What's the correct sxp syntax for specifying a list of strings?]

If they're being adequately lispy and my memory doesn't deceive me, the 
strings are just separated by spaces... as in (foo "bar" "baz" "qux") 
<to call foo w/ arguments bar, baz and qux>, '("foo" "bar" "baz") <to 
return a list with foo, bar and baz as contents>, or such.

  reply	other threads:[~2005-10-14 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-14 16:02 [PATCH] network-bridge script support for multipleexternal interfaces Ian Pratt
2005-10-14 16:18 ` Charles Duffy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-14 13:44 Ian Pratt
2005-10-14 14:16 ` Charles Duffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434FDA59.8000208@spamcop.net \
    --to=cduffy@spamcop.net \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.