All of lore.kernel.org
 help / color / mirror / Atom feed
* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-09-24 13:33 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-09-24 13:33 UTC (permalink / raw)
  To: alsa-devel


The following issue has been SUBMITTED.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              09-24-2005 15:33 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
======================================================================




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-05 17:07 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-10-05 17:07 UTC (permalink / raw)
  To: alsa-devel


A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-05-2005 19:07 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 tiwai - 10-05-05 19:07 
----------------------------------------------------------------------
Hmm, we should the limitation of the codec, too, then.

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-06 14:36 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-10-06 14:36 UTC (permalink / raw)
  To: alsa-devel


A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-06-2005 16:36 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 tiwai - 10-05-05 19:07 
----------------------------------------------------------------------
Hmm, we should the limitation of the codec, too, then.

----------------------------------------------------------------------
 anli - 10-06-05 16:36 
----------------------------------------------------------------------
BTW, the AES3-2003 document has nothing about 48KHz restriction. Moreover,
a status channel byte 4 has bits to set a sample rate uo to 192KHz.

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
10-06-05 16:36 anli           Note Added: 0006443                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-06 14:40 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-10-06 14:40 UTC (permalink / raw)
  To: alsa-devel


A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-06-2005 16:40 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 anli - 10-06-05 16:36 
----------------------------------------------------------------------
BTW, the AES3-2003 document has nothing about 48KHz restriction. Moreover,
a status channel byte 4 has bits to set a sample rate uo to 192KHz.

----------------------------------------------------------------------
 anli - 10-06-05 16:40 
----------------------------------------------------------------------
Tiwai,

Sorry, have not uderstood your comment. The WM8770 codec hasn't such
limitations. And, again, few versions ago I used 96KHz with JACK server
without noticed problems (and used DAC showed explicitly 96KHz sample
rate).

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
10-06-05 16:36 anli           Note Added: 0006443                          
10-06-05 16:40 anli           Note Added: 0006444                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-11 15:22 bugtrack
  2005-10-11 17:52 ` Andrew Gaydenko
  0 siblings, 1 reply; 11+ messages in thread
From: bugtrack @ 2005-10-11 15:22 UTC (permalink / raw)
  To: alsa-devel


A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-11-2005 17:22 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 anli - 10-06-05 20:40 
----------------------------------------------------------------------
Tiwai,

Sorry, have not uderstood your comment. The WM8770 codec hasn't such
limitations. And, again, few the driver versions ago I used 96KHz with
JACK server without noticed problems (and used DAC showed explicitly 96KHz
sample rate).



----------------------------------------------------------------------
 tiwai - 10-11-05 17:22 
----------------------------------------------------------------------
Ah sorry, I misunerdstood the topic about ice1712.
Could you try the attached patch?

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
10-06-05 16:36 anli           Note Added: 0006443                          
10-06-05 16:40 anli           Note Added: 0006444                          
10-06-05 17:14 anli           Note Edited: 0006443                         
10-06-05 17:25 anli           Issue Monitored: anli                        
10-06-05 20:40 anli           Note Edited: 0006444                         
10-07-05 11:16 anli           Note Edited: 0006443                         
10-11-05 17:22 tiwai          Note Added: 0006455                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
  2005-10-11 15:22 [ALSA - driver 0001450]: SPDIF out is limited with 48KHz bugtrack
@ 2005-10-11 17:52 ` Andrew Gaydenko
  2005-10-12  9:44   ` Takashi Iwai
  0 siblings, 1 reply; 11+ messages in thread
From: Andrew Gaydenko @ 2005-10-11 17:52 UTC (permalink / raw)
  To: alsa-devel

Takashi,

Unfortunately, routing problem still exists for (my host)-(bugtrack.alsa-project.org)
path. Is it possible to use the mailing list or my direct email (a@gaydenko.com) to
send the patch?

With hope,
Andrew

======= On Tuesday 11 October 2005 19:22, bugtrack@alsa-project.org wrote: =======

Summary:                    SPDIF out is limited with 48KHz
...

----------------------------------------------------------------------
 tiwai - 10-11-05 17:22 
----------------------------------------------------------------------
Ah sorry, I misunerdstood the topic about ice1712.
Could you try the attached patch?



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-11 19:24 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-10-11 19:24 UTC (permalink / raw)
  To: alsa-devel


A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-11-2005 21:23 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 tiwai - 10-11-05 17:22 
----------------------------------------------------------------------
Ah sorry, I misunerdstood the topic about ice1712.
Could you try the attached patch?

----------------------------------------------------------------------
 anli - 10-11-05 21:23 
----------------------------------------------------------------------
Takashi,

I have applayed the patch, and - it is incredible! - 96KHz works: I have
loopbacked SPDIF out to SPDIF input, started JACK and jaaa, and now I am
observing at jaaa screen an accuracy of this SPDIF loopback :-)

Big-big thanks!

Andrew

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
10-06-05 16:36 anli           Note Added: 0006443                          
10-06-05 16:40 anli           Note Added: 0006444                          
10-06-05 17:14 anli           Note Edited: 0006443                         
10-06-05 17:25 anli           Issue Monitored: anli                        
10-06-05 20:40 anli           Note Edited: 0006444                         
10-07-05 11:16 anli           Note Edited: 0006443                         
10-11-05 17:22 tiwai          Note Added: 0006455                          
10-11-05 17:23 tiwai          File Added: ice1724-spdif-rate-fix.diff           
        
10-11-05 21:23 anli           Note Added: 0006459                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
  2005-10-11 17:52 ` Andrew Gaydenko
@ 2005-10-12  9:44   ` Takashi Iwai
  2005-10-15  3:28     ` Philip Prindeville
  0 siblings, 1 reply; 11+ messages in thread
From: Takashi Iwai @ 2005-10-12  9:44 UTC (permalink / raw)
  To: Andrew Gaydenko; +Cc: alsa-devel

At Tue, 11 Oct 2005 21:52:18 +0400,
Andrew Gaydenko wrote:
> 
> Takashi,
> 
> Unfortunately, routing problem still exists for (my host)-(bugtrack.alsa-project.org)
> path. Is it possible to use the mailing list or my direct email (a@gaydenko.com) to
> send the patch?

BTS host seems instable for the time being.

Anyway, the patch is below, and I already committed it to CVS tree now
:)


Takashi

Index: alsa-kernel/pci/ice1712/ice1724.c
===================================================================
RCS file: /home/iwai/cvs/alsa/alsa-kernel/pci/ice1712/ice1724.c,v
retrieving revision 1.67
diff -u -r1.67 ice1724.c
--- alsa-kernel/pci/ice1712/ice1724.c	12 Sep 2005 10:27:50 -0000	1.67
+++ alsa-kernel/pci/ice1712/ice1724.c	11 Oct 2005 15:18:42 -0000
@@ -675,9 +675,12 @@
 				 SNDRV_PCM_INFO_MMAP_VALID |
 				 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_SYNC_START),
 	.formats =		SNDRV_PCM_FMTBIT_S32_LE,
-	.rates =	        SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|SNDRV_PCM_RATE_48000,
+	.rates =	        (SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|
+				 SNDRV_PCM_RATE_48000|SNDRV_PCM_RATE_88200|
+				 SNDRV_PCM_RATE_96000|SNDRV_PCM_RATE_176400|
+				 SNDRV_PCM_RATE_192000),
 	.rate_min =		32000,
-	.rate_max =		48000,
+	.rate_max =		192000,
 	.channels_min =		2,
 	.channels_max =		2,
 	.buffer_bytes_max =	(1UL << 18),	/* 16bits dword */
@@ -905,6 +908,10 @@
 	case 44100: break;
 	case 48000: nval |= 2 << 12; break;
 	case 32000: nval |= 3 << 12; break;
+	case 88200: nval |= 4 << 12; break;
+	case 96000: nval |= 5 << 12; break;
+	case 192000: nval |= 6 << 12; break;
+	case 176400: nval |= 7 << 12; break;
 	}
 	if (val != nval)
 		update_spdif_bits(ice, nval);
@@ -1292,22 +1299,32 @@
 
 static unsigned int encode_spdif_bits(snd_aes_iec958_t *diga)
 {
-	unsigned int val;
+	unsigned int val, rbits;
 
 	val = diga->status[0] & 0x03; /* professional, non-audio */
 	if (val & 0x01) {
 		/* professional */
 		if ((diga->status[0] & IEC958_AES0_PRO_EMPHASIS) == IEC958_AES0_PRO_EMPHASIS_5015)
 			val |= 1U << 3;
-		switch (diga->status[0] & IEC958_AES0_PRO_FS) {
-		case IEC958_AES0_PRO_FS_44100:
-			break;
-		case IEC958_AES0_PRO_FS_32000:
-			val |= 3U << 12;
-			break;
-		default:
-			val |= 2U << 12;
-			break;
+		rbits = (diga->status[4] >> 3) & 0x0f;
+		if (rbits) {
+			switch (rbits) {
+			case 2: val |= 5 << 12; break; /* 96k */
+			case 3: val |= 6 << 12; break; /* 192k */
+			case 10: val |= 4 << 12; break; /* 88.2k */
+			case 11: val |= 7 << 12; break; /* 176.4k */
+			}
+		} else {
+			switch (diga->status[0] & IEC958_AES0_PRO_FS) {
+			case IEC958_AES0_PRO_FS_44100:
+				break;
+			case IEC958_AES0_PRO_FS_32000:
+				val |= 3U << 12;
+				break;
+			default:
+				val |= 2U << 12;
+				break;
+			}
 		}
 	} else {
 		/* consumer */


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
@ 2005-10-12 10:39 bugtrack
  0 siblings, 0 replies; 11+ messages in thread
From: bugtrack @ 2005-10-12 10:39 UTC (permalink / raw)
  To: alsa-devel


The following issue has been RESOLVED.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1450> 
======================================================================
Reported By:                anli
Assigned To:                tiwai
======================================================================
Project:                    ALSA - driver
Issue ID:                   1450
Category:                   PCI - ice1724
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     resolved
Distribution:               
Kernel Version:             
Resolution:                 fixed
Fixed in Version:           
======================================================================
Date Submitted:             09-24-2005 15:33 CEST
Last Modified:              10-12-2005 12:39 CEST
======================================================================
Summary:                    SPDIF out is limited with 48KHz
Description: 
Last the driver version which worked perfectly (i.e. with 96KHz SPDIF out
sample rate) is 1.04. And I was able to use SPDIF out with JACK at
96KHz/32bit mode _without_ any problems.

Now SPDIF out is limited with 48KHz srate. Long time ago developers
argumented 48KHz limit as it is SPDIF standard. On the other hand all
(semi)pro DACs suuport 96KHz. This is true for all ice1724 cards too.
Moreover, we are in the open source world at last :-)

Please, revert this limit back. I'm ready to test the driver from CVS
tree.

Andrew

======================================================================

----------------------------------------------------------------------
 anli - 10-11-05 21:23 
----------------------------------------------------------------------
Takashi,

I have applayed the patch, and - it is incredible! - 96KHz works: I have
loopbacked SPDIF out to SPDIF input, started JACK and jaaa, and now I am
observing at jaaa screen an accuracy of this SPDIF loopback :-)

Big-big thanks!

Andrew

----------------------------------------------------------------------
 tiwai - 10-12-05 12:39 
----------------------------------------------------------------------
Thanks for confirmation.  It's on CVS now.

Issue History
Date Modified  Username       Field                    Change              
======================================================================
09-24-05 15:33 anli           New Issue                                    
10-05-05 19:07 tiwai          Note Added: 0006441                          
10-06-05 16:36 anli           Note Added: 0006443                          
10-06-05 16:40 anli           Note Added: 0006444                          
10-06-05 17:14 anli           Note Edited: 0006443                         
10-06-05 17:25 anli           Issue Monitored: anli                        
10-06-05 20:40 anli           Note Edited: 0006444                         
10-07-05 11:16 anli           Note Edited: 0006443                         
10-11-05 17:22 tiwai          Note Added: 0006455                          
10-11-05 17:23 tiwai          File Added: ice1724-spdif-rate-fix.diff           
        
10-11-05 21:23 anli           Note Added: 0006459                          
10-12-05 12:39 tiwai          Status                   new => resolved     
10-12-05 12:39 tiwai          Resolution               open => fixed       
10-12-05 12:39 tiwai          Assigned To               => tiwai           
10-12-05 12:39 tiwai          Note Added: 0006462                          
======================================================================




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
  2005-10-12  9:44   ` Takashi Iwai
@ 2005-10-15  3:28     ` Philip Prindeville
  2005-10-17 10:04       ` Takashi Iwai
  0 siblings, 1 reply; 11+ messages in thread
From: Philip Prindeville @ 2005-10-15  3:28 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Andrew Gaydenko, alsa-devel

Takashi Iwai wrote:

>At Tue, 11 Oct 2005 21:52:18 +0400,
>Andrew Gaydenko wrote:
>  
>
>>Takashi,
>>
>>Unfortunately, routing problem still exists for (my host)-(bugtrack.alsa-project.org)
>>path. Is it possible to use the mailing list or my direct email (a@gaydenko.com) to
>>send the patch?
>>    
>>
>
>BTS host seems instable for the time being.
>
>Anyway, the patch is below, and I already committed it to CVS tree now
>:)
>
>
>Takashi
>
>Index: alsa-kernel/pci/ice1712/ice1724.c
>===================================================================
>RCS file: /home/iwai/cvs/alsa/alsa-kernel/pci/ice1712/ice1724.c,v
>retrieving revision 1.67
>diff -u -r1.67 ice1724.c
>--- alsa-kernel/pci/ice1712/ice1724.c	12 Sep 2005 10:27:50 -0000	1.67
>+++ alsa-kernel/pci/ice1712/ice1724.c	11 Oct 2005 15:18:42 -0000
>@@ -675,9 +675,12 @@
> 				 SNDRV_PCM_INFO_MMAP_VALID |
> 				 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_SYNC_START),
> 	.formats =		SNDRV_PCM_FMTBIT_S32_LE,
>-	.rates =	        SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|SNDRV_PCM_RATE_48000,
>+	.rates =	        (SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|
>+				 SNDRV_PCM_RATE_48000|SNDRV_PCM_RATE_88200|
>+				 SNDRV_PCM_RATE_96000|SNDRV_PCM_RATE_176400|
>+				 SNDRV_PCM_RATE_192000),
> 	.rate_min =		32000,
>-	.rate_max =		48000,
>+	.rate_max =		192000,
> 	.channels_min =		2,
> 	.channels_max =		2,
> 	.buffer_bytes_max =	(1UL << 18),	/* 16bits dword */
>@@ -905,6 +908,10 @@
> 	case 44100: break;
> 	case 48000: nval |= 2 << 12; break;
> 	case 32000: nval |= 3 << 12; break;
>+	case 88200: nval |= 4 << 12; break;
>+	case 96000: nval |= 5 << 12; break;
>+	case 192000: nval |= 6 << 12; break;
>+	case 176400: nval |= 7 << 12; break;
> 	}
> 	if (val != nval)
> 		update_spdif_bits(ice, nval);
>@@ -1292,22 +1299,32 @@
> 
> static unsigned int encode_spdif_bits(snd_aes_iec958_t *diga)
> {
>-	unsigned int val;
>+	unsigned int val, rbits;
> 
> 	val = diga->status[0] & 0x03; /* professional, non-audio */
> 	if (val & 0x01) {
> 		/* professional */
> 		if ((diga->status[0] & IEC958_AES0_PRO_EMPHASIS) == IEC958_AES0_PRO_EMPHASIS_5015)
> 			val |= 1U << 3;
>-		switch (diga->status[0] & IEC958_AES0_PRO_FS) {
>-		case IEC958_AES0_PRO_FS_44100:
>-			break;
>-		case IEC958_AES0_PRO_FS_32000:
>-			val |= 3U << 12;
>-			break;
>-		default:
>-			val |= 2U << 12;
>-			break;
>+		rbits = (diga->status[4] >> 3) & 0x0f;
>+		if (rbits) {
>+			switch (rbits) {
>+			case 2: val |= 5 << 12; break; /* 96k */
>+			case 3: val |= 6 << 12; break; /* 192k */
>+			case 10: val |= 4 << 12; break; /* 88.2k */
>+			case 11: val |= 7 << 12; break; /* 176.4k */
>+			}
>+		} else {
>+			switch (diga->status[0] & IEC958_AES0_PRO_FS) {
>+			case IEC958_AES0_PRO_FS_44100:
>+				break;
>+			case IEC958_AES0_PRO_FS_32000:
>+				val |= 3U << 12;
>+				break;
>+			default:
>+				val |= 2U << 12;
>+				break;
>+			}
> 		}
> 	} else {
> 		/* consumer */
>
>  
>

I don't suppose the patch is anyway applicable to the DRS capable
VIA southbridges, is it?

Also... on a broader note...  SPDIF is an asynchronous transport, right?

The transmission rate is unrelated to the actual playback rate, since you
can carry compressed PCM, DTS, DolbyD, etc. all over the same
transport...

If that's the case, why not send 44.1kHz data as uncompressed "compressed
PCM" (i.e. flag it as being compressed, but then don't really compress it,
or compress it losslessly) over SPDIF if it can only do 48kHz (on the
sender's side)?

-Philip



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ALSA - driver 0001450]: SPDIF out is limited with 48KHz
  2005-10-15  3:28     ` Philip Prindeville
@ 2005-10-17 10:04       ` Takashi Iwai
  0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2005-10-17 10:04 UTC (permalink / raw)
  To: Philip Prindeville; +Cc: Andrew Gaydenko, alsa-devel

At Fri, 14 Oct 2005 21:28:50 -0600,
Philip Prindeville wrote:
> 
> Takashi Iwai wrote:
> 
> >At Tue, 11 Oct 2005 21:52:18 +0400,
> >Andrew Gaydenko wrote:
> >  
> >
> >>Takashi,
> >>
> >>Unfortunately, routing problem still exists for (my host)-(bugtrack.alsa-project.org)
> >>path. Is it possible to use the mailing list or my direct email (a@gaydenko.com) to
> >>send the patch?
> >>    
> >>
> >
> >BTS host seems instable for the time being.
> >
> >Anyway, the patch is below, and I already committed it to CVS tree now
> >:)
> >
> >
> >Takashi
> >
> >Index: alsa-kernel/pci/ice1712/ice1724.c
> >===================================================================
> >RCS file: /home/iwai/cvs/alsa/alsa-kernel/pci/ice1712/ice1724.c,v
> >retrieving revision 1.67
> >diff -u -r1.67 ice1724.c
> >--- alsa-kernel/pci/ice1712/ice1724.c	12 Sep 2005 10:27:50 -0000	1.67
> >+++ alsa-kernel/pci/ice1712/ice1724.c	11 Oct 2005 15:18:42 -0000
> >@@ -675,9 +675,12 @@
> > 				 SNDRV_PCM_INFO_MMAP_VALID |
> > 				 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_SYNC_START),
> > 	.formats =		SNDRV_PCM_FMTBIT_S32_LE,
> >-	.rates =	        SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|SNDRV_PCM_RATE_48000,
> >+	.rates =	        (SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|
> >+				 SNDRV_PCM_RATE_48000|SNDRV_PCM_RATE_88200|
> >+				 SNDRV_PCM_RATE_96000|SNDRV_PCM_RATE_176400|
> >+				 SNDRV_PCM_RATE_192000),
> > 	.rate_min =		32000,
> >-	.rate_max =		48000,
> >+	.rate_max =		192000,
> > 	.channels_min =		2,
> > 	.channels_max =		2,
> > 	.buffer_bytes_max =	(1UL << 18),	/* 16bits dword */
> >@@ -905,6 +908,10 @@
> > 	case 44100: break;
> > 	case 48000: nval |= 2 << 12; break;
> > 	case 32000: nval |= 3 << 12; break;
> >+	case 88200: nval |= 4 << 12; break;
> >+	case 96000: nval |= 5 << 12; break;
> >+	case 192000: nval |= 6 << 12; break;
> >+	case 176400: nval |= 7 << 12; break;
> > 	}
> > 	if (val != nval)
> > 		update_spdif_bits(ice, nval);
> >@@ -1292,22 +1299,32 @@
> > 
> > static unsigned int encode_spdif_bits(snd_aes_iec958_t *diga)
> > {
> >-	unsigned int val;
> >+	unsigned int val, rbits;
> > 
> > 	val = diga->status[0] & 0x03; /* professional, non-audio */
> > 	if (val & 0x01) {
> > 		/* professional */
> > 		if ((diga->status[0] & IEC958_AES0_PRO_EMPHASIS) == IEC958_AES0_PRO_EMPHASIS_5015)
> > 			val |= 1U << 3;
> >-		switch (diga->status[0] & IEC958_AES0_PRO_FS) {
> >-		case IEC958_AES0_PRO_FS_44100:
> >-			break;
> >-		case IEC958_AES0_PRO_FS_32000:
> >-			val |= 3U << 12;
> >-			break;
> >-		default:
> >-			val |= 2U << 12;
> >-			break;
> >+		rbits = (diga->status[4] >> 3) & 0x0f;
> >+		if (rbits) {
> >+			switch (rbits) {
> >+			case 2: val |= 5 << 12; break; /* 96k */
> >+			case 3: val |= 6 << 12; break; /* 192k */
> >+			case 10: val |= 4 << 12; break; /* 88.2k */
> >+			case 11: val |= 7 << 12; break; /* 176.4k */
> >+			}
> >+		} else {
> >+			switch (diga->status[0] & IEC958_AES0_PRO_FS) {
> >+			case IEC958_AES0_PRO_FS_44100:
> >+				break;
> >+			case IEC958_AES0_PRO_FS_32000:
> >+				val |= 3U << 12;
> >+				break;
> >+			default:
> >+				val |= 2U << 12;
> >+				break;
> >+			}
> > 		}
> > 	} else {
> > 		/* consumer */
> >
> >  
> >
> 
> I don't suppose the patch is anyway applicable to the DRS capable
> VIA southbridges, is it?

It's irrelevant.

> Also... on a broader note...  SPDIF is an asynchronous transport, right?

I'm not 100% sure whether the definition is asynchronous, too...

> The transmission rate is unrelated to the actual playback rate, since you
> can carry compressed PCM, DTS, DolbyD, etc. all over the same
> transport...

No, the "rate" there is the transport rate.
Note that currently ALSA PCM supports only the constant transport
rate.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2005-10-17 10:04 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-11 15:22 [ALSA - driver 0001450]: SPDIF out is limited with 48KHz bugtrack
2005-10-11 17:52 ` Andrew Gaydenko
2005-10-12  9:44   ` Takashi Iwai
2005-10-15  3:28     ` Philip Prindeville
2005-10-17 10:04       ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2005-10-12 10:39 bugtrack
2005-10-11 19:24 bugtrack
2005-10-06 14:40 bugtrack
2005-10-06 14:36 bugtrack
2005-10-05 17:07 bugtrack
2005-09-24 13:33 bugtrack

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.